From: nick <xerofoify@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH RESEND 1/2] ixgb:Remove reducant error path after call to ixgb_sw_init in the function ixgb_probe
Date: Wed, 14 Oct 2015 21:25:59 -0400 [thread overview]
Message-ID: <561F00A7.1050907@gmail.com> (raw)
In-Reply-To: <1444872183.2928.6.camel@intel.com>
On 2015-10-14 09:23 PM, Jeff Kirsher wrote:
> On Wed, 2015-10-14 at 18:57 -0400, Nicholas Krause wrote:
>> This removes the reducant error path and now no longer used goto
>> label err_sw_init after the call to ixgb_probe in the function
>> ixgb_sw_init after calling this function due to it always returning
>> zero as it is guarantee to run successfully without any issues.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>> drivers/net/ethernet/intel/ixgb/ixgb_main.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> This driver (ixgb), as well as e100 and e1000 are in maintenance mode
> which means bug fixes ONLY!
>
> Is this patch necessary? Answer: No
> Is this a bug fix? Answer: No
> Should you have sent this patch? See answers to previous questions.
>
> Please ask these questions to yourself when putting together a patch
> against these drivers (listed above).
>
> With that said, dropping this series.
>
Sorry Jeff,
I was not aware that these drivers are in maintenance only mode and therefore thought
this OK.
Nick
prev parent reply other threads:[~2015-10-15 1:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 22:57 [Intel-wired-lan] [PATCH RESEND 1/2] ixgb:Remove reducant error path after call to ixgb_sw_init in the function ixgb_probe Nicholas Krause
2015-10-14 22:57 ` [Intel-wired-lan] [PATCH 2/2] ixgb:Make the function ixgb_sw_init void Nicholas Krause
2015-10-15 1:23 ` [Intel-wired-lan] [PATCH RESEND 1/2] ixgb:Remove reducant error path after call to ixgb_sw_init in the function ixgb_probe Jeff Kirsher
2015-10-15 1:23 ` Jeff Kirsher
2015-10-15 1:25 ` nick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561F00A7.1050907@gmail.com \
--to=xerofoify@gmail.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.