From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH RESEND 1/2] ixgb:Remove reducant error path after call to ixgb_sw_init in the function ixgb_probe
Date: Wed, 14 Oct 2015 18:23:03 -0700 [thread overview]
Message-ID: <1444872183.2928.6.camel@intel.com> (raw)
In-Reply-To: <1444863479-31570-1-git-send-email-xerofoify@gmail.com>
On Wed, 2015-10-14 at 18:57 -0400, Nicholas Krause wrote:
> This removes the reducant error path and now no longer used goto
> label err_sw_init after the call to ixgb_probe in the function
> ixgb_sw_init after calling this function due to it always returning
> zero as it is guarantee to run successfully without any issues.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/net/ethernet/intel/ixgb/ixgb_main.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
This driver (ixgb), as well as e100 and e1000 are in maintenance mode
which means bug fixes ONLY!
Is this patch necessary? Answer: No
Is this a bug fix? Answer: No
Should you have sent this patch? See answers to previous questions.
Please ask these questions to yourself when putting together a patch
against these drivers (listed above).
With that said, dropping this series.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20151014/61473924/attachment.asc>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: jesse.brandeburg@intel.com, shannon.nelson@intel.com,
carolyn.wyborny@intel.com, donald.c.skidmore@intel.com,
matthew.vick@intel.com, john.ronciak@intel.com,
mitch.a.williams@intel.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 1/2] ixgb:Remove reducant error path after call to ixgb_sw_init in the function ixgb_probe
Date: Wed, 14 Oct 2015 18:23:03 -0700 [thread overview]
Message-ID: <1444872183.2928.6.camel@intel.com> (raw)
In-Reply-To: <1444863479-31570-1-git-send-email-xerofoify@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
On Wed, 2015-10-14 at 18:57 -0400, Nicholas Krause wrote:
> This removes the reducant error path and now no longer used goto
> label err_sw_init after the call to ixgb_probe in the function
> ixgb_sw_init after calling this function due to it always returning
> zero as it is guarantee to run successfully without any issues.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/net/ethernet/intel/ixgb/ixgb_main.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
This driver (ixgb), as well as e100 and e1000 are in maintenance mode
which means bug fixes ONLY!
Is this patch necessary? Answer: No
Is this a bug fix? Answer: No
Should you have sent this patch? See answers to previous questions.
Please ask these questions to yourself when putting together a patch
against these drivers (listed above).
With that said, dropping this series.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-15 1:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 22:57 [Intel-wired-lan] [PATCH RESEND 1/2] ixgb:Remove reducant error path after call to ixgb_sw_init in the function ixgb_probe Nicholas Krause
2015-10-14 22:57 ` [Intel-wired-lan] [PATCH 2/2] ixgb:Make the function ixgb_sw_init void Nicholas Krause
2015-10-15 1:23 ` Jeff Kirsher [this message]
2015-10-15 1:23 ` [PATCH RESEND 1/2] ixgb:Remove reducant error path after call to ixgb_sw_init in the function ixgb_probe Jeff Kirsher
2015-10-15 1:25 ` [Intel-wired-lan] " nick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444872183.2928.6.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.