[PATCH] pinctrl: always include all subdirectories in build

[PATCH] pinctrl: always include all subdirectories in build

[Jonas Gorski]

All pinctrl drivers in subdirectories are properly guarded by individual
configuration symbols, so there is no need to limit the directories to
the belonging machines.

This allows wider COMPILE_TEST coverage on "foreign" targets.

Signed-off-by: Jonas Gorski <jogo@openwrt.org>
---
 drivers/pinctrl/Makefile | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
index cad077c..2eb25a8 100644
--- a/drivers/pinctrl/Makefile
+++ b/drivers/pinctrl/Makefile
@@ -39,17 +39,17 @@ obj-$(CONFIG_PINCTRL_TB10X)	+= pinctrl-tb10x.o
 obj-$(CONFIG_PINCTRL_ST) 	+= pinctrl-st.o
 obj-$(CONFIG_PINCTRL_ZYNQ)	+= pinctrl-zynq.o
 
-obj-$(CONFIG_ARCH_BCM)		+= bcm/
-obj-$(CONFIG_ARCH_BERLIN)	+= berlin/
+obj-y				+= bcm/
+obj-y				+= berlin/
 obj-y				+= freescale/
-obj-$(CONFIG_X86)		+= intel/
-obj-$(CONFIG_PLAT_ORION)        += mvebu/
+obj-y				+= intel/
+obj-y				+= mvebu/
 obj-y				+= nomadik/
-obj-$(CONFIG_ARCH_QCOM)		+= qcom/
-obj-$(CONFIG_PINCTRL_SAMSUNG)	+= samsung/
-obj-$(CONFIG_PINCTRL_SH_PFC)	+= sh-pfc/
-obj-$(CONFIG_PLAT_SPEAR)	+= spear/
-obj-$(CONFIG_ARCH_SUNXI)	+= sunxi/
-obj-$(CONFIG_ARCH_UNIPHIER)	+= uniphier/
-obj-$(CONFIG_ARCH_VT8500)	+= vt8500/
-obj-$(CONFIG_ARCH_MEDIATEK)	+= mediatek/
+obj-y				+= qcom/
+obj-y				+= samsung/
+obj-y				+= sh-pfc/
+obj-y				+= spear/
+obj-y				+= sunxi/
+obj-y				+= uniphier/
+obj-y				+= vt8500/
+obj-y				+= mediatek/
-- 
2.1.4

Re: [PATCH] pinctrl: always include all subdirectories in build

[Viresh Kumar]

On 11-10-15, 17:40, Jonas Gorski wrote:
> All pinctrl drivers in subdirectories are properly guarded by individual
> configuration symbols, so there is no need to limit the directories to
> the belonging machines.
> 
> This allows wider COMPILE_TEST coverage on "foreign" targets.
> 
> Signed-off-by: Jonas Gorski <jogo@openwrt.org>
> ---
>  drivers/pinctrl/Makefile | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 

For SPEAr:

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Re: [PATCH] pinctrl: always include all subdirectories in build

[Matthias Brugger]

On 11/10/15 17:40, Jonas Gorski wrote:
> All pinctrl drivers in subdirectories are properly guarded by individual
> configuration symbols, so there is no need to limit the directories to
> the belonging machines.
>
> This allows wider COMPILE_TEST coverage on "foreign" targets.
>
> Signed-off-by: Jonas Gorski <jogo@openwrt.org>
> ---
>   drivers/pinctrl/Makefile | 24 ++++++++++++------------
>   1 file changed, 12 insertions(+), 12 deletions(-)

For Mediatek:

Acked-by: Matthias Brugger <matthias.bgg@gmail.com>

>
> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
> index cad077c..2eb25a8 100644
> --- a/drivers/pinctrl/Makefile
> +++ b/drivers/pinctrl/Makefile
> @@ -39,17 +39,17 @@ obj-$(CONFIG_PINCTRL_TB10X)	+= pinctrl-tb10x.o
>   obj-$(CONFIG_PINCTRL_ST) 	+= pinctrl-st.o
>   obj-$(CONFIG_PINCTRL_ZYNQ)	+= pinctrl-zynq.o
>
> -obj-$(CONFIG_ARCH_BCM)		+= bcm/
> -obj-$(CONFIG_ARCH_BERLIN)	+= berlin/
> +obj-y				+= bcm/
> +obj-y				+= berlin/
>   obj-y				+= freescale/
> -obj-$(CONFIG_X86)		+= intel/
> -obj-$(CONFIG_PLAT_ORION)        += mvebu/
> +obj-y				+= intel/
> +obj-y				+= mvebu/
>   obj-y				+= nomadik/
> -obj-$(CONFIG_ARCH_QCOM)		+= qcom/
> -obj-$(CONFIG_PINCTRL_SAMSUNG)	+= samsung/
> -obj-$(CONFIG_PINCTRL_SH_PFC)	+= sh-pfc/
> -obj-$(CONFIG_PLAT_SPEAR)	+= spear/
> -obj-$(CONFIG_ARCH_SUNXI)	+= sunxi/
> -obj-$(CONFIG_ARCH_UNIPHIER)	+= uniphier/
> -obj-$(CONFIG_ARCH_VT8500)	+= vt8500/
> -obj-$(CONFIG_ARCH_MEDIATEK)	+= mediatek/
> +obj-y				+= qcom/
> +obj-y				+= samsung/
> +obj-y				+= sh-pfc/
> +obj-y				+= spear/
> +obj-y				+= sunxi/
> +obj-y				+= uniphier/
> +obj-y				+= vt8500/
> +obj-y				+= mediatek/
>

Re: [PATCH] pinctrl: always include all subdirectories in build

[Laurent Pinchart]

Hi Jonas,

(Reducing the CC list a bit to avoid spamming people)

Thank you for the patch.

On Sunday 11 October 2015 17:40:44 Jonas Gorski wrote:
> All pinctrl drivers in subdirectories are properly guarded by individual
> configuration symbols, so there is no need to limit the directories to
> the belonging machines.
> 
> This allows wider COMPILE_TEST coverage on "foreign" targets.
> 
> Signed-off-by: Jonas Gorski <jogo@openwrt.org>

For sh-pfc,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/pinctrl/Makefile | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
> index cad077c..2eb25a8 100644
> --- a/drivers/pinctrl/Makefile
> +++ b/drivers/pinctrl/Makefile
> @@ -39,17 +39,17 @@ obj-$(CONFIG_PINCTRL_TB10X)	+= pinctrl-tb10x.o
>  obj-$(CONFIG_PINCTRL_ST) 	+= pinctrl-st.o
>  obj-$(CONFIG_PINCTRL_ZYNQ)	+= pinctrl-zynq.o
> 
> -obj-$(CONFIG_ARCH_BCM)		+= bcm/
> -obj-$(CONFIG_ARCH_BERLIN)	+= berlin/
> +obj-y				+= bcm/
> +obj-y				+= berlin/
>  obj-y				+= freescale/
> -obj-$(CONFIG_X86)		+= intel/
> -obj-$(CONFIG_PLAT_ORION)        += mvebu/
> +obj-y				+= intel/
> +obj-y				+= mvebu/
>  obj-y				+= nomadik/
> -obj-$(CONFIG_ARCH_QCOM)		+= qcom/
> -obj-$(CONFIG_PINCTRL_SAMSUNG)	+= samsung/
> -obj-$(CONFIG_PINCTRL_SH_PFC)	+= sh-pfc/
> -obj-$(CONFIG_PLAT_SPEAR)	+= spear/
> -obj-$(CONFIG_ARCH_SUNXI)	+= sunxi/
> -obj-$(CONFIG_ARCH_UNIPHIER)	+= uniphier/
> -obj-$(CONFIG_ARCH_VT8500)	+= vt8500/
> -obj-$(CONFIG_ARCH_MEDIATEK)	+= mediatek/
> +obj-y				+= qcom/
> +obj-y				+= samsung/
> +obj-y				+= sh-pfc/
> +obj-y				+= spear/
> +obj-y				+= sunxi/
> +obj-y				+= uniphier/
> +obj-y				+= vt8500/
> +obj-y				+= mediatek/

-- 
Regards,

Laurent Pinchart

Re: [PATCH] pinctrl: always include all subdirectories in build

[Thomas Petazzoni]

Dear Jonas Gorski,

On Sun, 11 Oct 2015 17:40:44 +0200, Jonas Gorski wrote:
> All pinctrl drivers in subdirectories are properly guarded by individual
> configuration symbols, so there is no need to limit the directories to
> the belonging machines.
> 
> This allows wider COMPILE_TEST coverage on "foreign" targets.
> 
> Signed-off-by: Jonas Gorski <jogo@openwrt.org>
> ---
>  drivers/pinctrl/Makefile | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)

For mvebu:

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH] pinctrl: always include all subdirectories in build

[Mika Westerberg]

On Sun, Oct 11, 2015 at 05:40:44PM +0200, Jonas Gorski wrote:
> All pinctrl drivers in subdirectories are properly guarded by individual
> configuration symbols, so there is no need to limit the directories to
> the belonging machines.
> 
> This allows wider COMPILE_TEST coverage on "foreign" targets.
> 
> Signed-off-by: Jonas Gorski <jogo@openwrt.org>

...

> +obj-y				+= intel/

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Re: [PATCH] pinctrl: always include all subdirectories in build

[Eric Anholt]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

Jonas Gorski <jogo@openwrt.org> writes:

> All pinctrl drivers in subdirectories are properly guarded by individual
> configuration symbols, so there is no need to limit the directories to
> the belonging machines.
>
> This allows wider COMPILE_TEST coverage on "foreign" targets.

Thanks!  Unrelatedly, I actually ended up being surprised by clk-bcm2835
being gated on CONFIG_ARCH_BCM today.  For bcm2835:

Acked-by: Eric Anholt <eric@anholt.net>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [PATCH] pinctrl: always include all subdirectories in build

[Bjorn Andersson]

On Sun, Oct 11, 2015 at 8:40 AM, Jonas Gorski <jogo@openwrt.org> wrote:
[..]
> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
[..]
> +obj-y                          += qcom/

Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>

Regards,
Bjorn

Re: [PATCH] pinctrl: always include all subdirectories in build

[Ray Jui]

On 10/11/2015 8:40 AM, Jonas Gorski wrote:
> All pinctrl drivers in subdirectories are properly guarded by individual
> configuration symbols, so there is no need to limit the directories to
> the belonging machines.
> 
> This allows wider COMPILE_TEST coverage on "foreign" targets.
> 
> Signed-off-by: Jonas Gorski <jogo@openwrt.org>
> ---
>  drivers/pinctrl/Makefile | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)

For ARCH_BCM,

Acked-by: Ray Jui <rjui@broadcom.com>

Thanks,

Ray

RE: [PATCH] pinctrl: always include all subdirectories in build

[yamada.masahiro]

Hi.


> From: linux-gpio-owner@vger.kernel.org
> [mailto:linux-gpio-owner@vger.kernel.org] On Behalf Of Jonas Gorski
> Sent: Monday, October 12, 2015 12:41 AM
> To: linux-gpio@vger.kernel.org
> Cc: Linus Walleij; Alexandre Courbot; Thomas Petazzoni; Stephen Warren;
> Lee Jones; Eric Anholt; Florian Fainelli; Ray Jui; Scott Branden; Mika
> Westerberg; Heikki Krogerus; Matthias Brugger; Maxime Coquelin; Kumar Gala;
> Andy Gross; David Brown; Viresh Kumar; Tomasz Figa; Tony Prisk; Sebastian
> Hesselbarth; Laurent Pinchart; Yamada, Masahiro/山田 真弘
> Subject: [PATCH] pinctrl: always include all subdirectories in build
> 
> All pinctrl drivers in subdirectories are properly guarded by individual
> configuration symbols, so there is no need to limit the directories to the
> belonging machines.
> 
> This allows wider COMPILE_TEST coverage on "foreign" targets.
> 
> Signed-off-by: Jonas Gorski <jogo@openwrt.org>
> ---
>  drivers/pinctrl/Makefile | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile index
> cad077c..2eb25a8 100644
> --- a/drivers/pinctrl/Makefile
> +++ b/drivers/pinctrl/Makefile
> @@ -39,17 +39,17 @@ obj-$(CONFIG_PINCTRL_TB10X)	+= pinctrl-tb10x.o
>  obj-$(CONFIG_PINCTRL_ST) 	+= pinctrl-st.o
>  obj-$(CONFIG_PINCTRL_ZYNQ)	+= pinctrl-zynq.o
> 
> -obj-$(CONFIG_ARCH_BCM)		+= bcm/
> -obj-$(CONFIG_ARCH_BERLIN)	+= berlin/
> +obj-y				+= bcm/
> +obj-y				+= berlin/
>  obj-y				+= freescale/
> -obj-$(CONFIG_X86)		+= intel/
> -obj-$(CONFIG_PLAT_ORION)        += mvebu/
> +obj-y				+= intel/
> +obj-y				+= mvebu/
>  obj-y				+= nomadik/
> -obj-$(CONFIG_ARCH_QCOM)		+= qcom/
> -obj-$(CONFIG_PINCTRL_SAMSUNG)	+= samsung/
> -obj-$(CONFIG_PINCTRL_SH_PFC)	+= sh-pfc/
> -obj-$(CONFIG_PLAT_SPEAR)	+= spear/
> -obj-$(CONFIG_ARCH_SUNXI)	+= sunxi/
> -obj-$(CONFIG_ARCH_UNIPHIER)	+= uniphier/
> -obj-$(CONFIG_ARCH_VT8500)	+= vt8500/
> -obj-$(CONFIG_ARCH_MEDIATEK)	+= mediatek/
> +obj-y				+= qcom/
> +obj-y				+= samsung/
> +obj-y				+= sh-pfc/
> +obj-y				+= spear/
> +obj-y				+= sunxi/
> +obj-y				+= uniphier/
> +obj-y				+= vt8500/
> +obj-y				+= mediatek/


Currently, I only see COMPILE_TEST under  bcm/, mediatek/, and qcom/.
For the others, Kbuild would descend into unneeded subdirectories
just for creating empty built-in.o objects.

Moreover, samsung/ and sh-pfc/ are already enabled by CONFIG_PINCTRL_*.
No need to change these two at least.

Best Regards
Masahiro Yamada