From: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alexv-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
tzahio-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH for-next 2/7] IB: Introduce Work Queue object and its verbs
Date: Thu, 15 Oct 2015 11:50:24 +0300 [thread overview]
Message-ID: <561F68D0.4050205@dev.mellanox.co.il> (raw)
In-Reply-To: <1444893410-13242-3-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Hi Yishai,
> +/**
> + * ib_create_wq - Creates a WQ associated with the specified protection
> + * domain.
> + * @pd: The protection domain associated with the WQ.
> + * @wq_init_attr: A list of initial attributes required to create the
> + * WQ. If WQ creation succeeds, then the attributes are updated to
> + * the actual capabilities of the created WQ.
> + *
> + * wq_init_attr->max_wr and wq_init_attr->max_sge determine
> + * the requested size of the WQ, and set to the actual values allocated
> + * on return.
> + * If ib_create_wq() succeeds, then max_wr and max_sge will always be
> + * at least as large as the requested values.
> + *
> + * Return Value
> + * ib_create_wq() returns a pointer to the created WQ, or NULL if the request
> + * fails.
> + */
> +struct ib_wq *ib_create_wq(struct ib_pd *pd,
> + struct ib_wq_init_attr *init_attr);
> +
We started shifting function documentations from the header declarations
to the *.c implmentations. Would you mind moving it too?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-15 8:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 7:16 [PATCH for-next 0/7] Verbs RSS Yishai Hadas
[not found] ` <1444893410-13242-1-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-10-15 7:16 ` [PATCH for-next 1/7] net/mlx5_core: Expose transobj APIs from mlx5 core Yishai Hadas
2015-10-15 7:16 ` [PATCH for-next 2/7] IB: Introduce Work Queue object and its verbs Yishai Hadas
[not found] ` <1444893410-13242-3-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-10-15 8:50 ` Sagi Grimberg [this message]
[not found] ` <561F68D0.4050205-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-10-18 15:13 ` Yishai Hadas
2015-10-15 9:13 ` Parav Pandit
[not found] ` <CAG53R5V7u7o+cVQnqhfjXdUjKJRVBiMx5CF3snWAWKG6ZbWMow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-15 14:12 ` Yishai Hadas
[not found] ` <561FB463.8030602-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-10-15 15:17 ` Parav Pandit
[not found] ` <CAG53R5U256Nt=3xd3sVUuf8J1icdK5YEiQFoQjR_HB_=5-cVww-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-15 16:25 ` Yishai Hadas
[not found] ` <561FD375.3000205-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-10-15 16:49 ` Parav Pandit
[not found] ` <CAG53R5UmEhOh3n-+9qMoDthAtROdWQXstwqAFxzx8Urx1ZETnw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-18 15:08 ` Yishai Hadas
[not found] ` <5623B5D3.2020206-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-10-18 15:15 ` Parav Pandit
[not found] ` <CAG53R5VFK20e-=1VANya3XQCWts0wyhttsdp+SVJ=MR_27smnQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-18 15:38 ` Devesh Sharma
2015-10-15 7:16 ` [PATCH for-next 3/7] IB/uverbs: Add WQ support Yishai Hadas
2015-10-15 7:16 ` [PATCH for-next 4/7] IB/mlx5: Add receive Work Queue verbs Yishai Hadas
2015-10-15 7:16 ` [PATCH for-next 5/7] IB: Introduce Receive Work Queue indirection table Yishai Hadas
2015-10-15 7:16 ` [PATCH for-next 6/7] IB/uverbs: Introduce RWQ Indirection table Yishai Hadas
2015-10-15 7:16 ` [PATCH for-next 7/7] IB/mlx5: Add Receive Work Queue Indirection table operations Yishai Hadas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561F68D0.4050205@dev.mellanox.co.il \
--to=sagig-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=alexv-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tzahio-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.