All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Hui Zhu <zhuhui@xiaomi.com>, Minchan Kim <minchan@kernel.org>,
	Nitin Gupta <ngupta@vflare.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Mel Gorman <mgorman@suse.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.com>,
	Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Alexander Duyck <alexander.h.duyck@redhat.com>,
	Tejun Heo <tj@kernel.org>, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Jennifer Herbert <jennifer.herbert@citrix.com>,
	Hugh Dickins <hughd@google.com>,
	Vladimir Davydov <vdavydov@parallels.com>,
	David Rientjes <rientjes@google.com>,
	Sasha Levin <sasha.levin@oracle.com>,
	"Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Wanpeng Li <wanpeng.li@hotmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Greg Thelen <gthelen@google.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: teawater@gmail.com
Subject: Re: [RFC v2 1/3] migrate: new struct migration and add it to struct page
Date: Thu, 15 Oct 2015 11:27:15 +0200	[thread overview]
Message-ID: <561F7173.3000900@suse.cz> (raw)
In-Reply-To: <1444900142-1996-2-git-send-email-zhuhui@xiaomi.com>

On 10/15/2015 11:09 AM, Hui Zhu wrote:
> I got that add function interfaces is really not a good idea.
> So I add a new struct migration to put all migration interfaces and add
> this struct to struct page as union of "mapping".

That's better, but not as flexible as the previously proposed approaches 
that Sergey pointed you at:

  http://lkml.iu.edu/hypermail/linux/kernel/1507.0/03233.html
  http://lkml.iu.edu/hypermail/linux/kernel/1508.1/00696.html

There the operations are reachable via mapping, so we can support the 
special operations migration also when mapping is otherwise needed; your 
patch excludes mapping.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Hui Zhu <zhuhui@xiaomi.com>, Minchan Kim <minchan@kernel.org>,
	Nitin Gupta <ngupta@vflare.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Mel Gorman <mgorman@suse.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.com>,
	Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Alexander Duyck <alexander.h.duyck@redhat.com>,
	Tejun Heo <tj@kernel.org>, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Jennifer Herbert <jennifer.herbert@citrix.com>,
	Hugh Dickins <hughd@google.com>,
	Vladimir Davydov <vdavydov@parallels.com>,
	David Rientjes <rientjes@google.com>,
	Sasha Levin <sasha.levin@oracle.com>,
	"Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Wanpeng Li <wanpeng.li@hotmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Greg Thelen <gthelen@google.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: teawater@gmail.com
Subject: Re: [RFC v2 1/3] migrate: new struct migration and add it to struct page
Date: Thu, 15 Oct 2015 11:27:15 +0200	[thread overview]
Message-ID: <561F7173.3000900@suse.cz> (raw)
In-Reply-To: <1444900142-1996-2-git-send-email-zhuhui@xiaomi.com>

On 10/15/2015 11:09 AM, Hui Zhu wrote:
> I got that add function interfaces is really not a good idea.
> So I add a new struct migration to put all migration interfaces and add
> this struct to struct page as union of "mapping".

That's better, but not as flexible as the previously proposed approaches 
that Sergey pointed you at:

  http://lkml.iu.edu/hypermail/linux/kernel/1507.0/03233.html
  http://lkml.iu.edu/hypermail/linux/kernel/1508.1/00696.html

There the operations are reachable via mapping, so we can support the 
special operations migration also when mapping is otherwise needed; your 
patch excludes mapping.


  reply	other threads:[~2015-10-15  9:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15  9:08 [RFC v2 0/3] zsmalloc: make its pages can be migrated Hui Zhu
2015-10-15  9:09 ` [RFC v2 1/3] migrate: new struct migration and add it to struct page Hui Zhu
2015-10-15  9:27   ` Vlastimil Babka [this message]
2015-10-15  9:27     ` Vlastimil Babka
2015-10-15  9:53     ` Minchan Kim
2015-10-15  9:53       ` Minchan Kim
2015-10-19 12:08       ` Hui Zhu
2015-10-19 12:08         ` Hui Zhu
2015-10-15  9:09 ` [RFC v2 2/3] zsmalloc: mark its page "PageMigration" Hui Zhu
2015-10-15  9:09 ` [RFC v2 3/3] zram: make create "__GFP_MOVABLE" pool Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561F7173.3000900@suse.cz \
    --to=vbabka@suse.cz \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.h.duyck@redhat.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=geert+renesas@glider.be \
    --cc=gthelen@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jennifer.herbert@citrix.com \
    --cc=khlebnikov@yandex-team.ru \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=ngupta@vflare.org \
    --cc=rientjes@google.com \
    --cc=rostedt@goodmis.org \
    --cc=sasha.levin@oracle.com \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=teawater@gmail.com \
    --cc=tj@kernel.org \
    --cc=vdavydov@parallels.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wanpeng.li@hotmail.com \
    --cc=zhuhui@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.