All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
	kvm-ppc@vger.kernel.org, agraf@suse.de
Cc: kvm@vger.kernel.org, paulus@samba.org
Subject: Re: [PATCH] KVM: PPC: Implement extension to report number of memslots
Date: Fri, 16 Oct 2015 06:41:31 +0000	[thread overview]
Message-ID: <56209C1B.2060903@redhat.com> (raw)
In-Reply-To: <1444971473-26514-1-git-send-email-nikunj@linux.vnet.ibm.com>

On 16/10/15 06:57, Nikunj A Dadhania wrote:
> QEMU assumes 32 memslots if this extension is not implemented. Although,
> current value of KVM_USER_MEM_SLOTS is 32, once KVM_USER_MEM_SLOTS
> changes QEMU would take a wrong value.
> 
> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
> ---
>  arch/powerpc/kvm/powerpc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
> index 2e51289..6fd2405 100644
> --- a/arch/powerpc/kvm/powerpc.c
> +++ b/arch/powerpc/kvm/powerpc.c
> @@ -559,6 +559,9 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
>  		else
>  			r = num_online_cpus();
>  		break;
> +	case KVM_CAP_NR_MEMSLOTS:
> +		r = KVM_USER_MEM_SLOTS;
> +		break;
>  	case KVM_CAP_MAX_VCPUS:
>  		r = KVM_MAX_VCPUS;
>  		break;

Yes, we'll likely need this soon! 32 slots are not enough...

Reviewed-by: Thomas Huth <thuth@redhat.com>


WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
	kvm-ppc@vger.kernel.org, agraf@suse.de
Cc: kvm@vger.kernel.org, paulus@samba.org
Subject: Re: [PATCH] KVM: PPC: Implement extension to report number of memslots
Date: Fri, 16 Oct 2015 08:41:31 +0200	[thread overview]
Message-ID: <56209C1B.2060903@redhat.com> (raw)
In-Reply-To: <1444971473-26514-1-git-send-email-nikunj@linux.vnet.ibm.com>

On 16/10/15 06:57, Nikunj A Dadhania wrote:
> QEMU assumes 32 memslots if this extension is not implemented. Although,
> current value of KVM_USER_MEM_SLOTS is 32, once KVM_USER_MEM_SLOTS
> changes QEMU would take a wrong value.
> 
> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
> ---
>  arch/powerpc/kvm/powerpc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
> index 2e51289..6fd2405 100644
> --- a/arch/powerpc/kvm/powerpc.c
> +++ b/arch/powerpc/kvm/powerpc.c
> @@ -559,6 +559,9 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
>  		else
>  			r = num_online_cpus();
>  		break;
> +	case KVM_CAP_NR_MEMSLOTS:
> +		r = KVM_USER_MEM_SLOTS;
> +		break;
>  	case KVM_CAP_MAX_VCPUS:
>  		r = KVM_MAX_VCPUS;
>  		break;

Yes, we'll likely need this soon! 32 slots are not enough...

Reviewed-by: Thomas Huth <thuth@redhat.com>


  reply	other threads:[~2015-10-16  6:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16  4:57 [PATCH] KVM: PPC: Implement extension to report number of memslots Nikunj A Dadhania
2015-10-16  4:59 ` Nikunj A Dadhania
2015-10-16  6:41 ` Thomas Huth [this message]
2015-10-16  6:41   ` Thomas Huth
2015-10-26  5:15   ` Paul Mackerras
2015-10-26  5:15     ` Paul Mackerras
2015-10-26 23:47     ` Scott Wood
2015-10-26 23:47       ` Scott Wood
2015-10-27 13:22     ` Thomas Huth
2015-10-27 13:22       ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56209C1B.2060903@redhat.com \
    --to=thuth@redhat.com \
    --cc=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=nikunj@linux.vnet.ibm.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.