From: Paolo Bonzini <pbonzini@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: rkagan@virtuozzo.com, virtualization@lists.linux-foundation.org,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Andrey Smetanin <asmetanin@virtuozzo.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Gleb Natapov <gleb@kernel.org>
Subject: Re: [PATCH 9/9] kvm/x86: Hyper-V kvm exit
Date: Fri, 16 Oct 2015 09:51:58 +0200 [thread overview]
Message-ID: <5620AC9E.4050905@redhat.com> (raw)
In-Reply-To: <1444979273-6587-10-git-send-email-den@openvz.org>
On 16/10/2015 09:07, Denis V. Lunev wrote:
>
> + /* KVM_EXIT_HYPERV */
> + struct kvm_hyperv_exit hyperv;
> +Indicates that the VCPU exits into userspace to process some tasks
> +related with Hyper-V emulation. Currently used to synchronize modified
> +Hyper-V SynIC state with userspace.
> +
The documentation should include the definition of the struct and the
definition of the subtypes (currently KVM_EXIT_HYPERV_SYNIC only).
Documentation for KVM_CAP_HYPERV_SINIC and KVM_IRQ_ROUTING_HV_SINT is
missing, too.
Finally, it would be better to have unit tests in kvm-unit-tests.
Either this or QEMU support is a requirement for merging, and the unit
tests are probably easier.
But apart from this, the series looks great and I'm already applying it
to kvm/queue so that it gets some more testing.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: kvm@vger.kernel.org, Gleb Natapov <gleb@kernel.org>,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
rkagan@virtuozzo.com, Andrey Smetanin <asmetanin@virtuozzo.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
"K. Y. Srinivasan" <kys@microsoft.com>
Subject: Re: [Qemu-devel] [PATCH 9/9] kvm/x86: Hyper-V kvm exit
Date: Fri, 16 Oct 2015 09:51:58 +0200 [thread overview]
Message-ID: <5620AC9E.4050905@redhat.com> (raw)
In-Reply-To: <1444979273-6587-10-git-send-email-den@openvz.org>
On 16/10/2015 09:07, Denis V. Lunev wrote:
>
> + /* KVM_EXIT_HYPERV */
> + struct kvm_hyperv_exit hyperv;
> +Indicates that the VCPU exits into userspace to process some tasks
> +related with Hyper-V emulation. Currently used to synchronize modified
> +Hyper-V SynIC state with userspace.
> +
The documentation should include the definition of the struct and the
definition of the subtypes (currently KVM_EXIT_HYPERV_SYNIC only).
Documentation for KVM_CAP_HYPERV_SINIC and KVM_IRQ_ROUTING_HV_SINT is
missing, too.
Finally, it would be better to have unit tests in kvm-unit-tests.
Either this or QEMU support is a requirement for merging, and the unit
tests are probably easier.
But apart from this, the series looks great and I'm already applying it
to kvm/queue so that it gets some more testing.
Paolo
next prev parent reply other threads:[~2015-10-16 7:52 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 7:07 [PATCH v2 0/9] Hyper-V synthetic interrupt controller Denis V. Lunev
2015-10-16 7:07 ` [Qemu-devel] " Denis V. Lunev
2015-10-16 7:07 ` [PATCH 1/9] kvm/eventfd: avoid loop inside irqfd_update() Denis V. Lunev
2015-10-16 7:07 ` [Qemu-devel] " Denis V. Lunev
2015-10-16 7:07 ` [PATCH 2/9] kvm/eventfd: factor out kvm_notify_acked_gsi() Denis V. Lunev
2015-10-16 7:07 ` Denis V. Lunev
2015-10-16 7:07 ` [Qemu-devel] " Denis V. Lunev
2015-10-16 7:07 ` [PATCH 3/9] kvm/eventfd: add arch-specific set_irq Denis V. Lunev
2015-10-16 7:07 ` [Qemu-devel] " Denis V. Lunev
2015-10-16 7:07 ` Denis V. Lunev
2015-10-16 7:07 ` [PATCH 4/9] kvm/irqchip: allow only multiple irqchip routes per GSI Denis V. Lunev
2015-10-16 7:07 ` [Qemu-devel] " Denis V. Lunev
2015-10-16 7:07 ` Denis V. Lunev
2015-10-16 7:07 ` [PATCH 5/9] kvm/irqchip: kvm_arch_irq_routing_update renaming split Denis V. Lunev
2015-10-16 7:07 ` Denis V. Lunev
2015-10-16 7:07 ` [Qemu-devel] " Denis V. Lunev
2015-10-16 7:07 ` [PATCH 6/9] drivers/hv: share Hyper-V SynIC constants with userspace Denis V. Lunev
2015-10-16 7:07 ` Denis V. Lunev
2015-10-16 7:07 ` [Qemu-devel] " Denis V. Lunev
2015-10-16 7:07 ` [PATCH 7/9] kvm/x86: split ioapic-handled and EOI exit bitmaps Denis V. Lunev
2015-10-16 7:07 ` Denis V. Lunev
2015-10-16 7:07 ` [Qemu-devel] " Denis V. Lunev
2015-10-16 7:07 ` [PATCH 8/9] kvm/x86: Hyper-V synthetic interrupt controller Denis V. Lunev
2015-10-16 7:07 ` [Qemu-devel] " Denis V. Lunev
2015-10-22 16:09 ` [PATCH v3 " Andrey Smetanin
2015-10-22 16:09 ` [Qemu-devel] " Andrey Smetanin
2015-10-28 17:41 ` Paolo Bonzini
2015-10-28 17:41 ` [Qemu-devel] " Paolo Bonzini
2015-10-29 8:45 ` Roman Kagan
2015-10-29 8:45 ` [Qemu-devel] " Roman Kagan
2015-10-29 9:51 ` Paolo Bonzini
2015-10-29 9:51 ` [Qemu-devel] " Paolo Bonzini
2015-10-29 8:50 ` Andrey Smetanin
2015-10-29 8:50 ` [Qemu-devel] " Andrey Smetanin
2015-10-16 7:07 ` [PATCH " Denis V. Lunev
2015-10-16 7:07 ` [PATCH 9/9] kvm/x86: Hyper-V kvm exit Denis V. Lunev
2015-10-16 7:07 ` [Qemu-devel] " Denis V. Lunev
2015-10-16 7:51 ` Paolo Bonzini [this message]
2015-10-16 7:51 ` Paolo Bonzini
2015-10-16 10:51 ` Roman Kagan
2015-10-16 10:51 ` [Qemu-devel] " Roman Kagan
2015-10-16 10:51 ` Roman Kagan
2015-10-16 7:51 ` Paolo Bonzini
2015-10-22 16:10 ` [PATCH v3 " Andrey Smetanin
2015-10-22 16:10 ` [Qemu-devel] " Andrey Smetanin
2015-10-22 16:34 ` Paolo Bonzini
2015-10-22 16:34 ` [Qemu-devel] " Paolo Bonzini
2015-10-26 10:13 ` Denis V. Lunev
2015-10-26 10:13 ` [Qemu-devel] " Denis V. Lunev
2015-11-03 13:28 ` Paolo Bonzini
2015-11-03 13:28 ` [Qemu-devel] " Paolo Bonzini
2015-11-03 13:30 ` Andrey Smetanin
2015-11-03 13:30 ` [Qemu-devel] " Andrey Smetanin
2015-11-03 14:36 ` Andrey Smetanin
2015-11-03 14:36 ` [Qemu-devel] " Andrey Smetanin
2015-11-03 14:51 ` Paolo Bonzini
2015-11-03 14:51 ` [Qemu-devel] " Paolo Bonzini
2015-11-03 15:42 ` Andrey Smetanin
2015-11-03 15:42 ` [Qemu-devel] " Andrey Smetanin
2015-11-03 15:52 ` Roman Kagan
2015-11-03 15:52 ` Roman Kagan
2015-10-16 7:07 ` [PATCH " Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5620AC9E.4050905@redhat.com \
--to=pbonzini@redhat.com \
--cc=asmetanin@virtuozzo.com \
--cc=den@openvz.org \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.