From: "Franklin S Cooper Jr." <fcooper-l0cyMroinI0@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<nsekhar-l0cyMroinI0@public.gmane.org>,
<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
<iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>,
<m-karicheri2-l0cyMroinI0@public.gmane.org>,
<iivanov.xz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
<jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
<hkallweit1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] spi: Setup the master controller driver before setting the chipselect
Date: Fri, 16 Oct 2015 09:45:48 -0500 [thread overview]
Message-ID: <56210D9C.6090800@ti.com> (raw)
In-Reply-To: <20151016144305.GO14956-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 10/16/2015 09:43 AM, Mark Brown wrote:
> On Fri, Oct 16, 2015 at 09:27:50AM -0500, Franklin S Cooper Jr. wrote:
>
>> Makes sense. How about something like this?
>> SPI controllers may need to be properly setup before chip selects
>> can be used. Therefore, wait until the spi controller has a chance
>> to perform their setup procedure before trying to use the chip
>> select.
> Yes, that's a lot better - there's also the fact that if we assert chip
> select before we've got the pins in a good state we may cause the device
> to see signals that confuse it as we change.
Ok. I'll submit a rev2 with my updated commit message and incorporate
your suggestion also.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Franklin S Cooper Jr." <fcooper@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<nsekhar@ti.com>, <ssantosh@kernel.org>, <iivanov@mm-sol.com>,
<m-karicheri2@ti.com>, <iivanov.xz@gmail.com>,
<andy.shevchenko@gmail.com>, <jarkko.nikula@linux.intel.com>,
<hkallweit1@gmail.com>
Subject: Re: [PATCH] spi: Setup the master controller driver before setting the chipselect
Date: Fri, 16 Oct 2015 09:45:48 -0500 [thread overview]
Message-ID: <56210D9C.6090800@ti.com> (raw)
In-Reply-To: <20151016144305.GO14956@sirena.org.uk>
On 10/16/2015 09:43 AM, Mark Brown wrote:
> On Fri, Oct 16, 2015 at 09:27:50AM -0500, Franklin S Cooper Jr. wrote:
>
>> Makes sense. How about something like this?
>> SPI controllers may need to be properly setup before chip selects
>> can be used. Therefore, wait until the spi controller has a chance
>> to perform their setup procedure before trying to use the chip
>> select.
> Yes, that's a lot better - there's also the fact that if we assert chip
> select before we've got the pins in a good state we may cause the device
> to see signals that confuse it as we change.
Ok. I'll submit a rev2 with my updated commit message and incorporate
your suggestion also.
next prev parent reply other threads:[~2015-10-16 14:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 20:51 [PATCH] spi: Setup the master controller driver before setting the chipselect Franklin S Cooper Jr
2015-10-15 20:51 ` Franklin S Cooper Jr
[not found] ` <1444942305-24038-1-git-send-email-fcooper-l0cyMroinI0@public.gmane.org>
2015-10-16 10:28 ` Mark Brown
2015-10-16 10:28 ` Mark Brown
[not found] ` <20151016102846.GJ14956-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-10-16 14:27 ` Franklin S Cooper Jr.
2015-10-16 14:27 ` Franklin S Cooper Jr.
[not found] ` <56210966.3040501-l0cyMroinI0@public.gmane.org>
2015-10-16 14:43 ` Mark Brown
2015-10-16 14:43 ` Mark Brown
[not found] ` <20151016144305.GO14956-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-10-16 14:45 ` Franklin S Cooper Jr. [this message]
2015-10-16 14:45 ` Franklin S Cooper Jr.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56210D9C.6090800@ti.com \
--to=fcooper-l0cymroini0@public.gmane.org \
--cc=andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=hkallweit1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org \
--cc=iivanov.xz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m-karicheri2-l0cyMroinI0@public.gmane.org \
--cc=nsekhar-l0cyMroinI0@public.gmane.org \
--cc=ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.