All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
	linux-kernel@vger.kernel.org
Cc: Kukjin Kim <kgene@kernel.org>,
	Douglas Anderson <dianders@chromium.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 1/6] ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi
Date: Mon, 19 Oct 2015 09:10:23 +0900	[thread overview]
Message-ID: <562434EF.4010604@samsung.com> (raw)
In-Reply-To: <1444927873-15140-2-git-send-email-javier@osg.samsung.com>

On 16.10.2015 01:51, Javier Martinez Canillas wrote:
> The Exynos5800 Peach Pi Chromebook has a Marvell WiFi SDIO chip which
> can't neither be removed nor be detected. But the node isn't marked
> as non-removable and instead has the broken-cd DT property.
> 
> This causes the device to be removed when the system enters into a
> suspend state and the following warnings is shown after a resume:
> 
> [  181.944636] mmc2: error -2 during resume (card was removed?)
> 
> Also remove the card-detect-delay property that is not needed with
> non-removable.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
> Changes since v1:
> - Remove card-detect-delay property as well.
> 
>  arch/arm/boot/dts/exynos5800-peach-pi.dts | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

That sounds reasonable:

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/6] ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi
Date: Mon, 19 Oct 2015 09:10:23 +0900	[thread overview]
Message-ID: <562434EF.4010604@samsung.com> (raw)
In-Reply-To: <1444927873-15140-2-git-send-email-javier@osg.samsung.com>

On 16.10.2015 01:51, Javier Martinez Canillas wrote:
> The Exynos5800 Peach Pi Chromebook has a Marvell WiFi SDIO chip which
> can't neither be removed nor be detected. But the node isn't marked
> as non-removable and instead has the broken-cd DT property.
> 
> This causes the device to be removed when the system enters into a
> suspend state and the following warnings is shown after a resume:
> 
> [  181.944636] mmc2: error -2 during resume (card was removed?)
> 
> Also remove the card-detect-delay property that is not needed with
> non-removable.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
> Changes since v1:
> - Remove card-detect-delay property as well.
> 
>  arch/arm/boot/dts/exynos5800-peach-pi.dts | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

That sounds reasonable:

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

  reply	other threads:[~2015-10-19  0:10 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 16:51 [PATCH v2 0/6] ARM: dts: Use correct CD properties for SDIO and eMMC in Snow and Peach Javier Martinez Canillas
2015-10-15 16:51 ` Javier Martinez Canillas
2015-10-15 16:51 ` Javier Martinez Canillas
2015-10-15 16:51 ` [PATCH v2 1/6] ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi Javier Martinez Canillas
2015-10-15 16:51   ` Javier Martinez Canillas
2015-10-19  0:10   ` Krzysztof Kozlowski [this message]
2015-10-19  0:10     ` Krzysztof Kozlowski
2015-10-15 16:51 ` [PATCH v2 2/6] ARM: dts: Mark SDIO as non-removable in exynos5420-peach-pit Javier Martinez Canillas
2015-10-15 16:51   ` Javier Martinez Canillas
2015-10-19  0:10   ` Krzysztof Kozlowski
2015-10-19  0:10     ` Krzysztof Kozlowski
2015-10-15 16:51 ` [RFT PATCH v2 3/6] ARM: dts: Mark SDIO as non-removable in exynos5250-snow-common Javier Martinez Canillas
2015-10-15 16:51   ` Javier Martinez Canillas
2015-10-16 12:33   ` Tomeu Vizoso
2015-10-16 12:33     ` Tomeu Vizoso
2015-10-19  0:10   ` Krzysztof Kozlowski
2015-10-19  0:10     ` Krzysztof Kozlowski
2015-10-15 16:51 ` [PATCH v2 4/6] ARM: dts: Remove broken-cd from eMMC node in exynos5800-peach-pi Javier Martinez Canillas
2015-10-15 16:51   ` Javier Martinez Canillas
2015-10-19  0:11   ` Krzysztof Kozlowski
2015-10-19  0:11     ` Krzysztof Kozlowski
2015-10-15 16:51 ` [PATCH v2 5/6] ARM: dts: Remove broken-cd from eMMC node in exynos5420-peach-pi Javier Martinez Canillas
2015-10-15 16:51   ` Javier Martinez Canillas
2015-10-19  0:11   ` Krzysztof Kozlowski
2015-10-19  0:11     ` Krzysztof Kozlowski
2015-10-15 16:51 ` [RFT PATCH v2 6/6] ARM: dts: Mark eMMC as non-removable in exynos5250-snow-common Javier Martinez Canillas
2015-10-15 16:51   ` Javier Martinez Canillas
2015-10-16 12:33   ` Tomeu Vizoso
2015-10-16 12:33     ` Tomeu Vizoso
2015-10-19  0:12   ` Krzysztof Kozlowski
2015-10-19  0:12     ` Krzysztof Kozlowski
2015-10-16 11:37 ` [PATCH v2 0/6] ARM: dts: Use correct CD properties for SDIO and eMMC in Snow and Peach Alim Akhtar
2015-10-16 11:37   ` Alim Akhtar
2015-10-16 13:48   ` Javier Martinez Canillas
2015-10-16 13:48     ` Javier Martinez Canillas
2015-10-16 23:46     ` Kukjin Kim
2015-10-16 23:46       ` Kukjin Kim
2015-10-19  3:04 ` Alim Akhtar
2015-10-19  3:04   ` Alim Akhtar
2015-11-08 14:48   ` Javier Martinez Canillas
2015-11-08 14:48     ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562434EF.4010604@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=dianders@chromium.org \
    --cc=javier@osg.samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.