From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Daniel Thompson <daniel.thompson@linaro.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Matt Mackall <mpm@selenic.com>
Cc: linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@linaro.org, linaro-kernel@lists.linaro.org,
Kukjin Kim <kgene@kernel.org>
Subject: Re: [PATCH] hwrng: exynos - Fix unbalanced PM runtime get/puts
Date: Mon, 19 Oct 2015 10:41:12 +0900 [thread overview]
Message-ID: <56244A38.4040207@samsung.com> (raw)
In-Reply-To: <1445011311-32142-1-git-send-email-daniel.thompson@linaro.org>
On 17.10.2015 01:01, Daniel Thompson wrote:
> Currently this driver calls pm_runtime_get_sync() rampantly
> but never puts anything back. This makes it impossible for the
> device to autosuspend properly; it will remain fully active
> after the first use.
>
> Fix in the obvious way.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>
> Notes:
> Compile tested only (CONFIG_PM=y, CONFIG_HW_RANDOM_EXYNOS=m); I spotted
> this whilst reviewing the code and don't have an exynos platform to
> test on.
>
> drivers/char/hw_random/exynos-rng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
To test the patch I had to add OF support to the driver. I have these
patches almost ready and I will send them soon. Anyway:
Tested on Trats2 board (Exynos4412):
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] hwrng: exynos - Fix unbalanced PM runtime get/puts
Date: Mon, 19 Oct 2015 10:41:12 +0900 [thread overview]
Message-ID: <56244A38.4040207@samsung.com> (raw)
In-Reply-To: <1445011311-32142-1-git-send-email-daniel.thompson@linaro.org>
On 17.10.2015 01:01, Daniel Thompson wrote:
> Currently this driver calls pm_runtime_get_sync() rampantly
> but never puts anything back. This makes it impossible for the
> device to autosuspend properly; it will remain fully active
> after the first use.
>
> Fix in the obvious way.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>
> Notes:
> Compile tested only (CONFIG_PM=y, CONFIG_HW_RANDOM_EXYNOS=m); I spotted
> this whilst reviewing the code and don't have an exynos platform to
> test on.
>
> drivers/char/hw_random/exynos-rng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
To test the patch I had to add OF support to the driver. I have these
patches almost ready and I will send them soon. Anyway:
Tested on Trats2 board (Exynos4412):
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-10-19 1:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 16:01 [PATCH] hwrng: exynos - Fix unbalanced PM runtime get/puts Daniel Thompson
2015-10-16 16:01 ` Daniel Thompson
2015-10-19 1:41 ` Krzysztof Kozlowski [this message]
2015-10-19 1:41 ` Krzysztof Kozlowski
2015-10-20 14:19 ` Herbert Xu
2015-10-20 14:19 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56244A38.4040207@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=herbert@gondor.apana.org.au \
--cc=kgene@kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.