* [PATCH v2] Net: ceph: messenger: Use local variable cursor in read_partial_msg_data()
@ 2015-10-19 2:49 Shraddha Barke
2015-10-19 9:43 ` Ilya Dryomov
2015-10-19 12:22 ` Alex Elder
0 siblings, 2 replies; 3+ messages in thread
From: Shraddha Barke @ 2015-10-19 2:49 UTC (permalink / raw)
To: ceph-devel, Alex Elder
Use local variable cursor in place of &msg->cursor in
read_partial_msg_data()
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
Changes in v2-
Drop incorrect use of cursor
net/ceph/messenger.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
index b9b0e3b..b087edd 100644
--- a/net/ceph/messenger.c
+++ b/net/ceph/messenger.c
@@ -2246,7 +2246,7 @@ static int read_partial_msg_data(struct ceph_connection *con)
if (do_datacrc)
crc = con->in_data_crc;
while (cursor->resid) {
- page = ceph_msg_data_next(&msg->cursor, &page_offset, &length,
+ page = ceph_msg_data_next(cursor, &page_offset, &length,
NULL);
ret = ceph_tcp_recvpage(con->sock, page, page_offset, length);
if (ret <= 0) {
@@ -2258,7 +2258,7 @@ static int read_partial_msg_data(struct ceph_connection *con)
if (do_datacrc)
crc = ceph_crc32c_page(crc, page, page_offset, ret);
- (void) ceph_msg_data_advance(&msg->cursor, (size_t)ret);
+ (void) ceph_msg_data_advance(cursor, (size_t)ret);
}
if (do_datacrc)
con->in_data_crc = crc;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] Net: ceph: messenger: Use local variable cursor in read_partial_msg_data()
2015-10-19 2:49 [PATCH v2] Net: ceph: messenger: Use local variable cursor in read_partial_msg_data() Shraddha Barke
@ 2015-10-19 9:43 ` Ilya Dryomov
2015-10-19 12:22 ` Alex Elder
1 sibling, 0 replies; 3+ messages in thread
From: Ilya Dryomov @ 2015-10-19 9:43 UTC (permalink / raw)
To: Shraddha Barke; +Cc: Ceph Development, Alex Elder
On Mon, Oct 19, 2015 at 4:49 AM, Shraddha Barke <shraddha.6596@gmail.com> wrote:
> Use local variable cursor in place of &msg->cursor in
> read_partial_msg_data()
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
> Changes in v2-
> Drop incorrect use of cursor
>
> net/ceph/messenger.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
> index b9b0e3b..b087edd 100644
> --- a/net/ceph/messenger.c
> +++ b/net/ceph/messenger.c
> @@ -2246,7 +2246,7 @@ static int read_partial_msg_data(struct ceph_connection *con)
> if (do_datacrc)
> crc = con->in_data_crc;
> while (cursor->resid) {
> - page = ceph_msg_data_next(&msg->cursor, &page_offset, &length,
> + page = ceph_msg_data_next(cursor, &page_offset, &length,
> NULL);
> ret = ceph_tcp_recvpage(con->sock, page, page_offset, length);
> if (ret <= 0) {
> @@ -2258,7 +2258,7 @@ static int read_partial_msg_data(struct ceph_connection *con)
>
> if (do_datacrc)
> crc = ceph_crc32c_page(crc, page, page_offset, ret);
> - (void) ceph_msg_data_advance(&msg->cursor, (size_t)ret);
> + (void) ceph_msg_data_advance(cursor, (size_t)ret);
> }
> if (do_datacrc)
> con->in_data_crc = crc;
This looks good. I'd like you to update this patch to do the same for
write_partial_message_data().
Thanks,
Ilya
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] Net: ceph: messenger: Use local variable cursor in read_partial_msg_data()
2015-10-19 2:49 [PATCH v2] Net: ceph: messenger: Use local variable cursor in read_partial_msg_data() Shraddha Barke
2015-10-19 9:43 ` Ilya Dryomov
@ 2015-10-19 12:22 ` Alex Elder
1 sibling, 0 replies; 3+ messages in thread
From: Alex Elder @ 2015-10-19 12:22 UTC (permalink / raw)
To: Shraddha Barke, ceph-devel
On 10/18/2015 09:49 PM, Shraddha Barke wrote:
> Use local variable cursor in place of &msg->cursor in
> read_partial_msg_data()
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
This is a pretty minor comment, but the "Net" in your
subject line is probably better *not* capitalized.
-Alex
> ---
> Changes in v2-
> Drop incorrect use of cursor
>
> net/ceph/messenger.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
> index b9b0e3b..b087edd 100644
> --- a/net/ceph/messenger.c
> +++ b/net/ceph/messenger.c
> @@ -2246,7 +2246,7 @@ static int read_partial_msg_data(struct ceph_connection *con)
> if (do_datacrc)
> crc = con->in_data_crc;
> while (cursor->resid) {
> - page = ceph_msg_data_next(&msg->cursor, &page_offset, &length,
> + page = ceph_msg_data_next(cursor, &page_offset, &length,
> NULL);
> ret = ceph_tcp_recvpage(con->sock, page, page_offset, length);
> if (ret <= 0) {
> @@ -2258,7 +2258,7 @@ static int read_partial_msg_data(struct ceph_connection *con)
>
> if (do_datacrc)
> crc = ceph_crc32c_page(crc, page, page_offset, ret);
> - (void) ceph_msg_data_advance(&msg->cursor, (size_t)ret);
> + (void) ceph_msg_data_advance(cursor, (size_t)ret);
> }
> if (do_datacrc)
> con->in_data_crc = crc;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-19 12:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-19 2:49 [PATCH v2] Net: ceph: messenger: Use local variable cursor in read_partial_msg_data() Shraddha Barke
2015-10-19 9:43 ` Ilya Dryomov
2015-10-19 12:22 ` Alex Elder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.