* [PATCH 1/2] ASoC: ssm2518: Drop .volatile_reg implementation
@ 2015-10-20 8:54 Axel Lin
2015-10-20 8:56 ` [PATCH 2/2] ASoC: ad193x: " Axel Lin
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Axel Lin @ 2015-10-20 8:54 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, Lars-Peter Clausen, Liam Girdwood
The implementation of ssm2518_register_volatile always returns false,
this behavior is the same as no .volatile_reg callback implementation
when cache_type != REGCACHE_NONE.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/ssm2518.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/sound/soc/codecs/ssm2518.c b/sound/soc/codecs/ssm2518.c
index ddb0203..86b81a60 100644
--- a/sound/soc/codecs/ssm2518.c
+++ b/sound/soc/codecs/ssm2518.c
@@ -723,17 +723,11 @@ static struct snd_soc_codec_driver ssm2518_codec_driver = {
.num_dapm_routes = ARRAY_SIZE(ssm2518_routes),
};
-static bool ssm2518_register_volatile(struct device *dev, unsigned int reg)
-{
- return false;
-}
-
static const struct regmap_config ssm2518_regmap_config = {
.val_bits = 8,
.reg_bits = 8,
.max_register = SSM2518_REG_DRC_9,
- .volatile_reg = ssm2518_register_volatile,
.cache_type = REGCACHE_RBTREE,
.reg_defaults = ssm2518_reg_defaults,
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ASoC: ad193x: Drop .volatile_reg implementation
2015-10-20 8:54 [PATCH 1/2] ASoC: ssm2518: Drop .volatile_reg implementation Axel Lin
@ 2015-10-20 8:56 ` Axel Lin
2015-10-20 9:02 ` Lars-Peter Clausen
2015-10-20 19:32 ` Applied "ASoC: ad193x: Drop .volatile_reg implementation" to the asoc tree Mark Brown
2015-10-20 9:02 ` [PATCH 1/2] ASoC: ssm2518: Drop .volatile_reg implementation Lars-Peter Clausen
2015-10-20 19:32 ` Applied "ASoC: ssm2518: Drop .volatile_reg implementation" to the asoc tree Mark Brown
2 siblings, 2 replies; 6+ messages in thread
From: Axel Lin @ 2015-10-20 8:56 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, Lars-Peter Clausen, Liam Girdwood
adau193x_reg_volatile() always return false.
This seems pointless because current code uses REGCACHE_NONE cache_type
which is supposed to be volatile.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/ad193x.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/sound/soc/codecs/ad193x.c b/sound/soc/codecs/ad193x.c
index 76d7966..3a3f3f2 100644
--- a/sound/soc/codecs/ad193x.c
+++ b/sound/soc/codecs/ad193x.c
@@ -418,14 +418,8 @@ static struct snd_soc_codec_driver soc_codec_dev_ad193x = {
.num_dapm_routes = ARRAY_SIZE(audio_paths),
};
-static bool adau193x_reg_volatile(struct device *dev, unsigned int reg)
-{
- return false;
-}
-
const struct regmap_config ad193x_regmap_config = {
.max_register = AD193X_NUM_REGS - 1,
- .volatile_reg = adau193x_reg_volatile,
};
EXPORT_SYMBOL_GPL(ad193x_regmap_config);
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] ASoC: ad193x: Drop .volatile_reg implementation
2015-10-20 8:56 ` [PATCH 2/2] ASoC: ad193x: " Axel Lin
@ 2015-10-20 9:02 ` Lars-Peter Clausen
2015-10-20 19:32 ` Applied "ASoC: ad193x: Drop .volatile_reg implementation" to the asoc tree Mark Brown
1 sibling, 0 replies; 6+ messages in thread
From: Lars-Peter Clausen @ 2015-10-20 9:02 UTC (permalink / raw)
To: Axel Lin, Mark Brown; +Cc: alsa-devel, Liam Girdwood
On 10/20/2015 10:56 AM, Axel Lin wrote:
> adau193x_reg_volatile() always return false.
> This seems pointless because current code uses REGCACHE_NONE cache_type
> which is supposed to be volatile.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Applied "ASoC: ad193x: Drop .volatile_reg implementation" to the asoc tree
2015-10-20 8:56 ` [PATCH 2/2] ASoC: ad193x: " Axel Lin
2015-10-20 9:02 ` Lars-Peter Clausen
@ 2015-10-20 19:32 ` Mark Brown
1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2015-10-20 19:32 UTC (permalink / raw)
To: Axel Lin, Lars-Peter Clausen, Mark Brown; +Cc: alsa-devel
The patch
ASoC: ad193x: Drop .volatile_reg implementation
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 92b822a499607c32ce12ffd798a095babedc3202 Mon Sep 17 00:00:00 2001
From: Axel Lin <axel.lin@ingics.com>
Date: Tue, 20 Oct 2015 16:56:11 +0800
Subject: [PATCH] ASoC: ad193x: Drop .volatile_reg implementation
adau193x_reg_volatile() always return false.
This seems pointless because current code uses REGCACHE_NONE cache_type
which is supposed to be volatile.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/ad193x.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/sound/soc/codecs/ad193x.c b/sound/soc/codecs/ad193x.c
index 76d7966bd72c..3a3f3f2343d7 100644
--- a/sound/soc/codecs/ad193x.c
+++ b/sound/soc/codecs/ad193x.c
@@ -418,14 +418,8 @@ static struct snd_soc_codec_driver soc_codec_dev_ad193x = {
.num_dapm_routes = ARRAY_SIZE(audio_paths),
};
-static bool adau193x_reg_volatile(struct device *dev, unsigned int reg)
-{
- return false;
-}
-
const struct regmap_config ad193x_regmap_config = {
.max_register = AD193X_NUM_REGS - 1,
- .volatile_reg = adau193x_reg_volatile,
};
EXPORT_SYMBOL_GPL(ad193x_regmap_config);
--
2.6.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ASoC: ssm2518: Drop .volatile_reg implementation
2015-10-20 8:54 [PATCH 1/2] ASoC: ssm2518: Drop .volatile_reg implementation Axel Lin
2015-10-20 8:56 ` [PATCH 2/2] ASoC: ad193x: " Axel Lin
@ 2015-10-20 9:02 ` Lars-Peter Clausen
2015-10-20 19:32 ` Applied "ASoC: ssm2518: Drop .volatile_reg implementation" to the asoc tree Mark Brown
2 siblings, 0 replies; 6+ messages in thread
From: Lars-Peter Clausen @ 2015-10-20 9:02 UTC (permalink / raw)
To: Axel Lin, Mark Brown; +Cc: alsa-devel, Liam Girdwood
On 10/20/2015 10:54 AM, Axel Lin wrote:
> The implementation of ssm2518_register_volatile always returns false,
> this behavior is the same as no .volatile_reg callback implementation
> when cache_type != REGCACHE_NONE.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Applied "ASoC: ssm2518: Drop .volatile_reg implementation" to the asoc tree
2015-10-20 8:54 [PATCH 1/2] ASoC: ssm2518: Drop .volatile_reg implementation Axel Lin
2015-10-20 8:56 ` [PATCH 2/2] ASoC: ad193x: " Axel Lin
2015-10-20 9:02 ` [PATCH 1/2] ASoC: ssm2518: Drop .volatile_reg implementation Lars-Peter Clausen
@ 2015-10-20 19:32 ` Mark Brown
2 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2015-10-20 19:32 UTC (permalink / raw)
To: Axel Lin, Lars-Peter Clausen, Mark Brown; +Cc: alsa-devel
The patch
ASoC: ssm2518: Drop .volatile_reg implementation
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From ce7b8dbdded8552d1fd25cc9289da361c5cc765e Mon Sep 17 00:00:00 2001
From: Axel Lin <axel.lin@ingics.com>
Date: Tue, 20 Oct 2015 16:54:46 +0800
Subject: [PATCH] ASoC: ssm2518: Drop .volatile_reg implementation
The implementation of ssm2518_register_volatile always returns false,
this behavior is the same as no .volatile_reg callback implementation
when cache_type != REGCACHE_NONE.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/ssm2518.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/sound/soc/codecs/ssm2518.c b/sound/soc/codecs/ssm2518.c
index ddb0203fc649..86b81a60ac52 100644
--- a/sound/soc/codecs/ssm2518.c
+++ b/sound/soc/codecs/ssm2518.c
@@ -723,17 +723,11 @@ static struct snd_soc_codec_driver ssm2518_codec_driver = {
.num_dapm_routes = ARRAY_SIZE(ssm2518_routes),
};
-static bool ssm2518_register_volatile(struct device *dev, unsigned int reg)
-{
- return false;
-}
-
static const struct regmap_config ssm2518_regmap_config = {
.val_bits = 8,
.reg_bits = 8,
.max_register = SSM2518_REG_DRC_9,
- .volatile_reg = ssm2518_register_volatile,
.cache_type = REGCACHE_RBTREE,
.reg_defaults = ssm2518_reg_defaults,
--
2.6.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-20 19:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-20 8:54 [PATCH 1/2] ASoC: ssm2518: Drop .volatile_reg implementation Axel Lin
2015-10-20 8:56 ` [PATCH 2/2] ASoC: ad193x: " Axel Lin
2015-10-20 9:02 ` Lars-Peter Clausen
2015-10-20 19:32 ` Applied "ASoC: ad193x: Drop .volatile_reg implementation" to the asoc tree Mark Brown
2015-10-20 9:02 ` [PATCH 1/2] ASoC: ssm2518: Drop .volatile_reg implementation Lars-Peter Clausen
2015-10-20 19:32 ` Applied "ASoC: ssm2518: Drop .volatile_reg implementation" to the asoc tree Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.