All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
To: David Mosberger-Tang
	<davidm-haPfTeumbwasTnJN9+BGXg@public.gmane.org>,
	<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	<cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] spi: atmel: Fix DMA-setup for transfers with more than 8 bits per word.
Date: Tue, 20 Oct 2015 12:22:25 +0200	[thread overview]
Message-ID: <562615E1.4030407@atmel.com> (raw)
In-Reply-To: <1445288084-31805-1-git-send-email-davidm-haPfTeumbwasTnJN9+BGXg@public.gmane.org>

Le 19/10/2015 22:54, David Mosberger-Tang a écrit :
> The DMA-slave configuration depends on the whether <= 8 or > 8 bits
> are transferred per word, so we need to call
> atmel_spi_dma_slave_config() with the correct value.
> 
> Signed-off-by: David Mosberger <davidm-haPfTeumbwasTnJN9+BGXg@public.gmane.org>

Thanks for having rewritten this patch! It's much more simple like this ;-)

Acked-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>

For Mark, here is the patchwork entry which can be handy:
https://patchwork.kernel.org/patch/7439931/

Best regards,

> ---
>  drivers/spi/spi-atmel.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 04e48e5..855cc56 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -758,7 +758,8 @@ static int atmel_spi_next_xfer_dma_submit(struct spi_master *master,
>  
>  	*plen = len;
>  
> -	if (atmel_spi_dma_slave_config(as, &slave_config, 8))
> +	if (atmel_spi_dma_slave_config(as, &slave_config,
> +				       xfer->bits_per_word))
>  		goto err_exit;
>  
>  	/* Send both scatterlists */
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: atmel: Fix DMA-setup for transfers with more than 8 bits per word.
Date: Tue, 20 Oct 2015 12:22:25 +0200	[thread overview]
Message-ID: <562615E1.4030407@atmel.com> (raw)
In-Reply-To: <1445288084-31805-1-git-send-email-davidm@egauge.net>

Le 19/10/2015 22:54, David Mosberger-Tang a ?crit :
> The DMA-slave configuration depends on the whether <= 8 or > 8 bits
> are transferred per word, so we need to call
> atmel_spi_dma_slave_config() with the correct value.
> 
> Signed-off-by: David Mosberger <davidm@egauge.net>

Thanks for having rewritten this patch! It's much more simple like this ;-)

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

For Mark, here is the patchwork entry which can be handy:
https://patchwork.kernel.org/patch/7439931/

Best regards,

> ---
>  drivers/spi/spi-atmel.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 04e48e5..855cc56 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -758,7 +758,8 @@ static int atmel_spi_next_xfer_dma_submit(struct spi_master *master,
>  
>  	*plen = len;
>  
> -	if (atmel_spi_dma_slave_config(as, &slave_config, 8))
> +	if (atmel_spi_dma_slave_config(as, &slave_config,
> +				       xfer->bits_per_word))
>  		goto err_exit;
>  
>  	/* Send both scatterlists */
> 


-- 
Nicolas Ferre

  parent reply	other threads:[~2015-10-20 10:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 20:54 [PATCH] spi: atmel: Fix DMA-setup for transfers with more than 8 bits per word David Mosberger-Tang
2015-10-19 20:54 ` David Mosberger-Tang
     [not found] ` <1445288084-31805-1-git-send-email-davidm-haPfTeumbwasTnJN9+BGXg@public.gmane.org>
2015-10-20 10:22   ` Nicolas Ferre [this message]
2015-10-20 10:22     ` Nicolas Ferre
     [not found]     ` <562615E1.4030407-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-10-20 10:27       ` Mark Brown
2015-10-20 10:27         ` Mark Brown
     [not found]         ` <20151020102726.GX32054-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-10-20 12:26           ` Nicolas Ferre
2015-10-20 12:26             ` Nicolas Ferre
2015-10-20 12:26   ` [RESEND PATCH] " Nicolas Ferre
2015-10-20 12:26     ` Nicolas Ferre
2015-10-20 12:26     ` Nicolas Ferre
2015-10-22 23:10   ` Applied "spi: atmel: Fix DMA-setup for transfers with more than 8 bits per word" to the spi tree Mark Brown
2015-10-22 23:10     ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2015-10-19 20:48 [PATCH] spi: atmel: Fix DMA-setup for transfers with more than 8 bits per word David Mosberger-Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562615E1.4030407@atmel.com \
    --to=nicolas.ferre-aife0yeh4naavxtiumwx3w@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
    --cc=davidm-haPfTeumbwasTnJN9+BGXg@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.