From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFT] ARM: bcm2835: dt: fix memory of Raspberry Pi B+
Date: Tue, 20 Oct 2015 20:37:51 -0600 [thread overview]
Message-ID: <5626FA7F.2060903@wwwdotorg.org> (raw)
In-Reply-To: <8737x5ncod.fsf@eliezer.anholt.net>
On 10/20/2015 02:53 AM, Eric Anholt wrote:
> Stefan Wahren <stefan.wahren@i2se.com> writes:
>
>> Since the Raspberry Pi models differ in memory amount we better
>> define it at board level. After that we are able to fix the
>> memory node of the Raspberry Pi B+ .
>> diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
>> b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
>> + memory { + reg = <0 0x10000000>; /* 256 MB */ + }; +
>
> Seems like a good idea. The closed firmware passes us an edited
> devicetree with good memory fields, but I don't think U-Boot is up
> to it if you chainload it.
U-Boot fills in the memory size in DT correctly too.
I have no objection to the patch since it looks correct at a very
brief glance, but I think it will have zero practical effect.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>,
Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
Cc: Lee Jones <lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH RFT] ARM: bcm2835: dt: fix memory of Raspberry Pi B+
Date: Tue, 20 Oct 2015 20:37:51 -0600 [thread overview]
Message-ID: <5626FA7F.2060903@wwwdotorg.org> (raw)
In-Reply-To: <8737x5ncod.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
On 10/20/2015 02:53 AM, Eric Anholt wrote:
> Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> writes:
>
>> Since the Raspberry Pi models differ in memory amount we better
>> define it at board level. After that we are able to fix the
>> memory node of the Raspberry Pi B+ .
>> diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
>> b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
>> + memory { + reg = <0 0x10000000>; /* 256 MB */ + }; +
>
> Seems like a good idea. The closed firmware passes us an edited
> devicetree with good memory fields, but I don't think U-Boot is up
> to it if you chainload it.
U-Boot fills in the memory size in DT correctly too.
I have no objection to the patch since it looks correct at a very
brief glance, but I think it will have zero practical effect.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-21 2:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 20:48 [PATCH RFT] ARM: bcm2835: dt: fix memory of Raspberry Pi B+ Stefan Wahren
2015-10-15 20:48 ` Stefan Wahren
2015-10-20 8:53 ` Eric Anholt
2015-10-20 8:53 ` Eric Anholt
2015-10-20 17:29 ` Stefan Wahren
2015-10-20 17:29 ` Stefan Wahren
2015-10-21 2:37 ` Stephen Warren [this message]
2015-10-21 2:37 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5626FA7F.2060903@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.