All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] base.bbclass: considering multilib when setting LICENSE_EXCLUSION
@ 2015-10-08  6:47 Jian Liu
  2015-10-16  5:58 ` Liu Jian
  0 siblings, 1 reply; 5+ messages in thread
From: Jian Liu @ 2015-10-08  6:47 UTC (permalink / raw)
  To: openembedded-core

The PACKAGES is not mapped with MLPREFIX when setting LICENSE_EXCLUSION
in base.bbclass. For example,
  For libgcc-dev,
    LICENSE_EXCLUSION-libgcc-dev=1
   but for lib32-libgcc-dev,
    LICENSE_EXCLUSION-libgcc-dev=1
Obviously it is wrong for lib32-libgcc-dev.

Add MLPREFIX before the package name during setting LICENSE_EXCLUSION

Signed-off-by: Jian Liu <jian.liu@windriver.com>
---
 meta/classes/base.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index f078001..89c8f04 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -512,7 +512,8 @@ python () {
                 if unskipped_pkgs:
                     for pkg in skipped_pkgs:
                         bb.debug(1, "SKIPPING the package " + pkg + " at do_rootfs because it's " + recipe_license)
-                        d.setVar('LICENSE_EXCLUSION-' + pkg, 1)
+                        mlprefix = d.getVar('MLPREFIX', True)
+                        d.setVar('LICENSE_EXCLUSION-' + mlprefix + pkg, 1)
                     for pkg in unskipped_pkgs:
                         bb.debug(1, "INCLUDING the package " + pkg)
                 elif all_skipped or incompatible_license(d, bad_licenses):
-- 
1.8.5.2.233.g932f7e4



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] base.bbclass: considering multilib when setting LICENSE_EXCLUSION
  2015-10-08  6:47 [PATCH] base.bbclass: considering multilib when setting LICENSE_EXCLUSION Jian Liu
@ 2015-10-16  5:58 ` Liu Jian
  2015-10-21  2:42   ` Liu Jian
  2015-10-26  3:22   ` Liu Jian
  0 siblings, 2 replies; 5+ messages in thread
From: Liu Jian @ 2015-10-16  5:58 UTC (permalink / raw)
  To: openembedded-core

Hi All,

Will you going to merge this patch?
I have ever discuss with Robert Yang and he agreed to integrated it.

Thanks!
Jian


于 2015年10月08日 14:47, Jian Liu 写道:
> The PACKAGES is not mapped with MLPREFIX when setting LICENSE_EXCLUSION
> in base.bbclass. For example,
>    For libgcc-dev,
>      LICENSE_EXCLUSION-libgcc-dev=1
>     but for lib32-libgcc-dev,
>      LICENSE_EXCLUSION-libgcc-dev=1
> Obviously it is wrong for lib32-libgcc-dev.
>
> Add MLPREFIX before the package name during setting LICENSE_EXCLUSION
>
> Signed-off-by: Jian Liu <jian.liu@windriver.com>
> ---
>   meta/classes/base.bbclass | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index f078001..89c8f04 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -512,7 +512,8 @@ python () {
>                   if unskipped_pkgs:
>                       for pkg in skipped_pkgs:
>                           bb.debug(1, "SKIPPING the package " + pkg + " at do_rootfs because it's " + recipe_license)
> -                        d.setVar('LICENSE_EXCLUSION-' + pkg, 1)
> +                        mlprefix = d.getVar('MLPREFIX', True)
> +                        d.setVar('LICENSE_EXCLUSION-' + mlprefix + pkg, 1)
>                       for pkg in unskipped_pkgs:
>                           bb.debug(1, "INCLUDING the package " + pkg)
>                   elif all_skipped or incompatible_license(d, bad_licenses):

-- 
Jian Liu
Email: jian.liu@windriver.com
Office Phone: 86-10-84778539



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] base.bbclass: considering multilib when setting LICENSE_EXCLUSION
  2015-10-16  5:58 ` Liu Jian
@ 2015-10-21  2:42   ` Liu Jian
  2015-10-26  3:22   ` Liu Jian
  1 sibling, 0 replies; 5+ messages in thread
From: Liu Jian @ 2015-10-21  2:42 UTC (permalink / raw)
  To: openembedded-core

Ping

于 2015年10月16日 13:58, Liu Jian 写道:
> Hi All,
>
> Will you going to merge this patch?
> I have ever discuss with Robert Yang and he agreed to integrated it.
>
> Thanks!
> Jian
>
>
> 于 2015年10月08日 14:47, Jian Liu 写道:
>> The PACKAGES is not mapped with MLPREFIX when setting LICENSE_EXCLUSION
>> in base.bbclass. For example,
>>    For libgcc-dev,
>>      LICENSE_EXCLUSION-libgcc-dev=1
>>     but for lib32-libgcc-dev,
>>      LICENSE_EXCLUSION-libgcc-dev=1
>> Obviously it is wrong for lib32-libgcc-dev.
>>
>> Add MLPREFIX before the package name during setting LICENSE_EXCLUSION
>>
>> Signed-off-by: Jian Liu <jian.liu@windriver.com>
>> ---
>>   meta/classes/base.bbclass | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
>> index f078001..89c8f04 100644
>> --- a/meta/classes/base.bbclass
>> +++ b/meta/classes/base.bbclass
>> @@ -512,7 +512,8 @@ python () {
>>                   if unskipped_pkgs:
>>                       for pkg in skipped_pkgs:
>>                           bb.debug(1, "SKIPPING the package " + pkg + 
>> " at do_rootfs because it's " + recipe_license)
>> -                        d.setVar('LICENSE_EXCLUSION-' + pkg, 1)
>> +                        mlprefix = d.getVar('MLPREFIX', True)
>> +                        d.setVar('LICENSE_EXCLUSION-' + mlprefix + 
>> pkg, 1)
>>                       for pkg in unskipped_pkgs:
>>                           bb.debug(1, "INCLUDING the package " + pkg)
>>                   elif all_skipped or incompatible_license(d, 
>> bad_licenses):
>

-- 
Jian Liu
Email: jian.liu@windriver.com
Office Phone: 86-10-84778539



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] base.bbclass: considering multilib when setting LICENSE_EXCLUSION
  2015-10-16  5:58 ` Liu Jian
  2015-10-21  2:42   ` Liu Jian
@ 2015-10-26  3:22   ` Liu Jian
  2015-10-26 16:10     ` Burton, Ross
  1 sibling, 1 reply; 5+ messages in thread
From: Liu Jian @ 2015-10-26  3:22 UTC (permalink / raw)
  To: openembedded-core

Ping

于 2015年10月16日 13:58, Liu Jian 写道:
> Hi All,
>
> Will you going to merge this patch?
> I have ever discuss with Robert Yang and he agreed to integrated it.
>
> Thanks!
> Jian
>
>
> 于 2015年10月08日 14:47, Jian Liu 写道:
>> The PACKAGES is not mapped with MLPREFIX when setting LICENSE_EXCLUSION
>> in base.bbclass. For example,
>>    For libgcc-dev,
>>      LICENSE_EXCLUSION-libgcc-dev=1
>>     but for lib32-libgcc-dev,
>>      LICENSE_EXCLUSION-libgcc-dev=1
>> Obviously it is wrong for lib32-libgcc-dev.
>>
>> Add MLPREFIX before the package name during setting LICENSE_EXCLUSION
>>
>> Signed-off-by: Jian Liu <jian.liu@windriver.com>
>> ---
>>   meta/classes/base.bbclass | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
>> index f078001..89c8f04 100644
>> --- a/meta/classes/base.bbclass
>> +++ b/meta/classes/base.bbclass
>> @@ -512,7 +512,8 @@ python () {
>>                   if unskipped_pkgs:
>>                       for pkg in skipped_pkgs:
>>                           bb.debug(1, "SKIPPING the package " + pkg + 
>> " at do_rootfs because it's " + recipe_license)
>> -                        d.setVar('LICENSE_EXCLUSION-' + pkg, 1)
>> +                        mlprefix = d.getVar('MLPREFIX', True)
>> +                        d.setVar('LICENSE_EXCLUSION-' + mlprefix + 
>> pkg, 1)
>>                       for pkg in unskipped_pkgs:
>>                           bb.debug(1, "INCLUDING the package " + pkg)
>>                   elif all_skipped or incompatible_license(d, 
>> bad_licenses):
>

-- 
Jian Liu
Email: jian.liu@windriver.com
Office Phone: 86-10-84778539



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] base.bbclass: considering multilib when setting LICENSE_EXCLUSION
  2015-10-26  3:22   ` Liu Jian
@ 2015-10-26 16:10     ` Burton, Ross
  0 siblings, 0 replies; 5+ messages in thread
From: Burton, Ross @ 2015-10-26 16:10 UTC (permalink / raw)
  To: Liu Jian; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 2157 bytes --]

This is in the queue and will likely be merged for Jethro.

Ross

On 26 October 2015 at 03:22, Liu Jian <jian.liu@windriver.com> wrote:

> Ping
>
> 于 2015年10月16日 13:58, Liu Jian 写道:
>
>> Hi All,
>>
>> Will you going to merge this patch?
>> I have ever discuss with Robert Yang and he agreed to integrated it.
>>
>> Thanks!
>> Jian
>>
>>
>> 于 2015年10月08日 14:47, Jian Liu 写道:
>>
>>> The PACKAGES is not mapped with MLPREFIX when setting LICENSE_EXCLUSION
>>> in base.bbclass. For example,
>>>    For libgcc-dev,
>>>      LICENSE_EXCLUSION-libgcc-dev=1
>>>     but for lib32-libgcc-dev,
>>>      LICENSE_EXCLUSION-libgcc-dev=1
>>> Obviously it is wrong for lib32-libgcc-dev.
>>>
>>> Add MLPREFIX before the package name during setting LICENSE_EXCLUSION
>>>
>>> Signed-off-by: Jian Liu <jian.liu@windriver.com>
>>> ---
>>>   meta/classes/base.bbclass | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
>>> index f078001..89c8f04 100644
>>> --- a/meta/classes/base.bbclass
>>> +++ b/meta/classes/base.bbclass
>>> @@ -512,7 +512,8 @@ python () {
>>>                   if unskipped_pkgs:
>>>                       for pkg in skipped_pkgs:
>>>                           bb.debug(1, "SKIPPING the package " + pkg + "
>>> at do_rootfs because it's " + recipe_license)
>>> -                        d.setVar('LICENSE_EXCLUSION-' + pkg, 1)
>>> +                        mlprefix = d.getVar('MLPREFIX', True)
>>> +                        d.setVar('LICENSE_EXCLUSION-' + mlprefix + pkg,
>>> 1)
>>>                       for pkg in unskipped_pkgs:
>>>                           bb.debug(1, "INCLUDING the package " + pkg)
>>>                   elif all_skipped or incompatible_license(d,
>>> bad_licenses):
>>>
>>
>>
> --
> Jian Liu
> Email: jian.liu@windriver.com
> Office Phone: 86-10-84778539
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3298 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-10-26 16:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-08  6:47 [PATCH] base.bbclass: considering multilib when setting LICENSE_EXCLUSION Jian Liu
2015-10-16  5:58 ` Liu Jian
2015-10-21  2:42   ` Liu Jian
2015-10-26  3:22   ` Liu Jian
2015-10-26 16:10     ` Burton, Ross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.