From: Stephen Warren <swarren@wwwdotorg.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: linux-rpi-kernel@lists.infradead.org, Lee Jones <lee@kernel.org>,
linux-pm@vger.kernel.org, Eric Anholt <eric@anholt.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] bcm2835: Add Raspberry Pi CPU frequency control to the device tree
Date: Tue, 20 Oct 2015 21:00:18 -0600 [thread overview]
Message-ID: <5626FFC2.4060102@wwwdotorg.org> (raw)
In-Reply-To: <1444592795-15129-1-git-send-email-lkundrak@v3.sk>
On 10/11/2015 01:46 PM, Lubomir Rintel wrote:
> This adds a device tree binding for Broadcom BCM2834 CPU frequency control
> driven via Raspberry Pi VideoCore 4 firmware interface.
Oh I see; that DT binding was sent as a separate patch rather than part
of the series...
DT bindings patches need to be sent to the people/lists in the following
MAINTAINERS entry:
OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
M: Rob Herring <robh+dt@kernel.org>
M: Pawel Moll <pawel.moll@arm.com>
M: Mark Rutland <mark.rutland@arm.com>
M: Ian Campbell <ijc+devicetree@hellion.org.uk>
M: Kumar Gala <galak@codeaurora.org>
L: devicetree@vger.kernel.org
> diff --git a/Documentation/devicetree/bindings/cpufreq/raspberrypi,bcm2835-cpufreq.txt b/Documentation/devicetree/bindings/cpufreq/raspberrypi,bcm2835-cpufreq.txt
> new file mode 100644
> index 0000000..eb126d3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/cpufreq/raspberrypi,bcm2835-cpufreq.txt
> @@ -0,0 +1,13 @@
> +Raspberry Pi Broadcom BCM2835 CPU frequency control
> +
> +Required properties:
> +
> +- compatible : should be "raspberrypi,bcm2835-cpufreq"
> +- firmware : the Raspberry Pi firmware node
It'd be best practice to mention the filename of the binding that
defines the firmware. For example:
- firmware : phandle of the Raspberry Pi firmware node, as defined in
.././arm/bcm/raspberrypi,bcm2835-firmware.txt.
That said, I'm not convinced cpufreq scaling should rely on the firmware
directly, but instead should use the clock API to manipulate the clock.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] bcm2835: Add Raspberry Pi CPU frequency control to the device tree
Date: Tue, 20 Oct 2015 21:00:18 -0600 [thread overview]
Message-ID: <5626FFC2.4060102@wwwdotorg.org> (raw)
In-Reply-To: <1444592795-15129-1-git-send-email-lkundrak@v3.sk>
On 10/11/2015 01:46 PM, Lubomir Rintel wrote:
> This adds a device tree binding for Broadcom BCM2834 CPU frequency control
> driven via Raspberry Pi VideoCore 4 firmware interface.
Oh I see; that DT binding was sent as a separate patch rather than part
of the series...
DT bindings patches need to be sent to the people/lists in the following
MAINTAINERS entry:
OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
M: Rob Herring <robh+dt@kernel.org>
M: Pawel Moll <pawel.moll@arm.com>
M: Mark Rutland <mark.rutland@arm.com>
M: Ian Campbell <ijc+devicetree@hellion.org.uk>
M: Kumar Gala <galak@codeaurora.org>
L: devicetree at vger.kernel.org
> diff --git a/Documentation/devicetree/bindings/cpufreq/raspberrypi,bcm2835-cpufreq.txt b/Documentation/devicetree/bindings/cpufreq/raspberrypi,bcm2835-cpufreq.txt
> new file mode 100644
> index 0000000..eb126d3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/cpufreq/raspberrypi,bcm2835-cpufreq.txt
> @@ -0,0 +1,13 @@
> +Raspberry Pi Broadcom BCM2835 CPU frequency control
> +
> +Required properties:
> +
> +- compatible : should be "raspberrypi,bcm2835-cpufreq"
> +- firmware : the Raspberry Pi firmware node
It'd be best practice to mention the filename of the binding that
defines the firmware. For example:
- firmware : phandle of the Raspberry Pi firmware node, as defined in
.././arm/bcm/raspberrypi,bcm2835-firmware.txt.
That said, I'm not convinced cpufreq scaling should rely on the firmware
directly, but instead should use the clock API to manipulate the clock.
next prev parent reply other threads:[~2015-10-21 3:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-11 19:46 [PATCH] bcm2835: Add Raspberry Pi CPU frequency control to the device tree Lubomir Rintel
2015-10-11 19:46 ` Lubomir Rintel
2015-10-15 0:29 ` Eric Anholt
2015-10-15 0:29 ` Eric Anholt
2015-10-21 3:00 ` Stephen Warren [this message]
2015-10-21 3:00 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5626FFC2.4060102@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=eric@anholt.net \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.