[meta-oe][PATCH 1/4] rrdtool: fix useless-rpath QA issue

[meta-oe][PATCH 1/4] rrdtool: fix useless-rpath QA issue

[Chen Qi]

When building rrdtool, we would meet the following error.

  ERROR: QA Issue: rrdtool-python: work/core2-64-poky-linux/rrdtool
  /1.5.4-r0/packages-split/rrdtool-python/usr/lib/python2.7/site-packages
  /rrdtool.so contains probably-redundant RPATH /usr/lib [useless-rpaths]

Fix this issue by removing the redundante RPATH section from rrdtool.so.

As we use '--disable-rpath' in EXTRA_OECONF, we don't need to the `sed'
line in do_configure.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb b/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
index 91a30cf..f2ded65 100644
--- a/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
+++ b/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
@@ -71,7 +71,6 @@ do_configure() {
     PYTHON_INCLUDES="-I=/usr/include/python${PYTHON_BASEVERSION}"' \
         ${S}/m4/acinclude.m4
     #remove the hardcoded $(libdir) rpath
-    sed -i -e 's|--rpath=$(libdir)||g' ${S}/bindings/Makefile.am
 
     autotools_do_configure
 
@@ -100,6 +99,11 @@ do_configure() {
         ${B}/examples/*.pl
 }
 
+do_compile_append() {
+    # Remove useless rpath
+    find ${B}/bindings/python/build -name "rrdtool.so" | xargs chrpath -d
+}
+
 PACKAGES =+ "${PN}-perl ${PN}-python"
 
 FILES_${PN}-doc += "${datadir}/examples"
-- 
1.9.1

Re: [meta-oe][PATCH 1/4] rrdtool: fix useless-rpath QA issue

[Ray, Ian (GE Healthcare)]

Hi,

> Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
> ---
>  meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb b/meta-
> oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
> index 91a30cf..f2ded65 100644
> --- a/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
> +++ b/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
> @@ -71,7 +71,6 @@ do_configure() {
>      PYTHON_INCLUDES="-I=/usr/include/python${PYTHON_BASEVERSION}"'
> \
>          ${S}/m4/acinclude.m4
>      #remove the hardcoded $(libdir) rpath
> -    sed -i -e 's|--rpath=$(libdir)||g' ${S}/bindings/Makefile.am

I tested locally a simpler patch:

@@ -71,7 +71,7 @@ do_configure() {
     PYTHON_INCLUDES="-I=/usr/include/python${PYTHON_BASEVERSION}"' \
         ${S}/m4/acinclude.m4
     #remove the hardcoded $(libdir) rpath
-    sed -i -e 's|--rpath=$(libdir)||g' ${S}/bindings/Makefile.am
+    sed -i -e 's|LD_RUN_PATH=$(libdir)||g' ${S}/bindings/Makefile.am


> @@ -100,6 +99,11 @@ do_configure() {
>          ${B}/examples/*.pl
>  }
> 
> +do_compile_append() {
> +    # Remove useless rpath
> +    find ${B}/bindings/python/build -name "rrdtool.so" | xargs chrpath -d
> +}

This fails for me since chrpath is not built for multilib.

Re: [meta-oe][PATCH 1/4] rrdtool: fix useless-rpath QA issue

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1878 bytes --]

On Tue, Oct 13, 2015 at 10:43:55AM +0800, Chen Qi wrote:
> When building rrdtool, we would meet the following error.

Now it fails for qemuarm and qemux86, not sure which change is causing
that:

http://errors.yoctoproject.org/Errors/Details/20597/
http://errors.yoctoproject.org/Errors/Details/20601/

> 
>   ERROR: QA Issue: rrdtool-python: work/core2-64-poky-linux/rrdtool
>   /1.5.4-r0/packages-split/rrdtool-python/usr/lib/python2.7/site-packages
>   /rrdtool.so contains probably-redundant RPATH /usr/lib [useless-rpaths]
> 
> Fix this issue by removing the redundante RPATH section from rrdtool.so.
> 
> As we use '--disable-rpath' in EXTRA_OECONF, we don't need to the `sed'
> line in do_configure.
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb b/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
> index 91a30cf..f2ded65 100644
> --- a/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
> +++ b/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
> @@ -71,7 +71,6 @@ do_configure() {
>      PYTHON_INCLUDES="-I=/usr/include/python${PYTHON_BASEVERSION}"' \
>          ${S}/m4/acinclude.m4
>      #remove the hardcoded $(libdir) rpath
> -    sed -i -e 's|--rpath=$(libdir)||g' ${S}/bindings/Makefile.am
>  
>      autotools_do_configure
>  
> @@ -100,6 +99,11 @@ do_configure() {
>          ${B}/examples/*.pl
>  }
>  
> +do_compile_append() {
> +    # Remove useless rpath
> +    find ${B}/bindings/python/build -name "rrdtool.so" | xargs chrpath -d
> +}
> +
>  PACKAGES =+ "${PN}-perl ${PN}-python"
>  
>  FILES_${PN}-doc += "${datadir}/examples"
> -- 
> 1.9.1
> 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [meta-oe][PATCH 1/4] rrdtool: fix useless-rpath QA issue

[ChenQi]

On 10/20/2015 11:57 PM, Martin Jansa wrote:
> On Tue, Oct 13, 2015 at 10:43:55AM +0800, Chen Qi wrote:
>> When building rrdtool, we would meet the following error.
> Now it fails for qemuarm and qemux86, not sure which change is causing
> that:
>
> http://errors.yoctoproject.org/Errors/Details/20597/
> http://errors.yoctoproject.org/Errors/Details/20601/
>

I'm looking into this problem today, although I currently have some 
problem reproducing it.
I'll look at the logs and try to find out something.

Regards,
Chen Qi

>>    ERROR: QA Issue: rrdtool-python: work/core2-64-poky-linux/rrdtool
>>    /1.5.4-r0/packages-split/rrdtool-python/usr/lib/python2.7/site-packages
>>    /rrdtool.so contains probably-redundant RPATH /usr/lib [useless-rpaths]
>>
>> Fix this issue by removing the redundante RPATH section from rrdtool.so.
>>
>> As we use '--disable-rpath' in EXTRA_OECONF, we don't need to the `sed'
>> line in do_configure.
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>>   meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb b/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
>> index 91a30cf..f2ded65 100644
>> --- a/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
>> +++ b/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
>> @@ -71,7 +71,6 @@ do_configure() {
>>       PYTHON_INCLUDES="-I=/usr/include/python${PYTHON_BASEVERSION}"' \
>>           ${S}/m4/acinclude.m4
>>       #remove the hardcoded $(libdir) rpath
>> -    sed -i -e 's|--rpath=$(libdir)||g' ${S}/bindings/Makefile.am
>>   
>>       autotools_do_configure
>>   
>> @@ -100,6 +99,11 @@ do_configure() {
>>           ${B}/examples/*.pl
>>   }
>>   
>> +do_compile_append() {
>> +    # Remove useless rpath
>> +    find ${B}/bindings/python/build -name "rrdtool.so" | xargs chrpath -d
>> +}
>> +
>>   PACKAGES =+ "${PN}-perl ${PN}-python"
>>   
>>   FILES_${PN}-doc += "${datadir}/examples"
>> -- 
>> 1.9.1
>>

Re: [meta-oe][PATCH 1/4] rrdtool: fix useless-rpath QA issue

[ChenQi]

Hi Ray,

I just saw this email.
Thanks a lot for your suggestion.
I've sent out V2.

Best Regards,
Chen Qi


On 10/20/2015 07:14 PM, Ray, Ian (GE Healthcare) wrote:
> Hi,
>
>> Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
>> ---
>>   meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb b/meta-
>> oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
>> index 91a30cf..f2ded65 100644
>> --- a/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
>> +++ b/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
>> @@ -71,7 +71,6 @@ do_configure() {
>>       PYTHON_INCLUDES="-I=/usr/include/python${PYTHON_BASEVERSION}"'
>> \
>>           ${S}/m4/acinclude.m4
>>       #remove the hardcoded $(libdir) rpath
>> -    sed -i -e 's|--rpath=$(libdir)||g' ${S}/bindings/Makefile.am
> I tested locally a simpler patch:
>
> @@ -71,7 +71,7 @@ do_configure() {
>       PYTHON_INCLUDES="-I=/usr/include/python${PYTHON_BASEVERSION}"' \
>           ${S}/m4/acinclude.m4
>       #remove the hardcoded $(libdir) rpath
> -    sed -i -e 's|--rpath=$(libdir)||g' ${S}/bindings/Makefile.am
> +    sed -i -e 's|LD_RUN_PATH=$(libdir)||g' ${S}/bindings/Makefile.am
>
>
>> @@ -100,6 +99,11 @@ do_configure() {
>>           ${B}/examples/*.pl
>>   }
>>
>> +do_compile_append() {
>> +    # Remove useless rpath
>> +    find ${B}/bindings/python/build -name "rrdtool.so" | xargs chrpath -d
>> +}
> This fails for me since chrpath is not built for multilib.
>
>