From: boris.ostrovsky@oracle.com (Boris Ostrovsky)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/3] xen, cpu_hotplug: call device_offline instead of cpu_down
Date: Wed, 21 Oct 2015 08:56:12 -0400 [thread overview]
Message-ID: <56278B6C.7090608@oracle.com> (raw)
In-Reply-To: <1445428430-21567-2-git-send-email-stefano.stabellini@eu.citrix.com>
On 10/21/2015 07:53 AM, Stefano Stabellini wrote:
> When offlining a cpu, instead of cpu_down, call device_offline, which
> also takes care of updating the cpu.dev.offline field. This keeps the
> sysfs file /sys/devices/system/cpu/cpuN/online, up to date. Also move
> the call to disable_hotplug_cpu, because it makes more sense to have it
> there.
>
> We don't call device_online at cpu-hotplug time, because that would
> immediately take the cpu online, while we want to retain the current
> behaviour: the user needs to explicitly enable the cpu after it has
> been hotplugged.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> CC: konrad.wilk at oracle.com
> CC: boris.ostrovsky at oracle.com
> CC: david.vrabel at citrix.com
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
WARNING: multiple messages have this Message-ID (diff)
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xensource.com
Cc: david.vrabel@citrix.com, linux-arm-kernel@lists.infradead.org,
konrad.wilk@oracle.com
Subject: Re: [PATCH v4 2/3] xen, cpu_hotplug: call device_offline instead of cpu_down
Date: Wed, 21 Oct 2015 08:56:12 -0400 [thread overview]
Message-ID: <56278B6C.7090608@oracle.com> (raw)
In-Reply-To: <1445428430-21567-2-git-send-email-stefano.stabellini@eu.citrix.com>
On 10/21/2015 07:53 AM, Stefano Stabellini wrote:
> When offlining a cpu, instead of cpu_down, call device_offline, which
> also takes care of updating the cpu.dev.offline field. This keeps the
> sysfs file /sys/devices/system/cpu/cpuN/online, up to date. Also move
> the call to disable_hotplug_cpu, because it makes more sense to have it
> there.
>
> We don't call device_online at cpu-hotplug time, because that would
> immediately take the cpu online, while we want to retain the current
> behaviour: the user needs to explicitly enable the cpu after it has
> been hotplugged.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> CC: konrad.wilk@oracle.com
> CC: boris.ostrovsky@oracle.com
> CC: david.vrabel@citrix.com
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
next prev parent reply other threads:[~2015-10-21 12:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 11:52 [PATCH v4] xen,arm: enable cpu_hotplug Stefano Stabellini
2015-10-21 11:52 ` Stefano Stabellini
2015-10-21 11:53 ` [PATCH v4 1/3] xen/arm: Enable cpu_hotplug.c Stefano Stabellini
2015-10-21 11:53 ` Stefano Stabellini
2015-10-21 13:00 ` Stefano Stabellini
2015-10-21 13:00 ` Stefano Stabellini
2015-10-21 13:19 ` Boris Ostrovsky
2015-10-21 13:19 ` Boris Ostrovsky
2015-10-21 15:36 ` Stefano Stabellini
2015-10-21 15:36 ` Stefano Stabellini
2015-10-22 16:13 ` Stefano Stabellini
2015-10-22 16:13 ` Stefano Stabellini
2015-10-22 16:15 ` Boris Ostrovsky
2015-10-22 16:15 ` Boris Ostrovsky
2015-10-22 16:22 ` Stefano Stabellini
2015-10-22 16:22 ` Stefano Stabellini
2015-10-21 11:53 ` [PATCH v4 2/3] xen, cpu_hotplug: call device_offline instead of cpu_down Stefano Stabellini
2015-10-21 11:53 ` Stefano Stabellini
2015-10-21 12:56 ` Boris Ostrovsky [this message]
2015-10-21 12:56 ` Boris Ostrovsky
2015-10-21 11:53 ` [PATCH v4 3/3] xen/arm: don't try to re-register vcpu_info on cpu_hotplug Stefano Stabellini
2015-10-21 11:53 ` Stefano Stabellini
2015-10-21 11:55 ` [Xen-devel] " Julien Grall
2015-10-21 11:55 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56278B6C.7090608@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.