Re: [PATCH] usnix: correctly handle kzalloc return value

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

On 10/17/2015 03:06 PM, Insu Yun wrote:
> Since kzalloc returns memory address, not error code,
> it should be checked whether it is null or not. 
> 
> Signed-off-by: Insu Yun <wuninsu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Thanks, applied.

> ---
>  drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c b/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c
> index db3588d..a678a66 100644
> --- a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c
> +++ b/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c
> @@ -221,8 +221,8 @@ create_roce_custom_flow(struct usnic_ib_qp_grp *qp_grp,
>  
>  	/* Create Flow Handle */
>  	qp_flow = kzalloc(sizeof(*qp_flow), GFP_ATOMIC);
> -	if (IS_ERR_OR_NULL(qp_flow)) {
> -		err = qp_flow ? PTR_ERR(qp_flow) : -ENOMEM;
> +	if (!qp_flow) {
> +		err = -ENOMEM;
>  		goto out_dealloc_flow;
>  	}
>  	qp_flow->flow = flow;
> @@ -296,8 +296,8 @@ create_udp_flow(struct usnic_ib_qp_grp *qp_grp,
>  
>  	/* Create qp_flow */
>  	qp_flow = kzalloc(sizeof(*qp_flow), GFP_ATOMIC);
> -	if (IS_ERR_OR_NULL(qp_flow)) {
> -		err = qp_flow ? PTR_ERR(qp_flow) : -ENOMEM;
> +	if (!qp_flow) {
> +		err = -ENOMEM;
>  		goto out_dealloc_flow;
>  	}
>  	qp_flow->flow = flow;
> 


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]