From: Doug Ledford <dledford@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>, Steve Wise <swise@chelsio.com>
Cc: Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] RDMA/cxgb4: re-fix 32-bit build warning
Date: Wed, 21 Oct 2015 16:57:17 -0400 [thread overview]
Message-ID: <5627FC2D.9000402@redhat.com> (raw)
In-Reply-To: <13543971.LQ3Q8CCxhL@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]
On 10/07/2015 08:10 AM, Arnd Bergmann wrote:
> Casting a pointer to __be64 produces a warning on 32-bit architectures:
>
> drivers/infiniband/hw/cxgb4/mem.c:147:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> req->wr.wr_lo = (__force __be64)&wr_wait;
>
> This was fixed at least twice for this driver in different places,
> and accidentally reverted once more. This puts the correct version
> back in place.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 6198dd8d7a6a7 ("iw_cxgb4: 32b platform fixes")
Thanks, applied.
>
> diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb4/mem.c
> index 026b91ebd5e2..140415d31bcc 100644
> --- a/drivers/infiniband/hw/cxgb4/mem.c
> +++ b/drivers/infiniband/hw/cxgb4/mem.c
> @@ -144,7 +144,7 @@ static int _c4iw_write_mem_inline(struct c4iw_rdev *rdev, u32 addr, u32 len,
> if (i == (num_wqe-1)) {
> req->wr.wr_hi = cpu_to_be32(FW_WR_OP_V(FW_ULPTX_WR) |
> FW_WR_COMPL_F);
> - req->wr.wr_lo = (__force __be64)&wr_wait;
> + req->wr.wr_lo = (__force __be64)(unsigned long)&wr_wait;
> } else
> req->wr.wr_hi = cpu_to_be32(FW_WR_OP_V(FW_ULPTX_WR));
> req->wr.wr_mid = cpu_to_be32(
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: dledford@redhat.com (Doug Ledford)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] RDMA/cxgb4: re-fix 32-bit build warning
Date: Wed, 21 Oct 2015 16:57:17 -0400 [thread overview]
Message-ID: <5627FC2D.9000402@redhat.com> (raw)
In-Reply-To: <13543971.LQ3Q8CCxhL@wuerfel>
On 10/07/2015 08:10 AM, Arnd Bergmann wrote:
> Casting a pointer to __be64 produces a warning on 32-bit architectures:
>
> drivers/infiniband/hw/cxgb4/mem.c:147:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> req->wr.wr_lo = (__force __be64)&wr_wait;
>
> This was fixed at least twice for this driver in different places,
> and accidentally reverted once more. This puts the correct version
> back in place.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 6198dd8d7a6a7 ("iw_cxgb4: 32b platform fixes")
Thanks, applied.
>
> diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb4/mem.c
> index 026b91ebd5e2..140415d31bcc 100644
> --- a/drivers/infiniband/hw/cxgb4/mem.c
> +++ b/drivers/infiniband/hw/cxgb4/mem.c
> @@ -144,7 +144,7 @@ static int _c4iw_write_mem_inline(struct c4iw_rdev *rdev, u32 addr, u32 len,
> if (i == (num_wqe-1)) {
> req->wr.wr_hi = cpu_to_be32(FW_WR_OP_V(FW_ULPTX_WR) |
> FW_WR_COMPL_F);
> - req->wr.wr_lo = (__force __be64)&wr_wait;
> + req->wr.wr_lo = (__force __be64)(unsigned long)&wr_wait;
> } else
> req->wr.wr_hi = cpu_to_be32(FW_WR_OP_V(FW_ULPTX_WR));
> req->wr.wr_mid = cpu_to_be32(
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: 0E572FDD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151021/f618245f/attachment-0001.sig>
next prev parent reply other threads:[~2015-10-21 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 12:10 [PATCH] RDMA/cxgb4: re-fix 32-bit build warning Arnd Bergmann
2015-10-07 12:10 ` Arnd Bergmann
2015-10-07 12:10 ` Arnd Bergmann
2015-10-21 20:57 ` Doug Ledford [this message]
2015-10-21 20:57 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5627FC2D.9000402@redhat.com \
--to=dledford@redhat.com \
--cc=arnd@arndb.de \
--cc=hal.rosenstock@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=swise@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.