meta-toolchain-qt5, qttools-plugins and -nomake examples

meta-toolchain-qt5, qttools-plugins and -nomake examples

[Ivan Sergio Borgonovo]

I think I've been able to find all and only the packages that should be 
conditionally added to RDEPENDS in packagegroup-qt5-toolchain-target.bb 
from opengl.

I finally discovered why there was a problem with meta-toolchain-qt5 and 
qttools-plugins... qttools-plugins doesn't get build when

-nomake examples

Now I don't understand:
- why nobody noticed this problem that doesn't seem related to opengl or 
x11. Was it hidden by something else that I should take care when trying 
to fix it? No one is actually baking meta-toolchain-qt5?...

- what should be considered a correct solution:
* simply remove the package that doesn't really seem that useful in a 
toolchain (they should be example plugins for qtcreator)
* conditionally add it just if qt get build with examples [1]
* still adding qttools-plugins in local.conf will trigger the problem. 
Is there a way to automatically enable a "package feature" if a package 
get included?
One of the way to "fix" this could be to
PACKAGECONFIG_DISTRO_append_pn-qtbase = " examples..."

What is the consensus so I could adapt my patch to
packagegroup-qt5-toolchain-target.bb
and get a chance to see it merged?

thanks

[1] How? I know how to check if a DISTRO_FEATURES has been enabled but 
how can I check if a package option has been enabled?
-- 
Ivan Sergio Borgonovo
http://www.webthatworks.it

Re: meta-toolchain-qt5, qttools-plugins and -nomake examples

[Anders Darander]

* Ivan Sergio Borgonovo <mail@webthatworks.it> [151022 14:13]:

> I think I've been able to find all and only the packages that should be
> conditionally added to RDEPENDS in packagegroup-qt5-toolchain-target.bb from
> opengl.

> I finally discovered why there was a problem with meta-toolchain-qt5 and
> qttools-plugins... qttools-plugins doesn't get build when

> -nomake examples

> Now I don't understand:
> - why nobody noticed this problem that doesn't seem related to opengl or
> x11. Was it hidden by something else that I should take care when trying to
> fix it? No one is actually baking meta-toolchain-qt5?...

Or in my case mostly been staled on an older release...

> - what should be considered a correct solution:
> * simply remove the package that doesn't really seem that useful in a
> toolchain (they should be example plugins for qtcreator)

That what work for me.

> * conditionally add it just if qt get build with examples [1]

Well, this would likely be harder, as one recipe can't access the
meta data from another recipe.

Though, you could likely get the same effect by moving qttools-plugins
from RDEPENDS to RRECOMMENDS. Then it'll be added if it exist, while you
won't get any errors if it doesn't exist. 

Cheers,
Anders

-- 
Anders Darander
ChargeStorm AB / eStorm AB

Re: meta-toolchain-qt5, qttools-plugins and -nomake examples

[Ivan Sergio Borgonovo]

On 10/22/2015 02:28 PM, Anders Darander wrote:

> Though, you could likely get the same effect by moving qttools-plugins
> from RDEPENDS to RRECOMMENDS. Then it'll be added if it exist, while you
> won't get any errors if it doesn't exist.

Deal.

It seems a very reasonable choice. After all examples are disabled by 
default and someone looking for qtcreator plugins is really looking for 
examples too.

A patch will follow. Speak now or forever hold your peace ;)

thanks

-- 
Ivan Sergio Borgonovo
http://www.webthatworks.it