* [Buildroot] [PATCH v1 1/1] gauche: new package @ 2015-10-21 13:35 Hiroshi Kawashima 2015-10-22 13:00 ` Vicente Olivert Riera 0 siblings, 1 reply; 5+ messages in thread From: Hiroshi Kawashima @ 2015-10-21 13:35 UTC (permalink / raw) To: buildroot Gauche is a Scheme scripting engine aiming at being a handy tool that helps programmers and system administrators to write small to large scripts quickly. Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp> --- Please allow me to patch 'configure' directly instead of configure.ac due to incompatibility of autotools version of gauche assumed. --- package/Config.in | 1 + package/gauche/0001-fix-so-suffix.patch | 12 ++++++++++++ package/gauche/Config.in | 14 ++++++++++++++ package/gauche/gauche.hash | 3 +++ package/gauche/gauche.mk | 20 ++++++++++++++++++++ 5 files changed, 50 insertions(+), 0 deletions(-) create mode 100644 package/gauche/0001-fix-so-suffix.patch create mode 100644 package/gauche/Config.in create mode 100644 package/gauche/gauche.hash create mode 100644 package/gauche/gauche.mk diff --git a/package/Config.in b/package/Config.in index 7392363..eb92ead 100644 --- a/package/Config.in +++ b/package/Config.in @@ -459,6 +459,7 @@ menu "Erlang libraries/modules" source "package/erlang-p1-zlib/Config.in" endmenu endif + source "package/gauche/Config.in" source "package/guile/Config.in" source "package/haserl/Config.in" source "package/jamvm/Config.in" diff --git a/package/gauche/0001-fix-so-suffix.patch b/package/gauche/0001-fix-so-suffix.patch new file mode 100644 index 0000000..18d0bd5 --- /dev/null +++ b/package/gauche/0001-fix-so-suffix.patch @@ -0,0 +1,12 @@ +diff -ur a/configure b/configure +--- a/configure 2014-07-20 15:15:05.000000000 +0900 ++++ b/configure 2015-10-20 21:52:32.791442291 +0900 +@@ -6843,7 +6843,7 @@ + SHLIB_MAIN_LDFLAGS="" + SHLIB_OK=ok + ;; +- *-linux-gnu*|*-*-gnu*|*freebsd*|*dragonfly*) ++ *-linux-*|*-*-gnu*|*freebsd*|*dragonfly*) + SHLIB_SO_CFLAGS="-fPIC" + SHLIB_SO_LDFLAGS="$rpath -shared -o" + SHLIB_SO_SUFFIX="so" diff --git a/package/gauche/Config.in b/package/gauche/Config.in new file mode 100644 index 0000000..ad61c3f --- /dev/null +++ b/package/gauche/Config.in @@ -0,0 +1,14 @@ +config BR2_PACKAGE_GAUCHE + bool "gauche" + depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_USE_MMU + help + Gauche is a Scheme scripting engine aiming at being a handy tool + that helps programmers and system administrators to write small + to large scripts quickly. + + http://practical-scheme.net/gauche/ + +comment "gauche needs a toolchain w/ threads" + depends on BR2_USE_MMU + depends on !BR2_TOOLCHAIN_HAS_THREADS diff --git a/package/gauche/gauche.hash b/package/gauche/gauche.hash new file mode 100644 index 0000000..9d19671 --- /dev/null +++ b/package/gauche/gauche.hash @@ -0,0 +1,3 @@ +# Locally calculated +# +sha256 7b18bcd70beaced1e004594be46c8cff95795318f6f5830dd2a8a700410fc149 Gauche-0.9.4.tgz diff --git a/package/gauche/gauche.mk b/package/gauche/gauche.mk new file mode 100644 index 0000000..a329724 --- /dev/null +++ b/package/gauche/gauche.mk @@ -0,0 +1,20 @@ +################################################################################ +# +# gauche +# +################################################################################ + +GAUCHE_VERSION = 0.9.4 +GAUCHE_SOURCE = Gauche-$(GAUCHE_VERSION).tgz +GAUCHE_SITE = http://prdownloads.sourceforge.net/gauche +GAUCHE_LICENSE = BSD +GAUCHE_LICENSE_FILES = COPYING +GAUCHE_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -std=gnu99" +GAUCHE_DEPENDENCIES = host-gauche +GAUCHE_CONF_OPTS = \ + --enable-ipv6 \ + --enable-threads=default \ + --enable-multibyte=utf-8 + +$(eval $(host-autotools-package)) +$(eval $(autotools-package)) -- 1.7.1 ============================================================ Hiroshi Kawashima ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v1 1/1] gauche: new package 2015-10-21 13:35 [Buildroot] [PATCH v1 1/1] gauche: new package Hiroshi Kawashima @ 2015-10-22 13:00 ` Vicente Olivert Riera 2015-10-22 14:26 ` Arnout Vandecappelle 2015-10-23 13:17 ` Hiroshi Kawashima 0 siblings, 2 replies; 5+ messages in thread From: Vicente Olivert Riera @ 2015-10-22 13:00 UTC (permalink / raw) To: buildroot Dear Hiroshi Kawashima, thanks for your contribution. Comments inlined; please keep reading. On 10/21/2015 02:35 PM, Hiroshi Kawashima wrote: > Gauche is a Scheme scripting engine aiming at being a handy tool > that helps programmers and system administrators to write small > to large scripts quickly. Please wrap your commit log at 72 characters length. The word "that" of the second line fits in the first one. Then, "to large" will fit in the second one. > Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp> > --- > Please allow me to patch 'configure' directly instead of configure.ac > due to incompatibility of autotools version of gauche assumed. > --- > package/Config.in | 1 + > package/gauche/0001-fix-so-suffix.patch | 12 ++++++++++++ > package/gauche/Config.in | 14 ++++++++++++++ > package/gauche/gauche.hash | 3 +++ > package/gauche/gauche.mk | 20 ++++++++++++++++++++ > 5 files changed, 50 insertions(+), 0 deletions(-) > create mode 100644 package/gauche/0001-fix-so-suffix.patch > create mode 100644 package/gauche/Config.in > create mode 100644 package/gauche/gauche.hash > create mode 100644 package/gauche/gauche.mk > > diff --git a/package/Config.in b/package/Config.in > index 7392363..eb92ead 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -459,6 +459,7 @@ menu "Erlang libraries/modules" > source "package/erlang-p1-zlib/Config.in" > endmenu > endif > + source "package/gauche/Config.in" > source "package/guile/Config.in" > source "package/haserl/Config.in" > source "package/jamvm/Config.in" > diff --git a/package/gauche/0001-fix-so-suffix.patch b/package/gauche/0001-fix-so-suffix.patch > new file mode 100644 > index 0000000..18d0bd5 > --- /dev/null > +++ b/package/gauche/0001-fix-so-suffix.patch > @@ -0,0 +1,12 @@ The patch should contain a brief description about what it does or why is needed, and also contain your SoB. > +diff -ur a/configure b/configure > +--- a/configure 2014-07-20 15:15:05.000000000 +0900 > ++++ b/configure 2015-10-20 21:52:32.791442291 +0900 > +@@ -6843,7 +6843,7 @@ > + SHLIB_MAIN_LDFLAGS="" > + SHLIB_OK=ok > + ;; > +- *-linux-gnu*|*-*-gnu*|*freebsd*|*dragonfly*) > ++ *-linux-*|*-*-gnu*|*freebsd*|*dragonfly*) > + SHLIB_SO_CFLAGS="-fPIC" > + SHLIB_SO_LDFLAGS="$rpath -shared -o" > + SHLIB_SO_SUFFIX="so" I have built gauche with this patch, and without it, and I don't see any difference. Are you sure this is necessary? If so, why? > diff --git a/package/gauche/Config.in b/package/gauche/Config.in > new file mode 100644 > index 0000000..ad61c3f > --- /dev/null > +++ b/package/gauche/Config.in > @@ -0,0 +1,14 @@ > +config BR2_PACKAGE_GAUCHE > + bool "gauche" > + depends on BR2_TOOLCHAIN_HAS_THREADS This is what the configure's help says: --enable-threads=TYPE Choose thread type. Possible values are: 'none' for not using threads, 'pthreads' to use pthreads, and 'default' to choose system's suitable one (if any). So it seems that having threads is optional. However, I have checked it, and it fails if you don't have them: In file included from ./../gc/libatomic_ops/src/atomic_ops.h:218:0, from lazy.c:78: ./../gc/libatomic_ops/src/atomic_ops/sysdeps/generic_pthread.h:30:21: fatal error: pthread.h: No such file or directory #include <pthread.h> In fact, according to that output, maybe this package should also depend on BR2_ARCH_HAS_ATOMICS. I haven't tested it. Could you? It doesn't fail to build, but maybe it fails at runtime, I don't know. Moreover, BR2_TOOLCHAIN_HAS_THREADS is not enough. It needs to make sure that you have native posix threads, otherwise it will fail like this: TARGETLIB=`pwd` /bin/sh ./makeverslink libgauche-0.9.so TARGETLIB=`pwd` /home/ldap/vriera/git-clones/buildroot-1/output/host/usr/bin/arm-buildroot-linux-uclibcgnueabi-gcc -std=gnu99 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -fPIC -Wl,--rpath -Wl,`pwd` -L. -rdynamic -o gosh main.o -lgauche-0.9 -ldl -lcrypt -lutil -lrt -lm -lpthread ./libgauche-0.9.so: undefined reference to `pthread_spin_destroy' ./libgauche-0.9.so: undefined reference to `pthread_attr_getstack' ./libgauche-0.9.so: undefined reference to `pthread_spin_init' ./libgauche-0.9.so: undefined reference to `pthread_spin_unlock' ./libgauche-0.9.so: undefined reference to `pthread_getattr_np' ./libgauche-0.9.so: undefined reference to `pthread_spin_lock' So you need: depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL > + depends on BR2_USE_MMU You need that because gauche uses fork(), so add " # fork()" at the end of that line: depends on BR2_USE_MMU # fork() > + help > + Gauche is a Scheme scripting engine aiming at being a handy tool > + that helps programmers and system administrators to write small These two lines exceed the 72 characters limit. You have to count every tab as 8 characters, so your first line has 74 characters length, and the second one has 73. The word "tool" should be in the second line, and then, then word "small" should be in the third line. However, why not using the description in Gauche's homepage as is? > + to large scripts quickly. > + > + http://practical-scheme.net/gauche/ > + > +comment "gauche needs a toolchain w/ threads" > + depends on BR2_USE_MMU > + depends on !BR2_TOOLCHAIN_HAS_THREADS Adjust this accordingly: comment "gauche needs a toolchain w/ NPTL" depends on BR2_USE_MMU depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL > diff --git a/package/gauche/gauche.hash b/package/gauche/gauche.hash > new file mode 100644 > index 0000000..9d19671 > --- /dev/null > +++ b/package/gauche/gauche.hash > @@ -0,0 +1,3 @@ > +# Locally calculated > +# This empty comment line is not need it. Please remove it. > +sha256 7b18bcd70beaced1e004594be46c8cff95795318f6f5830dd2a8a700410fc149 Gauche-0.9.4.tgz > diff --git a/package/gauche/gauche.mk b/package/gauche/gauche.mk > new file mode 100644 > index 0000000..a329724 > --- /dev/null > +++ b/package/gauche/gauche.mk > @@ -0,0 +1,20 @@ > +################################################################################ > +# > +# gauche > +# > +################################################################################ > + > +GAUCHE_VERSION = 0.9.4 > +GAUCHE_SOURCE = Gauche-$(GAUCHE_VERSION).tgz > +GAUCHE_SITE = http://prdownloads.sourceforge.net/gauche > +GAUCHE_LICENSE = BSD > +GAUCHE_LICENSE_FILES = COPYING > +GAUCHE_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -std=gnu99" Normally you wouldn't need this. The configure script checks for c99 support in the compiler and adds that flag. However, this check fails when you don't have support for wchar: 904 configure:3987: /br/output/host/usr/bin/arm-buildroot-uclinux-uclibcgnueabi-g cc -D_STDC_C99= -c -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static - std=gnu99 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 conftest.c >&5 905 conftest.c:59:9: error: unknown type name 'wchar_t' I don't know if WCHAR is needed at runtime. It isn't at buildtime. So, maybe depending on it just to make that configure check work would be overkilling. If WCHAR is not needed at runtime, I'm fine with that little hack. Perhaps a comment about that line explaining why is needed would be a good idea. If at the end we decide to go with the CONF_ENV hack instead of making this package depending on WCHAR, I would suggest you to put that line after the GAUCHE_DEPENDENCIES one, with an empty line separating them. This is just for aesthetic. > +GAUCHE_DEPENDENCIES = host-gauche Ok with this. Just to save time for future reviewers, the HACKING file we find in the sources of gauche says the following: [CROSS COMPILATION] In a normal compilation, extension modules (ext/*) are build using the new gosh just built in src/. However, we can't run src/gosh when we're cross compiling. So you need to install *this version of Gauche* compiled on your platform beforehand. Then, configure with the ordinary cross-compiling options. > +GAUCHE_CONF_OPTS = \ > + --enable-ipv6 \ This is not necessary. --enable-ipv6 is already used in the PKG_CONFIGURE_CMDS in the package/pkg-autotools.mk. > + --enable-threads=default \ You also don't need this, since that's the default value. The configure script does this at line #2806: GAUCHE_THREAD_TYPE=default > + --enable-multibyte=utf-8 And this is not needed either, since it's the default value. The configure script does this at line #2694: GAUCHE_CHAR_ENCODING=utf8 in fact in this case is even more explicit, because after that line it also does this: # Check whether --enable-multibyte was given. if test "${enable_multibyte+set}" = set; then : <whatever> else GAUCHE_CHAR_ENCODING=utf8 ac_configure_args="$ac_configure_args '--enable-multibyte=utf-8'" fi Regards, Vincent. > + > +$(eval $(host-autotools-package)) > +$(eval $(autotools-package)) > ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v1 1/1] gauche: new package 2015-10-22 13:00 ` Vicente Olivert Riera @ 2015-10-22 14:26 ` Arnout Vandecappelle 2015-10-22 14:37 ` Hiroshi Kawashima 2015-10-23 13:17 ` Hiroshi Kawashima 1 sibling, 1 reply; 5+ messages in thread From: Arnout Vandecappelle @ 2015-10-22 14:26 UTC (permalink / raw) To: buildroot On 22-10-15 15:00, Vicente Olivert Riera wrote: > Dear Hiroshi Kawashima, > > thanks for your contribution. Comments inlined; please keep reading. > > On 10/21/2015 02:35 PM, Hiroshi Kawashima wrote: [snip] >> diff --git a/package/gauche/0001-fix-so-suffix.patch b/package/gauche/0001-fix-so-suffix.patch >> new file mode 100644 >> index 0000000..18d0bd5 >> --- /dev/null >> +++ b/package/gauche/0001-fix-so-suffix.patch >> @@ -0,0 +1,12 @@ > > The patch should contain a brief description about what it does or why > is needed, and also contain your SoB. > >> +diff -ur a/configure b/configure >> +--- a/configure 2014-07-20 15:15:05.000000000 +0900 >> ++++ b/configure 2015-10-20 21:52:32.791442291 +0900 >> +@@ -6843,7 +6843,7 @@ >> + SHLIB_MAIN_LDFLAGS="" >> + SHLIB_OK=ok >> + ;; >> +- *-linux-gnu*|*-*-gnu*|*freebsd*|*dragonfly*) >> ++ *-linux-*|*-*-gnu*|*freebsd*|*dragonfly*) >> + SHLIB_SO_CFLAGS="-fPIC" >> + SHLIB_SO_LDFLAGS="$rpath -shared -o" >> + SHLIB_SO_SUFFIX="so" > > I have built gauche with this patch, and without it, and I don't see any > difference. Are you sure this is necessary? If so, why? I guess it's needed for uclibc/musl, they don't have the -gnu part. Regards, Arnout [snip] -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v1 1/1] gauche: new package 2015-10-22 14:26 ` Arnout Vandecappelle @ 2015-10-22 14:37 ` Hiroshi Kawashima 0 siblings, 0 replies; 5+ messages in thread From: Hiroshi Kawashima @ 2015-10-22 14:37 UTC (permalink / raw) To: buildroot Thank you for your comment, Vincente, Arnott. Yes, that?s for uclibc. Anyway, I will post improved/fixed patch later day. > 2015/10/22 23:26?Arnout Vandecappelle <arnout@mind.be> ????? > > On 22-10-15 15:00, Vicente Olivert Riera wrote: >> Dear Hiroshi Kawashima, >> >> thanks for your contribution. Comments inlined; please keep reading. >> >> On 10/21/2015 02:35 PM, Hiroshi Kawashima wrote: > [snip] >>> diff --git a/package/gauche/0001-fix-so-suffix.patch b/package/gauche/0001-fix-so-suffix.patch >>> new file mode 100644 >>> index 0000000..18d0bd5 >>> --- /dev/null >>> +++ b/package/gauche/0001-fix-so-suffix.patch >>> @@ -0,0 +1,12 @@ >> >> The patch should contain a brief description about what it does or why >> is needed, and also contain your SoB. >> >>> +diff -ur a/configure b/configure >>> +--- a/configure 2014-07-20 15:15:05.000000000 +0900 >>> ++++ b/configure 2015-10-20 21:52:32.791442291 +0900 >>> +@@ -6843,7 +6843,7 @@ >>> + SHLIB_MAIN_LDFLAGS="" >>> + SHLIB_OK=ok >>> + ;; >>> +- *-linux-gnu*|*-*-gnu*|*freebsd*|*dragonfly*) >>> ++ *-linux-*|*-*-gnu*|*freebsd*|*dragonfly*) >>> + SHLIB_SO_CFLAGS="-fPIC" >>> + SHLIB_SO_LDFLAGS="$rpath -shared -o" >>> + SHLIB_SO_SUFFIX="so" >> >> I have built gauche with this patch, and without it, and I don't see any >> difference. Are you sure this is necessary? If so, why? > > I guess it's needed for uclibc/musl, they don't have the -gnu part. > > > Regards, > Arnout > > [snip] > > > -- > Arnout Vandecappelle arnout at mind be > Senior Embedded Software Architect +32-16-286500 > Essensium/Mind http://www.mind.be > G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven > LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle > GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v1 1/1] gauche: new package 2015-10-22 13:00 ` Vicente Olivert Riera 2015-10-22 14:26 ` Arnout Vandecappelle @ 2015-10-23 13:17 ` Hiroshi Kawashima 1 sibling, 0 replies; 5+ messages in thread From: Hiroshi Kawashima @ 2015-10-23 13:17 UTC (permalink / raw) To: buildroot Dear, Vincente. Thank you for your detailed comment and test. My reply inlined. I will send v2 PATCH with reflecting your feedback. > On 10/21/2015 02:35 PM, Hiroshi Kawashima wrote: > > Gauche is a Scheme scripting engine aiming at being a handy tool > > that helps programmers and system administrators to write small > > to large scripts quickly. > > Please wrap your commit log at 72 characters length. The word "that" of > the second line fits in the first one. Then, "to large" will fit in the > second one. Ok. > > diff --git a/package/gauche/0001-fix-so-suffix.patch b/package/gauche/0001- > fix-so-suffix.patch > > new file mode 100644 > > index 0000000..18d0bd5 > > --- /dev/null > > +++ b/package/gauche/0001-fix-so-suffix.patch > > @@ -0,0 +1,12 @@ > > The patch should contain a brief description about what it does or why > is needed, and also contain your SoB. Sorry, I forgot. > > +diff -ur a/configure b/configure > > +--- a/configure 2014-07-20 15:15:05.000000000 +0900 > > ++++ b/configure 2015-10-20 21:52:32.791442291 +0900 > > +@@ -6843,7 +6843,7 @@ > > + SHLIB_MAIN_LDFLAGS="" > > + SHLIB_OK=ok > > + ;; > > +- *-linux-gnu*|*-*-gnu*|*freebsd*|*dragonfly*) > > ++ *-linux-*|*-*-gnu*|*freebsd*|*dragonfly*) > > + SHLIB_SO_CFLAGS="-fPIC" > > + SHLIB_SO_LDFLAGS="$rpath -shared -o" > > + SHLIB_SO_SUFFIX="so" > > I have built gauche with this patch, and without it, and I don't see any > difference. Are you sure this is necessary? If so, why? Ok, as I wrote, it is for uclibc configuration. I will describe this comment in patch. > > diff --git a/package/gauche/Config.in b/package/gauche/Config.in > > new file mode 100644 > > index 0000000..ad61c3f > > --- /dev/null > > +++ b/package/gauche/Config.in > > @@ -0,0 +1,14 @@ > > +config BR2_PACKAGE_GAUCHE > > + bool "gauche" > > + depends on BR2_TOOLCHAIN_HAS_THREADS > > This is what the configure's help says: > > --enable-threads=TYPE Choose thread type. Possible values are: 'none' > for not using threads, 'pthreads' to use pthreads, and 'default' to > choose system's suitable one (if any). > > So it seems that having threads is optional. However, I have checked it, > and it fails if you don't have them: > > In file included from ./../gc/libatomic_ops/src/atomic_ops.h:218:0, > from lazy.c:78: > ./../gc/libatomic_ops/src/atomic_ops/sysdeps/generic_pthread.h:30:21: > fatal error: pthread.h: No such file or directory > #include <pthread.h> > > In fact, according to that output, maybe this package should also depend > on BR2_ARCH_HAS_ATOMICS. I haven't tested it. Could you? It doesn't fail > to build, but maybe it fails at runtime, I don't know. Thank you. Boechm gc (included in gauche tree needs atomic transaction, so I added this. > Moreover, BR2_TOOLCHAIN_HAS_THREADS is not enough. It needs to make sure > that you have native posix threads, otherwise it will fail like this: > > TARGETLIB=`pwd` /bin/sh ./makeverslink libgauche-0.9.so > TARGETLIB=`pwd` > /home/ldap/vriera/git-clones/buildroot-1/output/host/usr/bin/arm-buildroot-li > nux-uclibcgnueabi-gcc > -std=gnu99 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE > -D_FILE_OFFSET_BITS=64 -Os -fPIC -Wl,--rpath -Wl,`pwd` -L. -rdynamic > -o gosh main.o -lgauche-0.9 -ldl -lcrypt -lutil -lrt -lm -lpthread > ./libgauche-0.9.so: undefined reference to `pthread_spin_destroy' > ./libgauche-0.9.so: undefined reference to `pthread_attr_getstack' > ./libgauche-0.9.so: undefined reference to `pthread_spin_init' > ./libgauche-0.9.so: undefined reference to `pthread_spin_unlock' > ./libgauche-0.9.so: undefined reference to `pthread_getattr_np' > ./libgauche-0.9.so: undefined reference to `pthread_spin_lock' > > So you need: > > depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL Thank you! Changed. > > + depends on BR2_USE_MMU > > You need that because gauche uses fork(), so add " # fork()" at the end > of that line: > > depends on BR2_USE_MMU # fork() Ok. > > + help > > + Gauche is a Scheme scripting engine aiming at being a handy tool > > + that helps programmers and system administrators to write small > > These two lines exceed the 72 characters limit. You have to count every > tab as 8 characters, so your first line has 74 characters length, and > the second one has 73. The word "tool" should be in the second line, and > then, then word "small" should be in the third line. > > However, why not using the description in Gauche's homepage as is? Ok, I use it and keep 72 rule. > > + to large scripts quickly. > > + > > + http://practical-scheme.net/gauche/ > > + > > +comment "gauche needs a toolchain w/ threads" > > + depends on BR2_USE_MMU > > + depends on !BR2_TOOLCHAIN_HAS_THREADS > > Adjust this accordingly: > > comment "gauche needs a toolchain w/ NPTL" > depends on BR2_USE_MMU > depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL Ok. > > diff --git a/package/gauche/gauche.hash b/package/gauche/gauche.hash > > new file mode 100644 > > index 0000000..9d19671 > > --- /dev/null > > +++ b/package/gauche/gauche.hash > > @@ -0,0 +1,3 @@ > > +# Locally calculated > > +# > > This empty comment line is not need it. Please remove it. Ok. > > +GAUCHE_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -std=gnu99" > > Normally you wouldn't need this. The configure script checks for c99 > support in the compiler and adds that flag. However, this check fails > when you don't have support for wchar: > > 904 configure:3987: > /br/output/host/usr/bin/arm-buildroot-uclinux-uclibcgnueabi-g cc > -D_STDC_C99= -c -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE > -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static - std=gnu99 > -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 > conftest.c >&5 > 905 conftest.c:59:9: error: unknown type name 'wchar_t' > > I don't know if WCHAR is needed at runtime. It isn't at buildtime. So, > maybe depending on it just to make that configure check work would be > overkilling. If WCHAR is not needed at runtime, I'm fine with that > little hack. Perhaps a comment about that line explaining why is needed > would be a good idea. > > If at the end we decide to go with the CONF_ENV hack instead of making > this package depending on WCHAR, I would suggest you to put that line > after the GAUCHE_DEPENDENCIES one, with an empty line separating them. > This is just for aesthetic. Ok, at runtime, gauche do not need wchar. I added comment for describing this. ============================================================ Hiroshi Kawashima ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-23 13:17 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-10-21 13:35 [Buildroot] [PATCH v1 1/1] gauche: new package Hiroshi Kawashima 2015-10-22 13:00 ` Vicente Olivert Riera 2015-10-22 14:26 ` Arnout Vandecappelle 2015-10-22 14:37 ` Hiroshi Kawashima 2015-10-23 13:17 ` Hiroshi Kawashima
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.