From: Julien Grall <julien.grall@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Keir Fraser <keir@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] x86/mm: pod: Use the correct memory flags for alloc_domheap_page{, s}
Date: Thu, 22 Oct 2015 17:13:14 +0100 [thread overview]
Message-ID: <56290B1A.6030109@citrix.com> (raw)
In-Reply-To: <5629216C02000078000ADA46@prv-mh.provo.novell.com>
On 22/10/15 16:48, Jan Beulich wrote:
>>>> On 22.10.15 at 17:43, <julien.grall@citrix.com> wrote:
>> @@ -477,7 +477,7 @@ p2m_pod_offline_or_broken_replace(struct page_info *p)
>>
>> free_domheap_page(p);
>>
>> - p = alloc_domheap_page(d, PAGE_ORDER_4K);
>> + p = alloc_domheap_page(d, 0);
>
> I realize that this is the easiest fix, but I think here we instead want
> something like
It sounds sensible to me to re-allocate the page on the same numa node.
I will send another version of this patch. Although, I would appreciate
if someone can test it because I don't have any NUMA platform.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-10-22 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 15:43 [PATCH] x86/mm: pod: Use the correct memory flags for alloc_domheap_page{, s} Julien Grall
2015-10-22 15:48 ` Jan Beulich
2015-10-22 16:13 ` Julien Grall [this message]
2015-10-22 16:54 ` Dario Faggioli
2015-10-23 6:45 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56290B1A.6030109@citrix.com \
--to=julien.grall@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.