From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: of_mdiobus_register_phy() and deferred probe
Date: Thu, 22 Oct 2015 20:07:30 +0000 [thread overview]
Message-ID: <56294202.5020507@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdX+_0Cf0VwmKDtcfMNwaPEN5jvjZQUXg6MKMJa+cvYz3w@mail.gmail.com>
Hello.
On 10/22/2015 04:31 PM, Geert Uytterhoeven wrote:
> Due to a probe deferral of an interrupt controller[1], the Micrel
> Ethernet PHY on
> r8a7791/koelsch started failing to get its IRQ:
>
> no irq domain found for /interrupt-controller@e61c0000 !
>
> However, of_mdiobus_register_phy() uses irq_of_parse_and_map(), which plainly
> ignores EPROBE_DEFER, and it just continues.
>
> Later I get:
>
> sh-eth ee700000.ethernet eth0: attached PHY 1 (IRQ -1) to driver
> Micrel KSZ8041RNLI
>
> instead of
>
> sh-eth ee700000.ethernet eth0: attached PHY 1 (IRQ 408) to driver
> Micrel KSZ8041RNLI
>
> Ethernet still works, as the interrupt seems to be unneeded(?).
Yes, the phylib uses PHY polling anyway, IRQ isn't strictly necessary.
> Has anyone already looked into fixing of_mdio to handle deferred probing?
It's the first time I hear about that. Will have to look into this...
> Gr{oetje,eeting}s,
> Geert
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: of_mdiobus_register_phy() and deferred probe
Date: Thu, 22 Oct 2015 23:07:30 +0300 [thread overview]
Message-ID: <56294202.5020507@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdX+_0Cf0VwmKDtcfMNwaPEN5jvjZQUXg6MKMJa+cvYz3w@mail.gmail.com>
Hello.
On 10/22/2015 04:31 PM, Geert Uytterhoeven wrote:
> Due to a probe deferral of an interrupt controller[1], the Micrel
> Ethernet PHY on
> r8a7791/koelsch started failing to get its IRQ:
>
> no irq domain found for /interrupt-controller@e61c0000 !
>
> However, of_mdiobus_register_phy() uses irq_of_parse_and_map(), which plainly
> ignores EPROBE_DEFER, and it just continues.
>
> Later I get:
>
> sh-eth ee700000.ethernet eth0: attached PHY 1 (IRQ -1) to driver
> Micrel KSZ8041RNLI
>
> instead of
>
> sh-eth ee700000.ethernet eth0: attached PHY 1 (IRQ 408) to driver
> Micrel KSZ8041RNLI
>
> Ethernet still works, as the interrupt seems to be unneeded(?).
Yes, the phylib uses PHY polling anyway, IRQ isn't strictly necessary.
> Has anyone already looked into fixing of_mdio to handle deferred probing?
It's the first time I hear about that. Will have to look into this...
> Gr{oetje,eeting}s,
> Geert
MBR, Sergei
next prev parent reply other threads:[~2015-10-22 20:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 13:31 of_mdiobus_register_phy() and deferred probe Geert Uytterhoeven
2015-10-22 13:31 ` Geert Uytterhoeven
2015-10-22 20:07 ` Sergei Shtylyov [this message]
2015-10-22 20:07 ` Sergei Shtylyov
[not found] ` <56294202.5020507-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2015-10-23 7:38 ` Geert Uytterhoeven
2015-10-23 7:38 ` Geert Uytterhoeven
2015-10-23 7:38 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56294202.5020507@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.