Re: [PATCH][meta-multimedia] gst-plugins-good: fix depends to libgudev

[wenzong fan <wenzong.fan@windriver.com>]

On 10/22/2015 06:41 PM, Andreas Müller wrote:
> On Thu, Oct 22, 2015 at 11:47 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> This shouldn't be needed when:
>> http://lists.openembedded.org/pipermail/openembedded-core/2015-October/111271.html
>>
>> is merged.
>>
>> On Thu, Oct 22, 2015 at 7:21 AM, <wenzong.fan@windriver.com> wrote:
>>
>>> From: Wenzong Fan <wenzong.fan@windriver.com>
>>>
>>> * udev provides libgudev but it won't be built with systemd;
>>> * systemd provides udev but no libgudev, libgudev has been removed
>>>    from systemd and it's a independent project now; libgudev only be
>>>    built if systemd distro feature enabled.
>>>
>>> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
>>> ---
>>>   .../recipes-multimedia/gstreamer-0.10/gst-plugins-good_0.10.31.bb    | 5
>>> ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta-multimedia/recipes-multimedia/gstreamer-0.10/
>>> gst-plugins-good_0.10.31.bb
>>> b/meta-multimedia/recipes-multimedia/gstreamer-0.10/
>>> gst-plugins-good_0.10.31.bb
>>> index af18281..3f3478f 100644
>>> --- a/meta-multimedia/recipes-multimedia/gstreamer-0.10/
>>> gst-plugins-good_0.10.31.bb
>>> +++ b/meta-multimedia/recipes-multimedia/gstreamer-0.10/
>>> gst-plugins-good_0.10.31.bb
>>> @@ -11,12 +11,15 @@ PACKAGECONFIG ?= "jpeg v4l \
>>>       ${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio',
>>> '', d)} \
>>>       ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
>>>   "
>>> +
>>> +GUDEV="${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'libgudev',
>>> 'udev', d)}"
>>> +
>>>   PACKAGECONFIG[pulseaudio] = "--enable-pulse,--disable-pulse,pulseaudio"
>>>   PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack"
>>>   PACKAGECONFIG[jpeg] = "--enable-jpeg,--disable-jpeg,jpeg"
>>>   PACKAGECONFIG[wavpack] = "--enable-wavpack,--disable-wavpack,wavpack"
>>>   PACKAGECONFIG[gdkpixbuf] =
>>> "--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
>>> -PACKAGECONFIG[v4l] = "--enable-gst_v4l2 --with-gudev,--disable-gst_v4l2
>>> --without-gudev,udev"
> There should be a patch replacing udev by libgudev in the
> dependencies. No need for DISTRO_FEATURE magic here - this is done in
> udev/libgudev.

Thanks for your review, I'll send v2 patch that only change "udev -> 
libgudev".

Wenzong

>
> Andreas
>