* [PATCH][meta-multimedia] gst-plugins-good: fix depends to libgudev
@ 2015-10-22 5:21 wenzong.fan
2015-10-22 9:47 ` Martin Jansa
0 siblings, 1 reply; 4+ messages in thread
From: wenzong.fan @ 2015-10-22 5:21 UTC (permalink / raw)
To: openembedded-devel
From: Wenzong Fan <wenzong.fan@windriver.com>
* udev provides libgudev but it won't be built with systemd;
* systemd provides udev but no libgudev, libgudev has been removed
from systemd and it's a independent project now; libgudev only be
built if systemd distro feature enabled.
Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
---
.../recipes-multimedia/gstreamer-0.10/gst-plugins-good_0.10.31.bb | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/meta-multimedia/recipes-multimedia/gstreamer-0.10/gst-plugins-good_0.10.31.bb b/meta-multimedia/recipes-multimedia/gstreamer-0.10/gst-plugins-good_0.10.31.bb
index af18281..3f3478f 100644
--- a/meta-multimedia/recipes-multimedia/gstreamer-0.10/gst-plugins-good_0.10.31.bb
+++ b/meta-multimedia/recipes-multimedia/gstreamer-0.10/gst-plugins-good_0.10.31.bb
@@ -11,12 +11,15 @@ PACKAGECONFIG ?= "jpeg v4l \
${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
"
+
+GUDEV="${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'libgudev', 'udev', d)}"
+
PACKAGECONFIG[pulseaudio] = "--enable-pulse,--disable-pulse,pulseaudio"
PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack"
PACKAGECONFIG[jpeg] = "--enable-jpeg,--disable-jpeg,jpeg"
PACKAGECONFIG[wavpack] = "--enable-wavpack,--disable-wavpack,wavpack"
PACKAGECONFIG[gdkpixbuf] = "--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
-PACKAGECONFIG[v4l] = "--enable-gst_v4l2 --with-gudev,--disable-gst_v4l2 --without-gudev,udev"
+PACKAGECONFIG[v4l] = "--enable-gst_v4l2 --with-gudev,--disable-gst_v4l2 --without-gudev,${GUDEV}"
# sub-feature of v4l, but control separately since libv4l is not part of oe-core
PACKAGECONFIG[libv4l] = "--with-libv4l2,--without-libv4l2,libv4l"
PACKAGECONFIG[bzip2] = "--enable-bz2,--disable-bz2,bzip2"
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH][meta-multimedia] gst-plugins-good: fix depends to libgudev
2015-10-22 5:21 [PATCH][meta-multimedia] gst-plugins-good: fix depends to libgudev wenzong.fan
@ 2015-10-22 9:47 ` Martin Jansa
2015-10-22 10:41 ` Andreas Müller
0 siblings, 1 reply; 4+ messages in thread
From: Martin Jansa @ 2015-10-22 9:47 UTC (permalink / raw)
To: openembedded-devel
This shouldn't be needed when:
http://lists.openembedded.org/pipermail/openembedded-core/2015-October/111271.html
is merged.
On Thu, Oct 22, 2015 at 7:21 AM, <wenzong.fan@windriver.com> wrote:
> From: Wenzong Fan <wenzong.fan@windriver.com>
>
> * udev provides libgudev but it won't be built with systemd;
> * systemd provides udev but no libgudev, libgudev has been removed
> from systemd and it's a independent project now; libgudev only be
> built if systemd distro feature enabled.
>
> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
> ---
> .../recipes-multimedia/gstreamer-0.10/gst-plugins-good_0.10.31.bb | 5
> ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta-multimedia/recipes-multimedia/gstreamer-0.10/
> gst-plugins-good_0.10.31.bb
> b/meta-multimedia/recipes-multimedia/gstreamer-0.10/
> gst-plugins-good_0.10.31.bb
> index af18281..3f3478f 100644
> --- a/meta-multimedia/recipes-multimedia/gstreamer-0.10/
> gst-plugins-good_0.10.31.bb
> +++ b/meta-multimedia/recipes-multimedia/gstreamer-0.10/
> gst-plugins-good_0.10.31.bb
> @@ -11,12 +11,15 @@ PACKAGECONFIG ?= "jpeg v4l \
> ${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio',
> '', d)} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
> "
> +
> +GUDEV="${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'libgudev',
> 'udev', d)}"
> +
> PACKAGECONFIG[pulseaudio] = "--enable-pulse,--disable-pulse,pulseaudio"
> PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack"
> PACKAGECONFIG[jpeg] = "--enable-jpeg,--disable-jpeg,jpeg"
> PACKAGECONFIG[wavpack] = "--enable-wavpack,--disable-wavpack,wavpack"
> PACKAGECONFIG[gdkpixbuf] =
> "--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
> -PACKAGECONFIG[v4l] = "--enable-gst_v4l2 --with-gudev,--disable-gst_v4l2
> --without-gudev,udev"
> +PACKAGECONFIG[v4l] = "--enable-gst_v4l2 --with-gudev,--disable-gst_v4l2
> --without-gudev,${GUDEV}"
> # sub-feature of v4l, but control separately since libv4l is not part of
> oe-core
> PACKAGECONFIG[libv4l] = "--with-libv4l2,--without-libv4l2,libv4l"
> PACKAGECONFIG[bzip2] = "--enable-bz2,--disable-bz2,bzip2"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH][meta-multimedia] gst-plugins-good: fix depends to libgudev
2015-10-22 9:47 ` Martin Jansa
@ 2015-10-22 10:41 ` Andreas Müller
2015-10-23 10:30 ` wenzong fan
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Müller @ 2015-10-22 10:41 UTC (permalink / raw)
To: openembedded-devel@lists.openembedded.org
On Thu, Oct 22, 2015 at 11:47 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> This shouldn't be needed when:
> http://lists.openembedded.org/pipermail/openembedded-core/2015-October/111271.html
>
> is merged.
>
> On Thu, Oct 22, 2015 at 7:21 AM, <wenzong.fan@windriver.com> wrote:
>
>> From: Wenzong Fan <wenzong.fan@windriver.com>
>>
>> * udev provides libgudev but it won't be built with systemd;
>> * systemd provides udev but no libgudev, libgudev has been removed
>> from systemd and it's a independent project now; libgudev only be
>> built if systemd distro feature enabled.
>>
>> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
>> ---
>> .../recipes-multimedia/gstreamer-0.10/gst-plugins-good_0.10.31.bb | 5
>> ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-multimedia/recipes-multimedia/gstreamer-0.10/
>> gst-plugins-good_0.10.31.bb
>> b/meta-multimedia/recipes-multimedia/gstreamer-0.10/
>> gst-plugins-good_0.10.31.bb
>> index af18281..3f3478f 100644
>> --- a/meta-multimedia/recipes-multimedia/gstreamer-0.10/
>> gst-plugins-good_0.10.31.bb
>> +++ b/meta-multimedia/recipes-multimedia/gstreamer-0.10/
>> gst-plugins-good_0.10.31.bb
>> @@ -11,12 +11,15 @@ PACKAGECONFIG ?= "jpeg v4l \
>> ${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio',
>> '', d)} \
>> ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
>> "
>> +
>> +GUDEV="${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'libgudev',
>> 'udev', d)}"
>> +
>> PACKAGECONFIG[pulseaudio] = "--enable-pulse,--disable-pulse,pulseaudio"
>> PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack"
>> PACKAGECONFIG[jpeg] = "--enable-jpeg,--disable-jpeg,jpeg"
>> PACKAGECONFIG[wavpack] = "--enable-wavpack,--disable-wavpack,wavpack"
>> PACKAGECONFIG[gdkpixbuf] =
>> "--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
>> -PACKAGECONFIG[v4l] = "--enable-gst_v4l2 --with-gudev,--disable-gst_v4l2
>> --without-gudev,udev"
There should be a patch replacing udev by libgudev in the
dependencies. No need for DISTRO_FEATURE magic here - this is done in
udev/libgudev.
Andreas
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH][meta-multimedia] gst-plugins-good: fix depends to libgudev
2015-10-22 10:41 ` Andreas Müller
@ 2015-10-23 10:30 ` wenzong fan
0 siblings, 0 replies; 4+ messages in thread
From: wenzong fan @ 2015-10-23 10:30 UTC (permalink / raw)
To: openembedded-devel
On 10/22/2015 06:41 PM, Andreas Müller wrote:
> On Thu, Oct 22, 2015 at 11:47 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> This shouldn't be needed when:
>> http://lists.openembedded.org/pipermail/openembedded-core/2015-October/111271.html
>>
>> is merged.
>>
>> On Thu, Oct 22, 2015 at 7:21 AM, <wenzong.fan@windriver.com> wrote:
>>
>>> From: Wenzong Fan <wenzong.fan@windriver.com>
>>>
>>> * udev provides libgudev but it won't be built with systemd;
>>> * systemd provides udev but no libgudev, libgudev has been removed
>>> from systemd and it's a independent project now; libgudev only be
>>> built if systemd distro feature enabled.
>>>
>>> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
>>> ---
>>> .../recipes-multimedia/gstreamer-0.10/gst-plugins-good_0.10.31.bb | 5
>>> ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta-multimedia/recipes-multimedia/gstreamer-0.10/
>>> gst-plugins-good_0.10.31.bb
>>> b/meta-multimedia/recipes-multimedia/gstreamer-0.10/
>>> gst-plugins-good_0.10.31.bb
>>> index af18281..3f3478f 100644
>>> --- a/meta-multimedia/recipes-multimedia/gstreamer-0.10/
>>> gst-plugins-good_0.10.31.bb
>>> +++ b/meta-multimedia/recipes-multimedia/gstreamer-0.10/
>>> gst-plugins-good_0.10.31.bb
>>> @@ -11,12 +11,15 @@ PACKAGECONFIG ?= "jpeg v4l \
>>> ${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio',
>>> '', d)} \
>>> ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
>>> "
>>> +
>>> +GUDEV="${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'libgudev',
>>> 'udev', d)}"
>>> +
>>> PACKAGECONFIG[pulseaudio] = "--enable-pulse,--disable-pulse,pulseaudio"
>>> PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack"
>>> PACKAGECONFIG[jpeg] = "--enable-jpeg,--disable-jpeg,jpeg"
>>> PACKAGECONFIG[wavpack] = "--enable-wavpack,--disable-wavpack,wavpack"
>>> PACKAGECONFIG[gdkpixbuf] =
>>> "--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
>>> -PACKAGECONFIG[v4l] = "--enable-gst_v4l2 --with-gudev,--disable-gst_v4l2
>>> --without-gudev,udev"
> There should be a patch replacing udev by libgudev in the
> dependencies. No need for DISTRO_FEATURE magic here - this is done in
> udev/libgudev.
Thanks for your review, I'll send v2 patch that only change "udev ->
libgudev".
Wenzong
>
> Andreas
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-23 10:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-22 5:21 [PATCH][meta-multimedia] gst-plugins-good: fix depends to libgudev wenzong.fan
2015-10-22 9:47 ` Martin Jansa
2015-10-22 10:41 ` Andreas Müller
2015-10-23 10:30 ` wenzong fan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.