From: David Vrabel <david.vrabel@citrix.com>
To: Julien Grall <julien.grall@citrix.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, David Vrabel <david.vrabel@citrix.com>
Subject: Re: [Xen-devel] [PATCH] mm: hotplug: Don't release twice the resource on error
Date: Fri, 23 Oct 2015 14:45:36 +0100 [thread overview]
Message-ID: <562A3A00.60509@citrix.com> (raw)
In-Reply-To: <1445605053-23274-1-git-send-email-julien.grall@citrix.com>
On 23/10/15 13:57, Julien Grall wrote:
> The function add_memory_resource take in parameter a resource allocated
> by the caller. On error, both add_memory_resource and the caller will
> release the resource via release_memory_source.
[...]
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1298,7 +1298,6 @@ error:
> /* rollback pgdat allocation and others */
> if (new_pgdat)
> rollback_node_hotadd(nid, pgdat);
> - release_memory_resource(res);
> memblock_remove(start, size);
I've folded this in, thanks.
David
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: David Vrabel <david.vrabel@citrix.com>
To: Julien Grall <julien.grall@citrix.com>,
<xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>
Cc: <linux-mm@kvack.org>, David Vrabel <david.vrabel@citrix.com>
Subject: Re: [Xen-devel] [PATCH] mm: hotplug: Don't release twice the resource on error
Date: Fri, 23 Oct 2015 14:45:36 +0100 [thread overview]
Message-ID: <562A3A00.60509@citrix.com> (raw)
In-Reply-To: <1445605053-23274-1-git-send-email-julien.grall@citrix.com>
On 23/10/15 13:57, Julien Grall wrote:
> The function add_memory_resource take in parameter a resource allocated
> by the caller. On error, both add_memory_resource and the caller will
> release the resource via release_memory_source.
[...]
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1298,7 +1298,6 @@ error:
> /* rollback pgdat allocation and others */
> if (new_pgdat)
> rollback_node_hotadd(nid, pgdat);
> - release_memory_resource(res);
> memblock_remove(start, size);
I've folded this in, thanks.
David
next prev parent reply other threads:[~2015-10-23 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 12:57 [PATCH] mm: hotplug: Don't release twice the resource on error Julien Grall
2015-10-23 12:57 ` Julien Grall
2015-10-23 13:45 ` David Vrabel [this message]
2015-10-23 13:45 ` [Xen-devel] " David Vrabel
2015-10-23 13:45 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562A3A00.60509@citrix.com \
--to=david.vrabel@citrix.com \
--cc=julien.grall@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.