All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: kvm@vger.kernel.org, patches@linaro.org,
	linux-kernel@vger.kernel.org, alex.williamson@redhat.com,
	eric.auger@st.com, kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v3 3/7] vfio: platform: introduce module_vfio_reset_handler macro
Date: Fri, 23 Oct 2015 16:10:59 +0200	[thread overview]
Message-ID: <562A3FF3.5040004@linaro.org> (raw)
In-Reply-To: <3721718.lcvGuESNdi@wuerfel>

Hi Arnd,
On 10/23/2015 03:09 PM, Arnd Bergmann wrote:
> On Friday 23 October 2015 14:37:11 Eric Auger wrote:
>> +static int __init reset ## _module_init(void)                  \
>> +{                                                              \
>> +       vfio_platform_register_reset(compat, reset);            \
>> +       return 0;                                               \
>> +};                                                             \
>>
> 
> I would make this 'return vfio_platform_register_reset(...)', so loading
> the driver fails if the handler cannot get registered. Alternatively,
> change the return type of vfio_platform_register_reset to 'void'
> so it can never fail.
I will turn __vfio_platform_register_reset to 'void' then since it has
no reason to fail now.

Thanks

Eric

> 
> 	Arnd
> 

WARNING: multiple messages have this Message-ID (diff)
From: eric.auger@linaro.org (Eric Auger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/7] vfio: platform: introduce module_vfio_reset_handler macro
Date: Fri, 23 Oct 2015 16:10:59 +0200	[thread overview]
Message-ID: <562A3FF3.5040004@linaro.org> (raw)
In-Reply-To: <3721718.lcvGuESNdi@wuerfel>

Hi Arnd,
On 10/23/2015 03:09 PM, Arnd Bergmann wrote:
> On Friday 23 October 2015 14:37:11 Eric Auger wrote:
>> +static int __init reset ## _module_init(void)                  \
>> +{                                                              \
>> +       vfio_platform_register_reset(compat, reset);            \
>> +       return 0;                                               \
>> +};                                                             \
>>
> 
> I would make this 'return vfio_platform_register_reset(...)', so loading
> the driver fails if the handler cannot get registered. Alternatively,
> change the return type of vfio_platform_register_reset to 'void'
> so it can never fail.
I will turn __vfio_platform_register_reset to 'void' then since it has
no reason to fail now.

Thanks

Eric

> 
> 	Arnd
> 

WARNING: multiple messages have this Message-ID (diff)
From: Eric Auger <eric.auger@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: eric.auger@st.com, alex.williamson@redhat.com,
	b.reynal@virtualopensystems.com, kvmarm@lists.cs.columbia.edu,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	christoffer.dall@linaro.org, patches@linaro.org
Subject: Re: [PATCH v3 3/7] vfio: platform: introduce module_vfio_reset_handler macro
Date: Fri, 23 Oct 2015 16:10:59 +0200	[thread overview]
Message-ID: <562A3FF3.5040004@linaro.org> (raw)
In-Reply-To: <3721718.lcvGuESNdi@wuerfel>

Hi Arnd,
On 10/23/2015 03:09 PM, Arnd Bergmann wrote:
> On Friday 23 October 2015 14:37:11 Eric Auger wrote:
>> +static int __init reset ## _module_init(void)                  \
>> +{                                                              \
>> +       vfio_platform_register_reset(compat, reset);            \
>> +       return 0;                                               \
>> +};                                                             \
>>
> 
> I would make this 'return vfio_platform_register_reset(...)', so loading
> the driver fails if the handler cannot get registered. Alternatively,
> change the return type of vfio_platform_register_reset to 'void'
> so it can never fail.
I will turn __vfio_platform_register_reset to 'void' then since it has
no reason to fail now.

Thanks

Eric

> 
> 	Arnd
> 


  reply	other threads:[~2015-10-23 14:08 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 12:37 [PATCH v3 0/7] VFIO platform reset module rework Eric Auger
2015-10-23 12:37 ` Eric Auger
2015-10-23 12:37 ` Eric Auger
2015-10-23 12:37 ` [PATCH v3 1/7] vfio: platform: introduce vfio-platform-base module Eric Auger
2015-10-23 12:37   ` Eric Auger
2015-10-23 12:37   ` Eric Auger
2015-10-23 13:04   ` Arnd Bergmann
2015-10-23 13:04     ` Arnd Bergmann
2015-10-23 12:37 ` [PATCH v3 2/7] vfio: platform: add capability to register a reset function Eric Auger
2015-10-23 12:37   ` Eric Auger
2015-10-23 12:37   ` Eric Auger
2015-10-23 13:07   ` Arnd Bergmann
2015-10-23 13:07     ` Arnd Bergmann
2015-10-23 13:07     ` Arnd Bergmann
2015-10-23 14:15     ` Eric Auger
2015-10-23 14:15       ` Eric Auger
2015-10-23 14:15       ` Eric Auger
2015-10-23 12:37 ` [PATCH v3 3/7] vfio: platform: introduce module_vfio_reset_handler macro Eric Auger
2015-10-23 12:37   ` Eric Auger
2015-10-23 12:37   ` Eric Auger
2015-10-23 13:09   ` Arnd Bergmann
2015-10-23 13:09     ` Arnd Bergmann
2015-10-23 13:09     ` Arnd Bergmann
2015-10-23 14:10     ` Eric Auger [this message]
2015-10-23 14:10       ` Eric Auger
2015-10-23 14:10       ` Eric Auger
2015-10-23 12:37 ` [PATCH v3 4/7] vfio: platform: reset: calxedaxgmac: add reset function registration Eric Auger
2015-10-23 12:37   ` Eric Auger
2015-10-23 12:37   ` Eric Auger
2015-10-23 13:09   ` Arnd Bergmann
2015-10-23 13:09     ` Arnd Bergmann
2015-10-23 13:09     ` Arnd Bergmann
2015-10-23 12:37 ` [PATCH v3 5/7] vfio: platform: add compat in vfio_platform_device Eric Auger
2015-10-23 12:37   ` Eric Auger
2015-10-23 12:37 ` [PATCH v3 6/7] vfio: platform: use list of registered reset function Eric Auger
2015-10-23 12:37   ` Eric Auger
2015-10-23 12:37   ` Eric Auger
2015-10-23 13:12   ` Arnd Bergmann
2015-10-23 13:12     ` Arnd Bergmann
2015-10-23 14:11     ` Eric Auger
2015-10-23 14:11       ` Eric Auger
2015-10-23 14:23       ` Arnd Bergmann
2015-10-23 14:23         ` Arnd Bergmann
2015-10-23 15:15         ` Eric Auger
2015-10-23 15:15           ` Eric Auger
2015-10-23 15:15           ` Eric Auger
2015-10-23 12:37 ` [PATCH v3 7/7] vfio: platform: add dev_info on device reset Eric Auger
2015-10-23 12:37   ` Eric Auger
2015-10-23 12:37   ` Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562A3FF3.5040004@linaro.org \
    --to=eric.auger@linaro.org \
    --cc=alex.williamson@redhat.com \
    --cc=arnd@arndb.de \
    --cc=eric.auger@st.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.