From: Peter Hurley <peter@hurleysoftware.com>
To: Timur Tabi <timur@codeaurora.org>, Dave P Martin <Dave.Martin@arm.com>
Cc: Huang Shijie <shijie.huang@arm.com>,
gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Revert "serial: amba-pl011: fix incorrect integer size in pl011_fifo_to_tty()"
Date: Fri, 23 Oct 2015 13:49:06 -0400 [thread overview]
Message-ID: <562A7312.5030501@hurleysoftware.com> (raw)
In-Reply-To: <562A6296.3070600@codeaurora.org>
On 10/23/2015 12:38 PM, Timur Tabi wrote:
> On 10/23/2015 11:02 AM, Dave P Martin wrote:
>> I'm pretty sure CREAD should default to enabled[1], and that usually
>> software won't modify it.
>>
>> Assuming that this is indeed the problem, it's possible that another bug
>> in the pl011 driver is wrongly clearing this flag. Sadly I don't have
>> time to look at the code again just now ...:(
>
> Perhaps, but !CREAD is definitely broken without this patch. So if the driver really is clearing CREAD somewhere else, then that's where the real bug is.
>
>>
>> Could be interesting to stick some BUG_ON(!CREAD) in the driver to
>> try and track down where that's coming from.
>
> CREAD is disabled by default when opening the console. You need to explicitly set it in the termios structure.
No; the initial termios structure for all serial core-based drivers has
CREAD set:
pl011_probe
pl011_register_port
uart_register_driver
...
normal->init_termios.c_cflag = .... | CREAD | ....;
Regards,
Peter Hurley
WARNING: multiple messages have this Message-ID (diff)
From: peter@hurleysoftware.com (Peter Hurley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Revert "serial: amba-pl011: fix incorrect integer size in pl011_fifo_to_tty()"
Date: Fri, 23 Oct 2015 13:49:06 -0400 [thread overview]
Message-ID: <562A7312.5030501@hurleysoftware.com> (raw)
In-Reply-To: <562A6296.3070600@codeaurora.org>
On 10/23/2015 12:38 PM, Timur Tabi wrote:
> On 10/23/2015 11:02 AM, Dave P Martin wrote:
>> I'm pretty sure CREAD should default to enabled[1], and that usually
>> software won't modify it.
>>
>> Assuming that this is indeed the problem, it's possible that another bug
>> in the pl011 driver is wrongly clearing this flag. Sadly I don't have
>> time to look at the code again just now ...:(
>
> Perhaps, but !CREAD is definitely broken without this patch. So if the driver really is clearing CREAD somewhere else, then that's where the real bug is.
>
>>
>> Could be interesting to stick some BUG_ON(!CREAD) in the driver to
>> try and track down where that's coming from.
>
> CREAD is disabled by default when opening the console. You need to explicitly set it in the termios structure.
No; the initial termios structure for all serial core-based drivers has
CREAD set:
pl011_probe
pl011_register_port
uart_register_driver
...
normal->init_termios.c_cflag = .... | CREAD | ....;
Regards,
Peter Hurley
next prev parent reply other threads:[~2015-10-23 17:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 10:00 [PATCH] Revert "serial: amba-pl011: fix incorrect integer size in pl011_fifo_to_tty()" Huang Shijie
2015-10-23 10:00 ` Huang Shijie
2015-10-23 10:31 ` Dave Martin
2015-10-23 10:31 ` Dave Martin
2015-10-23 12:35 ` Timur Tabi
2015-10-23 12:35 ` Timur Tabi
2015-10-23 13:34 ` Dave P Martin
2015-10-23 13:34 ` Dave P Martin
2015-10-23 15:37 ` Timur Tabi
2015-10-23 15:37 ` Timur Tabi
2015-10-23 16:02 ` Dave P Martin
2015-10-23 16:02 ` Dave P Martin
2015-10-23 16:38 ` Timur Tabi
2015-10-23 16:38 ` Timur Tabi
2015-10-23 17:49 ` Peter Hurley [this message]
2015-10-23 17:49 ` Peter Hurley
2015-10-26 1:58 ` Huang Shijie
2015-10-26 1:58 ` Huang Shijie
2015-10-26 2:13 ` Huang Shijie
2015-10-26 2:13 ` Huang Shijie
2015-10-26 5:47 ` Huang Shijie
2015-10-26 5:47 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562A7312.5030501@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=Dave.Martin@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=shijie.huang@arm.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.