All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hanjun Guo <guohanjun@huawei.com>
To: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
	bhelgaas@google.com, rjw@rjwysocki.net, lenb@kernel.org,
	catalin.marinas@arm.com, will.deacon@arm.com
Cc: thomas.lendacky@amd.com, herbert@gondor.apana.org.au,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org,
	Murali Karicheri <m-karicheri2@ti.com>,
	hanjun.guo@linaro.org, davem@davemloft.net,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V4 7/8] PCI: OF: Move of_pci_dma_configure() to pci_dma_configure()
Date: Sat, 24 Oct 2015 15:44:44 +0800	[thread overview]
Message-ID: <562B36EC.3040406@huawei.com> (raw)
In-Reply-To: <1445442731-28819-8-git-send-email-Suravee.Suthikulpanit@amd.com>

Hi Suravee,

Some minor comments  below:

On 2015/10/21 23:52, Suravee Suthikulpanit wrote:
[...]
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index eea8b42..09264f8 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -6,12 +6,14 @@
>  #include <linux/delay.h>
>  #include <linux/init.h>
>  #include <linux/pci.h>
> -#include <linux/of_pci.h>
> +#include <linux/of_device.h>

Seems it's needed for GICv2m patch but not this one?

>  #include <linux/pci_hotplug.h>
>  #include <linux/slab.h>
>  #include <linux/module.h>
>  #include <linux/cpumask.h>
>  #include <linux/pci-aspm.h>
> +#include <linux/acpi.h>

I think acpi.h should be introduced by the next patch.

> +#include <linux/property.h>

And property.h is also not needed for this patch set.

Thanks
Hanjun

WARNING: multiple messages have this Message-ID (diff)
From: Hanjun Guo <guohanjun@huawei.com>
To: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
	<bhelgaas@google.com>, <rjw@rjwysocki.net>, <lenb@kernel.org>,
	<catalin.marinas@arm.com>, <will.deacon@arm.com>
Cc: <thomas.lendacky@amd.com>, <herbert@gondor.apana.org.au>,
	<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-acpi@vger.kernel.org>,
	Murali Karicheri <m-karicheri2@ti.com>, <hanjun.guo@linaro.org>,
	<davem@davemloft.net>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V4 7/8] PCI: OF: Move of_pci_dma_configure() to pci_dma_configure()
Date: Sat, 24 Oct 2015 15:44:44 +0800	[thread overview]
Message-ID: <562B36EC.3040406@huawei.com> (raw)
In-Reply-To: <1445442731-28819-8-git-send-email-Suravee.Suthikulpanit@amd.com>

Hi Suravee,

Some minor comments  below:

On 2015/10/21 23:52, Suravee Suthikulpanit wrote:
[...]
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index eea8b42..09264f8 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -6,12 +6,14 @@
>  #include <linux/delay.h>
>  #include <linux/init.h>
>  #include <linux/pci.h>
> -#include <linux/of_pci.h>
> +#include <linux/of_device.h>

Seems it's needed for GICv2m patch but not this one?

>  #include <linux/pci_hotplug.h>
>  #include <linux/slab.h>
>  #include <linux/module.h>
>  #include <linux/cpumask.h>
>  #include <linux/pci-aspm.h>
> +#include <linux/acpi.h>

I think acpi.h should be introduced by the next patch.

> +#include <linux/property.h>

And property.h is also not needed for this patch set.

Thanks
Hanjun


WARNING: multiple messages have this Message-ID (diff)
From: guohanjun@huawei.com (Hanjun Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 7/8] PCI: OF: Move of_pci_dma_configure() to pci_dma_configure()
Date: Sat, 24 Oct 2015 15:44:44 +0800	[thread overview]
Message-ID: <562B36EC.3040406@huawei.com> (raw)
In-Reply-To: <1445442731-28819-8-git-send-email-Suravee.Suthikulpanit@amd.com>

Hi Suravee,

Some minor comments  below:

On 2015/10/21 23:52, Suravee Suthikulpanit wrote:
[...]
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index eea8b42..09264f8 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -6,12 +6,14 @@
>  #include <linux/delay.h>
>  #include <linux/init.h>
>  #include <linux/pci.h>
> -#include <linux/of_pci.h>
> +#include <linux/of_device.h>

Seems it's needed for GICv2m patch but not this one?

>  #include <linux/pci_hotplug.h>
>  #include <linux/slab.h>
>  #include <linux/module.h>
>  #include <linux/cpumask.h>
>  #include <linux/pci-aspm.h>
> +#include <linux/acpi.h>

I think acpi.h should be introduced by the next patch.

> +#include <linux/property.h>

And property.h is also not needed for this patch set.

Thanks
Hanjun

  reply	other threads:[~2015-10-24  7:44 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 15:52 [PATCH V4 0/8] PCI: ACPI: Setting up DMA coherency for PCI device from _CCA attribute Suravee Suthikulpanit
2015-10-21 15:52 ` Suravee Suthikulpanit
2015-10-21 15:52 ` Suravee Suthikulpanit
2015-10-21 15:52 ` [PATCH V4 1/8] acpi: Honor ACPI _CCA attribute setting Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-27 14:41   ` Bjorn Helgaas
2015-10-27 14:41     ` Bjorn Helgaas
2015-10-21 15:52 ` [PATCH V4 2/8] device property: Introducing enum dev_dma_attr Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-21 15:52 ` [PATCH V4 3/8] acpi: Adding DMA Attribute APIs for ACPI Device Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-21 15:52 ` [PATCH V4 4/8] device property: Adding DMA Attribute APIs for Generic Devices Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-21 15:52 ` [PATCH V4 5/8] device property: acpi: Make use of the new DMA Attribute APIs Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-21 15:52 ` [PATCH V4 6/8] device property: acpi: Remove unused DMA APIs Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-21 15:52 ` [PATCH V4 7/8] PCI: OF: Move of_pci_dma_configure() to pci_dma_configure() Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-24  7:44   ` Hanjun Guo [this message]
2015-10-24  7:44     ` Hanjun Guo
2015-10-24  7:44     ` Hanjun Guo
2015-10-28 18:12     ` Suravee Suthikulpanit
2015-10-28 18:12       ` Suravee Suthikulpanit
2015-10-28 18:12       ` Suravee Suthikulpanit
2015-10-27 14:38   ` Bjorn Helgaas
2015-10-27 14:38     ` Bjorn Helgaas
2015-10-21 15:52 ` [PATCH V4 8/8] PCI: ACPI: Add support for PCI device DMA coherency Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-21 15:52   ` Suravee Suthikulpanit
2015-10-24  7:47   ` Hanjun Guo
2015-10-24  7:47     ` Hanjun Guo
2015-10-24  7:47     ` Hanjun Guo
2015-10-27 14:48   ` Bjorn Helgaas
2015-10-27 14:48     ` Bjorn Helgaas
2015-10-24  7:51 ` [PATCH V4 0/8] PCI: ACPI: Setting up DMA coherency for PCI device from _CCA attribute Hanjun Guo
2015-10-24  7:51   ` Hanjun Guo
2015-10-24  7:51   ` Hanjun Guo
2015-10-27 14:52 ` Bjorn Helgaas
2015-10-27 14:52   ` Bjorn Helgaas
2015-10-27 15:27   ` Rafael J. Wysocki
2015-10-27 15:27     ` Rafael J. Wysocki
2015-10-28 13:54     ` Hanjun Guo
2015-10-28 13:54       ` Hanjun Guo
2015-10-28 13:54       ` Hanjun Guo
2015-10-28 16:00       ` Rafael J. Wysocki
2015-10-28 16:00         ` Rafael J. Wysocki
2015-10-28 17:21         ` Suravee Suthikulpanit
2015-10-28 17:21           ` Suravee Suthikulpanit
2015-10-28 17:21           ` Suravee Suthikulpanit
2015-10-29  6:37         ` Hanjun Guo
2015-10-29  6:37           ` Hanjun Guo
2015-10-29  6:37           ` Hanjun Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562B36EC.3040406@huawei.com \
    --to=guohanjun@huawei.com \
    --cc=Suravee.Suthikulpanit@amd.com \
    --cc=bhelgaas@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=hanjun.guo@linaro.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=m-karicheri2@ti.com \
    --cc=rjw@rjwysocki.net \
    --cc=thomas.lendacky@amd.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.