All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: den@openvz.org, armbru@redhat.com, stefanha@redhat.com,
	peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH 3/9] trace: split trace_init_file out of trace_init_backends
Date: Mon, 26 Oct 2015 10:03:20 +0900	[thread overview]
Message-ID: <562D7BD8.3010106@de.ibm.com> (raw)
In-Reply-To: <1445779929-12237-4-git-send-email-pbonzini@redhat.com>

Am 25.10.2015 um 22:32 schrieb Paolo Bonzini:
> diff --git a/trace/control.h b/trace/control.h
> index bfbe560..d2506d4 100644
> --- a/trace/control.h
> +++ b/trace/control.h
> @@ -157,7 +157,7 @@ static void trace_event_set_state_dynamic(TraceEvent *ev, bool state);
>   *
>   * Returns: Whether the backends could be successfully initialized.
>   */
> -bool trace_init_backends(const char *file);
> +bool trace_init_backends(void);
> 
>  /**
>   * trace_init_events:

This (and the patch before) break qemu-io:


/home/cborntra/REPOS/qemu/qemu-io.c: In function 'main':
/home/cborntra/REPOS/qemu/qemu-io.c:443:18: error: too many arguments to function 'trace_init_backends'
             if (!trace_init_backends(optarg, NULL)) {
                  ^
In file included from /home/cborntra/REPOS/qemu/qemu-io.c:26:0:
/home/cborntra/REPOS/qemu/trace/control.h:160:6: note: declared here
 bool trace_init_backends(void);
      ^
/home/cborntra/REPOS/qemu/rules.mak:57: recipe for target 'qemu-io.o' failed


Christian

  reply	other threads:[~2015-10-26  1:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-25 13:32 [Qemu-devel] [PATCH 0/9] simplify usage of tracepoints, and connect them to logging Paolo Bonzini
2015-10-25 13:32 ` [Qemu-devel] [PATCH 1/9] trace: fix documentation Paolo Bonzini
2015-10-25 13:32 ` [Qemu-devel] [PATCH 2/9] trace: split trace_init_events out of trace_init_backends Paolo Bonzini
2015-10-25 13:32 ` [Qemu-devel] [PATCH 3/9] trace: split trace_init_file " Paolo Bonzini
2015-10-26  1:03   ` Christian Borntraeger [this message]
2015-10-25 13:32 ` [Qemu-devel] [PATCH 4/9] trace: add "-trace enable=..." Paolo Bonzini
2015-10-25 13:32 ` [Qemu-devel] [PATCH 5/9] trace: add "-trace help" Paolo Bonzini
2015-10-25 13:35 ` [Qemu-devel] [PATCH 6/9] log: do not unnecessarily include qom/cpu.h Paolo Bonzini
2015-10-25 13:35 ` [Qemu-devel] [PATCH 7/9] trace: convert stderr backend to log Paolo Bonzini
2015-10-25 13:35 ` [Qemu-devel] [PATCH 8/9] trace: switch default backend to "log" Paolo Bonzini
2015-10-25 13:35 ` [Qemu-devel] [PATCH 9/9] log: add "-d trace:PATTERN" Paolo Bonzini
2015-10-25 13:57 ` [Qemu-devel] [PATCH 0/9] simplify usage of tracepoints, and connect them to logging Peter Maydell
2015-10-25 14:39   ` Paolo Bonzini
2015-10-26  1:16 ` Christian Borntraeger
2015-10-26  1:28 ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562D7BD8.3010106@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.