All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next 0/4] Automatic adjustment of max frame size
Date: Mon, 26 Oct 2015 10:09:46 +0900	[thread overview]
Message-ID: <562D7D5A.6050400@lab.ntt.co.jp> (raw)
In-Reply-To: <20151023044604.GA5024@aiaiai.jf.intel.com>

On 2015/10/23 13:46, ND Linux CI Server wrote:
...
> checkpatch.pl has some complaints:
> 
> --------------------------------------------------------------------------------
> 
> checkpatch.pl results for patch "[PATCH 2/4] e1000e: Add ndo_enc_hdr_len"
> 
> WARNING:LONG_LINE: line over 80 characters
> #53: FILE: drivers/net/ethernet/intel/e1000e/netdev.c:3981:
> +		if (adapter->max_frame_size > VLAN_ETH_FRAME_LEN + ETH_FCS_LEN) {
> 
> WARNING:LONG_LINE: line over 80 characters
> #62: FILE: drivers/net/ethernet/intel/e1000e/netdev.c:4000:
> +		if (adapter->max_frame_size > VLAN_ETH_FRAME_LEN + ETH_FCS_LEN) {
> 
> WARNING:LONG_LINE: line over 80 characters
> #71: FILE: drivers/net/ethernet/intel/e1000e/netdev.c:4014:
> +		if (adapter->max_frame_size <= VLAN_ETH_FRAME_LEN + ETH_FCS_LEN) {
> 
> total: 0 errors, 3 warnings, 0 checks, 184 lines checked

I was aware of these warnings but my understanding was that lines
without over 80 characters are not mandatory requirement and a short
overrun can be acceptable, like 81 or 82... Not sure what made me think
so, though.

Anyway, I will fix these warnings.

Thanks,
Toshiaki Makita


WARNING: multiple messages have this Message-ID (diff)
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: "David S . Miller" <davem@davemloft.net>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
	netdev@vger.kernel.org, Vlad Yasevich <vyasevich@gmail.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	intel-wired-lan@lists.osuosl.org,
	Patrick McHardy <kaber@trash.net>
Subject: Re: [Intel-wired-lan] [PATCH net-next 0/4] Automatic adjustment of max frame size
Date: Mon, 26 Oct 2015 10:09:46 +0900	[thread overview]
Message-ID: <562D7D5A.6050400@lab.ntt.co.jp> (raw)
In-Reply-To: <20151023044604.GA5024@aiaiai.jf.intel.com>

On 2015/10/23 13:46, ND Linux CI Server wrote:
...
> checkpatch.pl has some complaints:
> 
> --------------------------------------------------------------------------------
> 
> checkpatch.pl results for patch "[PATCH 2/4] e1000e: Add ndo_enc_hdr_len"
> 
> WARNING:LONG_LINE: line over 80 characters
> #53: FILE: drivers/net/ethernet/intel/e1000e/netdev.c:3981:
> +		if (adapter->max_frame_size > VLAN_ETH_FRAME_LEN + ETH_FCS_LEN) {
> 
> WARNING:LONG_LINE: line over 80 characters
> #62: FILE: drivers/net/ethernet/intel/e1000e/netdev.c:4000:
> +		if (adapter->max_frame_size > VLAN_ETH_FRAME_LEN + ETH_FCS_LEN) {
> 
> WARNING:LONG_LINE: line over 80 characters
> #71: FILE: drivers/net/ethernet/intel/e1000e/netdev.c:4014:
> +		if (adapter->max_frame_size <= VLAN_ETH_FRAME_LEN + ETH_FCS_LEN) {
> 
> total: 0 errors, 3 warnings, 0 checks, 184 lines checked

I was aware of these warnings but my understanding was that lines
without over 80 characters are not mandatory requirement and a short
overrun can be acceptable, like 81 or 82... Not sure what made me think
so, though.

Anyway, I will fix these warnings.

Thanks,
Toshiaki Makita

       reply	other threads:[~2015-10-26  1:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20151023044604.GA5024@aiaiai.jf.intel.com>
2015-10-26  1:09 ` Toshiaki Makita [this message]
2015-10-26  1:09   ` [Intel-wired-lan] [PATCH net-next 0/4] Automatic adjustment of max frame size Toshiaki Makita
2015-10-23  3:49 Toshiaki Makita
2015-10-24  8:50 ` Toshiaki Makita
2015-10-26  0:56   ` Toshiaki Makita
2015-10-26 20:50     ` Keller, Jacob E
2015-10-27  0:40       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562D7D5A.6050400@lab.ntt.co.jp \
    --to=makita.toshiaki@lab.ntt.co.jp \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.