From: mmarek@suse.com (Michal Marek)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree
Date: Mon, 26 Oct 2015 22:32:19 +0100 [thread overview]
Message-ID: <562E9BE3.5080004@suse.com> (raw)
In-Reply-To: <56236C9A.8060906@users.sourceforge.net>
Dne 18.10.2015 v 11:55 SF Markus Elfring napsal(a):
>> Remove removal and re-addition of freeing functions.
>
> I find such a wording confusing for a commit message.
It is also a bit confusing to use the same subject for two patches in a
series. How about
[PATCH 1/2] coccinelle: ifnullfree: Adjust tests to compare against NULL
[PATCH 2/2] coccinelle: ifnullfree: handle various destroy functions
?
Michal
WARNING: multiple messages have this Message-ID (diff)
From: Michal Marek <mmarek@suse.com>
To: cocci@systeme.lip6.fr
Subject: Re: [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree
Date: Mon, 26 Oct 2015 21:32:19 +0000 [thread overview]
Message-ID: <562E9BE3.5080004@suse.com> (raw)
In-Reply-To: <56236C9A.8060906@users.sourceforge.net>
Dne 18.10.2015 v 11:55 SF Markus Elfring napsal(a):
>> Remove removal and re-addition of freeing functions.
>
> I find such a wording confusing for a commit message.
It is also a bit confusing to use the same subject for two patches in a
series. How about
[PATCH 1/2] coccinelle: ifnullfree: Adjust tests to compare against NULL
[PATCH 2/2] coccinelle: ifnullfree: handle various destroy functions
?
Michal
WARNING: multiple messages have this Message-ID (diff)
From: Michal Marek <mmarek@suse.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Fabian Frederick <fabf@skynet.be>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree
Date: Mon, 26 Oct 2015 22:32:19 +0100 [thread overview]
Message-ID: <562E9BE3.5080004@suse.com> (raw)
In-Reply-To: <56236C9A.8060906@users.sourceforge.net>
Dne 18.10.2015 v 11:55 SF Markus Elfring napsal(a):
>> Remove removal and re-addition of freeing functions.
>
> I find such a wording confusing for a commit message.
It is also a bit confusing to use the same subject for two patches in a
series. How about
[PATCH 1/2] coccinelle: ifnullfree: Adjust tests to compare against NULL
[PATCH 2/2] coccinelle: ifnullfree: handle various destroy functions
?
Michal
next prev parent reply other threads:[~2015-10-26 21:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 17:23 [Cocci] [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree Julia Lawall
2015-10-17 17:23 ` Julia Lawall
2015-10-17 17:23 ` Julia Lawall
2015-10-18 9:55 ` [Cocci] " SF Markus Elfring
2015-10-18 9:55 ` SF Markus Elfring
2015-10-18 9:55 ` SF Markus Elfring
2015-10-26 21:32 ` Michal Marek [this message]
2015-10-26 21:32 ` Michal Marek
2015-10-26 21:32 ` Michal Marek
2015-10-26 21:36 ` [Cocci] " Julia Lawall
2015-10-26 21:36 ` Julia Lawall
2015-10-26 21:36 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562E9BE3.5080004@suse.com \
--to=mmarek@suse.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.