From: Jeremy Linton <jeremy.linton-5wv7dgnIgG8@public.gmane.org>
To: Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
catalin.marinas-5wv7dgnIgG8@public.gmane.org,
will.deacon-5wv7dgnIgG8@public.gmane.org,
leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Cc: ryabinin.a.a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper
Date: Mon, 26 Oct 2015 17:33:06 -0500 [thread overview]
Message-ID: <562EAA22.3010905@arm.com> (raw)
In-Reply-To: <562EA894.8070505-5wv7dgnIgG8@public.gmane.org>
On 10/26/2015 05:26 PM, Jeremy Linton wrote:
> On 10/08/2015 02:02 PM, Ard Biesheuvel wrote:
>> Since arm64 does not use a builtin decompressor, the EFI stub is built
>> into the kernel proper. So far, this has been working fine, but actually,
>> since the stub is in fact a PE/COFF relocatable binary that is executed
>> at an unknown offset in the 1:1 mapping provided by the UEFI firmware, we
>> should not be seamlessly sharing code with the kernel proper, which is a
>> position dependent executable linked at a high virtual offset.
>
> This patch appears to be causing a build break
>
> STUBCPY drivers/firmware/efi/libstub/lib-sort.stub.o
> 0000000000000000 R_AARCH64_ABS64 __efistub___crc_sort
> drivers/firmware/efi/libstub/lib-sort.stub.o: absolute symbol references
> not allowed in the EFI stub
>
> __kcrctab_sort:
> .xword __crc_sort
> .weak __crc_sort
> .text
>
>
> Which is the EXPORT_SYMBOL() in sort.c combined with !CONFIG_MODVERSIONS.
Sorry, I that should be CONFIG_MODVERSIONS..
WARNING: multiple messages have this Message-ID (diff)
From: jeremy.linton@arm.com (Jeremy Linton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper
Date: Mon, 26 Oct 2015 17:33:06 -0500 [thread overview]
Message-ID: <562EAA22.3010905@arm.com> (raw)
In-Reply-To: <562EA894.8070505@arm.com>
On 10/26/2015 05:26 PM, Jeremy Linton wrote:
> On 10/08/2015 02:02 PM, Ard Biesheuvel wrote:
>> Since arm64 does not use a builtin decompressor, the EFI stub is built
>> into the kernel proper. So far, this has been working fine, but actually,
>> since the stub is in fact a PE/COFF relocatable binary that is executed
>> at an unknown offset in the 1:1 mapping provided by the UEFI firmware, we
>> should not be seamlessly sharing code with the kernel proper, which is a
>> position dependent executable linked at a high virtual offset.
>
> This patch appears to be causing a build break
>
> STUBCPY drivers/firmware/efi/libstub/lib-sort.stub.o
> 0000000000000000 R_AARCH64_ABS64 __efistub___crc_sort
> drivers/firmware/efi/libstub/lib-sort.stub.o: absolute symbol references
> not allowed in the EFI stub
>
> __kcrctab_sort:
> .xword __crc_sort
> .weak __crc_sort
> .text
>
>
> Which is the EXPORT_SYMBOL() in sort.c combined with !CONFIG_MODVERSIONS.
Sorry, I that should be CONFIG_MODVERSIONS..
next prev parent reply other threads:[~2015-10-26 22:33 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 19:02 [PATCH v4 0/3] arm64: EFI stub isolation Ard Biesheuvel
2015-10-08 19:02 ` Ard Biesheuvel
[not found] ` <1444330924-17830-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-10-08 19:02 ` [PATCH v4 1/3] arm64/efi: remove /chosen/linux,uefi-stub-kern-ver DT property Ard Biesheuvel
2015-10-08 19:02 ` [PATCH v4 1/3] arm64/efi: remove /chosen/linux, uefi-stub-kern-ver " Ard Biesheuvel
[not found] ` <1444330924-17830-2-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-10-10 22:31 ` [PATCH v4 1/3] arm64/efi: remove /chosen/linux,uefi-stub-kern-ver " Matt Fleming
2015-10-10 22:31 ` Matt Fleming
2015-10-08 19:02 ` [PATCH v4 2/3] arm64: use ENDPIPROC() to annotate position independent assembler routines Ard Biesheuvel
2015-10-08 19:02 ` Ard Biesheuvel
2015-10-08 19:02 ` [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper Ard Biesheuvel
2015-10-08 19:02 ` Ard Biesheuvel
[not found] ` <1444330924-17830-4-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-10-09 8:12 ` Andrey Ryabinin
2015-10-09 8:12 ` Andrey Ryabinin
[not found] ` <CAPAsAGz7Tp6Z87tPq_NNh_mcwPF_DOaXzu0po5f6AQxPAcsALQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-09 9:10 ` Will Deacon
2015-10-09 9:10 ` Will Deacon
2015-10-09 9:40 ` Andrey Ryabinin
2015-10-09 9:40 ` Andrey Ryabinin
[not found] ` <CAPAsAGzgqOZVdTfpBGADAhZjOJTCqdB1Paq-14vk-_1hu4DCyw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-09 9:43 ` Will Deacon
2015-10-09 9:43 ` Will Deacon
[not found] ` <20151009094324.GE26278-5wv7dgnIgG8@public.gmane.org>
2015-10-09 9:48 ` Andrey Ryabinin
2015-10-09 9:48 ` Andrey Ryabinin
2015-10-10 22:40 ` Matt Fleming
2015-10-10 22:40 ` Matt Fleming
2015-10-26 22:26 ` Jeremy Linton
2015-10-26 22:26 ` Jeremy Linton
[not found] ` <562EA894.8070505-5wv7dgnIgG8@public.gmane.org>
2015-10-26 22:33 ` Jeremy Linton [this message]
2015-10-26 22:33 ` Jeremy Linton
[not found] ` <562EAA22.3010905-5wv7dgnIgG8@public.gmane.org>
2015-10-27 2:20 ` Ard Biesheuvel
2015-10-27 2:20 ` Ard Biesheuvel
[not found] ` <CAKv+Gu-G1YS9Ha=-rtnPKJTOxBTrdSq6=Tqwq_GPW742JUE+2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-27 14:44 ` Jeremy Linton
2015-10-27 14:44 ` Jeremy Linton
[not found] ` <562F8DCE.4010308-5wv7dgnIgG8@public.gmane.org>
2015-10-30 12:17 ` Ard Biesheuvel
2015-10-30 12:17 ` Ard Biesheuvel
[not found] ` <CAKv+Gu-m7dJbiF=8i=+cN=bx+y8AKu_MgHrS29jNK0fTvuwQ5Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-30 14:35 ` Mark Rutland
2015-10-30 14:35 ` Mark Rutland
2015-10-30 16:01 ` Catalin Marinas
2015-10-30 16:01 ` Catalin Marinas
2015-11-02 12:49 ` Matt Fleming
2015-11-02 12:49 ` Matt Fleming
2015-11-24 9:34 ` Robert Richter
2015-11-24 9:34 ` Robert Richter
[not found] ` <20151124093438.GA31343-vWBEXY7mpu582hYKe6nXyg@public.gmane.org>
2015-11-24 9:38 ` Ard Biesheuvel
2015-11-24 9:38 ` Ard Biesheuvel
2015-10-10 22:40 ` [PATCH v4 0/3] arm64: EFI stub isolation Matt Fleming
2015-10-10 22:40 ` Matt Fleming
[not found] ` <20151010224051.GK2723-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-10-12 15:30 ` Catalin Marinas
2015-10-12 15:30 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562EAA22.3010905@arm.com \
--to=jeremy.linton-5wv7dgnigg8@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=ryabinin.a.a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.