From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] clocksource: dw_apb_timer_of: support timer-based delay
Date: Tue, 27 Oct 2015 01:41:53 +0100 [thread overview]
Message-ID: <562EC851.3080500@linaro.org> (raw)
In-Reply-To: <1445328672-581-1-git-send-email-jszhang@marvell.com>
On 10/20/2015 10:11 AM, Jisheng Zhang wrote:
> Implement an ARM delay timer to be used for udelay(). This allows us to
> skip the delay loop calibration at boot on Marvell BG2, BG2Q, BG2CD
> platforms. And after this patch, udelay() will be unaffected by CPU
> frequency changes.
>
> But, this driver is not only used on ARM platforms, so I dunno how to
> handle other platforms which don't have the register_current_timer_delay
> That's the reason I mark this patch as RFC.
>
> Any suggestions are appreciated.
hmm, may be a dt-binding makes sense...
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/clocksource/dw_apb_timer_of.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/clocksource/dw_apb_timer_of.c b/drivers/clocksource/dw_apb_timer_of.c
> index a19a3f6..09dbf9c 100644
> --- a/drivers/clocksource/dw_apb_timer_of.c
> +++ b/drivers/clocksource/dw_apb_timer_of.c
> @@ -16,6 +16,7 @@
> * You should have received a copy of the GNU General Public License
> * along with this program. If not, see <http://www.gnu.org/licenses/>.
> */
> +#include <linux/delay.h>
> #include <linux/dw_apb_timer.h>
> #include <linux/of.h>
> #include <linux/of_address.h>
> @@ -130,6 +131,15 @@ static void __init init_sched_clock(void)
> sched_clock_register(read_sched_clock, 32, sched_rate);
> }
>
> +static unsigned long dw_apb_delay_timer_read(void)
> +{
> + return ~readl_relaxed(sched_io_base);
> +}
> +
> +static struct delay_timer dw_apb_delay_timer = {
> + .read_current_timer = dw_apb_delay_timer_read,
> +};
> +
> static int num_called;
> static void __init dw_apb_timer_init(struct device_node *timer)
> {
> @@ -142,6 +152,8 @@ static void __init dw_apb_timer_init(struct device_node *timer)
> pr_debug("%s: found clocksource timer\n", __func__);
> add_clocksource(timer);
> init_sched_clock();
> + dw_apb_delay_timer.freq = sched_rate;
> + register_current_timer_delay(&dw_apb_delay_timer);
> break;
> default:
> break;
>
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Jisheng Zhang <jszhang@marvell.com>, tglx@linutronix.de
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] clocksource: dw_apb_timer_of: support timer-based delay
Date: Tue, 27 Oct 2015 01:41:53 +0100 [thread overview]
Message-ID: <562EC851.3080500@linaro.org> (raw)
In-Reply-To: <1445328672-581-1-git-send-email-jszhang@marvell.com>
On 10/20/2015 10:11 AM, Jisheng Zhang wrote:
> Implement an ARM delay timer to be used for udelay(). This allows us to
> skip the delay loop calibration at boot on Marvell BG2, BG2Q, BG2CD
> platforms. And after this patch, udelay() will be unaffected by CPU
> frequency changes.
>
> But, this driver is not only used on ARM platforms, so I dunno how to
> handle other platforms which don't have the register_current_timer_delay
> That's the reason I mark this patch as RFC.
>
> Any suggestions are appreciated.
hmm, may be a dt-binding makes sense...
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/clocksource/dw_apb_timer_of.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/clocksource/dw_apb_timer_of.c b/drivers/clocksource/dw_apb_timer_of.c
> index a19a3f6..09dbf9c 100644
> --- a/drivers/clocksource/dw_apb_timer_of.c
> +++ b/drivers/clocksource/dw_apb_timer_of.c
> @@ -16,6 +16,7 @@
> * You should have received a copy of the GNU General Public License
> * along with this program. If not, see <http://www.gnu.org/licenses/>.
> */
> +#include <linux/delay.h>
> #include <linux/dw_apb_timer.h>
> #include <linux/of.h>
> #include <linux/of_address.h>
> @@ -130,6 +131,15 @@ static void __init init_sched_clock(void)
> sched_clock_register(read_sched_clock, 32, sched_rate);
> }
>
> +static unsigned long dw_apb_delay_timer_read(void)
> +{
> + return ~readl_relaxed(sched_io_base);
> +}
> +
> +static struct delay_timer dw_apb_delay_timer = {
> + .read_current_timer = dw_apb_delay_timer_read,
> +};
> +
> static int num_called;
> static void __init dw_apb_timer_init(struct device_node *timer)
> {
> @@ -142,6 +152,8 @@ static void __init dw_apb_timer_init(struct device_node *timer)
> pr_debug("%s: found clocksource timer\n", __func__);
> add_clocksource(timer);
> init_sched_clock();
> + dw_apb_delay_timer.freq = sched_rate;
> + register_current_timer_delay(&dw_apb_delay_timer);
> break;
> default:
> break;
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-10-27 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 8:11 [RFC PATCH] clocksource: dw_apb_timer_of: support timer-based delay Jisheng Zhang
2015-10-20 8:11 ` Jisheng Zhang
2015-10-27 0:41 ` Daniel Lezcano [this message]
2015-10-27 0:41 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562EC851.3080500@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.