From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Dario Faggioli <dario.faggioli@citrix.com>,
Tim Deegan <tim@xen.org>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH 0/6] Remove some usage of shadow variable
Date: Tue, 27 Oct 2015 16:12:46 +0000 [thread overview]
Message-ID: <562FA27E.1030906@citrix.com> (raw)
In-Reply-To: <1445960359-17217-1-git-send-email-julien.grall@citrix.com>
On 27/10/15 15:39, Julien Grall wrote:
> Hi all,
>
> I wrote this patch series after noticing that one of my series [1] was
> shadowing a variable and GCC didn't warn it.
>
> So I've turned on -Wshadow and look at if there is other places abusing
> of shadow variable in Xen.
>
> This series is not complete and only contain the more simple changes.
>
> I'd like to have some input to know whether turning on -Wshadow would be
> sensible in the future.
>
> Regards,
All 6 patches Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
As for the -Wshadow default, that is more problematic. There are
several quite buggy verisons of GCC wrt shadowing, so I don't think it
is sensible to enable unilaterally.
~Andrew
next prev parent reply other threads:[~2015-10-27 16:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 15:39 [PATCH 0/6] Remove some usage of shadow variable Julien Grall
2015-10-27 15:39 ` [PATCH 1/6] xen/arm: domain_build: Avoid to shadow the variable "mod" in write_properties Julien Grall
2015-11-03 17:01 ` Ian Campbell
2015-10-27 15:39 ` [PATCH 2/6] xen/common: domain: Avoid to shadow the variable "d" in do_vcpu_op Julien Grall
2015-10-27 15:39 ` [PATCH 3/6] xen/common: grant_table: Avoid to shadow "frame" in __gnttab_map_grant_ref Julien Grall
2015-10-27 16:22 ` Jan Beulich
2015-10-27 15:39 ` [PATCH 4/6] xen/common: memory: Avoid to shadow the variable "d" in do_memory_op Julien Grall
2015-10-27 16:25 ` Jan Beulich
2015-10-27 16:51 ` Julien Grall
2015-10-27 15:39 ` [PATCH 5/6] xen/common: sched: Avoid to shadow the variable "cur" in runq_tickle Julien Grall
2015-10-27 15:59 ` Dario Faggioli
2015-10-27 16:27 ` Jan Beulich
2015-10-27 17:00 ` Julien Grall
2015-10-27 15:39 ` [PATCH 6/6] xen/common: sched-rt: Avoid to shadow the variable "svc" in rt_dom_cntl Julien Grall
2015-10-27 16:17 ` Dario Faggioli
2015-10-27 16:03 ` [PATCH 0/6] Remove some usage of shadow variable Jan Beulich
2015-10-27 17:41 ` George Dunlap
2015-10-28 8:53 ` Jan Beulich
2015-10-28 9:10 ` Julien Grall
2015-10-28 9:27 ` Jan Beulich
2015-10-28 9:12 ` Juergen Gross
2015-10-28 9:31 ` Jan Beulich
2015-10-28 9:44 ` Juergen Gross
2015-10-28 10:50 ` George Dunlap
2015-10-28 11:50 ` Jan Beulich
2015-10-27 16:12 ` Andrew Cooper [this message]
2015-10-27 17:39 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562FA27E.1030906@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.