From: brijeshkumar.singh@amd.com (Brijesh Singh)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] EDAC: Add ARM64 EDAC
Date: Tue, 27 Oct 2015 15:01:59 -0500 [thread overview]
Message-ID: <562FD837.50505@amd.com> (raw)
In-Reply-To: <20151027190832.GN19782@codeaurora.org>
Thanks for review Steve.
On 10/27/2015 02:08 PM, Stephen Boyd wrote:
>> +config EDAC_CORTEX_ARM64
>> + tristate "ARM Cortex A57/A53"
>> + depends on EDAC_MM_EDAC && ARM64
>> + default n
>
> n is the default so this can be removed.
>
noted
>> + .driver = {
>> + .name = DRV_NAME,
>> + .owner = THIS_MODULE,
>
> This line can be removed. THIS_MODULE is assigned by
> platform_driver_register().
noted.
>
>> + .of_match_table = cortex_arm64_edac_of_match,
>> + },
>> +};
>> +
>> +static int __init cortex_arm64_edac_init(void)
>> +{
>> + return platform_driver_register(&cortex_arm64_edac_driver);
>> +}
>> +module_init(cortex_arm64_edac_init);
>> +
>> +static void __exit cortex_arm64_edac_exit(void)
>> +{
>> + platform_driver_unregister(&cortex_arm64_edac_driver);
>> +}
>> +module_exit(cortex_arm64_edac_exit);
>
> This can be module_platform_driver(cortex_arm64_edac_driver) now.
>
noted.
-Brijesh
WARNING: multiple messages have this Message-ID (diff)
From: Brijesh Singh <brijeshkumar.singh-5C7GfCeVMHo@public.gmane.org>
To: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: brijeshkumar.singh-5C7GfCeVMHo@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org,
mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
andre.przywara-5wv7dgnIgG8@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3] EDAC: Add ARM64 EDAC
Date: Tue, 27 Oct 2015 15:01:59 -0500 [thread overview]
Message-ID: <562FD837.50505@amd.com> (raw)
In-Reply-To: <20151027190832.GN19782-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Thanks for review Steve.
On 10/27/2015 02:08 PM, Stephen Boyd wrote:
>> +config EDAC_CORTEX_ARM64
>> + tristate "ARM Cortex A57/A53"
>> + depends on EDAC_MM_EDAC && ARM64
>> + default n
>
> n is the default so this can be removed.
>
noted
>> + .driver = {
>> + .name = DRV_NAME,
>> + .owner = THIS_MODULE,
>
> This line can be removed. THIS_MODULE is assigned by
> platform_driver_register().
noted.
>
>> + .of_match_table = cortex_arm64_edac_of_match,
>> + },
>> +};
>> +
>> +static int __init cortex_arm64_edac_init(void)
>> +{
>> + return platform_driver_register(&cortex_arm64_edac_driver);
>> +}
>> +module_init(cortex_arm64_edac_init);
>> +
>> +static void __exit cortex_arm64_edac_exit(void)
>> +{
>> + platform_driver_unregister(&cortex_arm64_edac_driver);
>> +}
>> +module_exit(cortex_arm64_edac_exit);
>
> This can be module_platform_driver(cortex_arm64_edac_driver) now.
>
noted.
-Brijesh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Brijesh Singh <brijeshkumar.singh@amd.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: <brijeshkumar.singh@amd.com>,
<linux-arm-kernel@lists.infradead.org>, <robh+dt@kernel.org>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
<dougthompson@xmission.com>, <bp@alien8.de>,
<mchehab@osg.samsung.com>, <devicetree@vger.kernel.org>,
<guohanjun@huawei.com>, <andre.przywara@arm.com>, <arnd@arndb.de>,
<linux-kernel@vger.kernel.org>, <linux-edac@vger.kernel.org>
Subject: Re: [PATCH v3] EDAC: Add ARM64 EDAC
Date: Tue, 27 Oct 2015 15:01:59 -0500 [thread overview]
Message-ID: <562FD837.50505@amd.com> (raw)
In-Reply-To: <20151027190832.GN19782@codeaurora.org>
Thanks for review Steve.
On 10/27/2015 02:08 PM, Stephen Boyd wrote:
>> +config EDAC_CORTEX_ARM64
>> + tristate "ARM Cortex A57/A53"
>> + depends on EDAC_MM_EDAC && ARM64
>> + default n
>
> n is the default so this can be removed.
>
noted
>> + .driver = {
>> + .name = DRV_NAME,
>> + .owner = THIS_MODULE,
>
> This line can be removed. THIS_MODULE is assigned by
> platform_driver_register().
noted.
>
>> + .of_match_table = cortex_arm64_edac_of_match,
>> + },
>> +};
>> +
>> +static int __init cortex_arm64_edac_init(void)
>> +{
>> + return platform_driver_register(&cortex_arm64_edac_driver);
>> +}
>> +module_init(cortex_arm64_edac_init);
>> +
>> +static void __exit cortex_arm64_edac_exit(void)
>> +{
>> + platform_driver_unregister(&cortex_arm64_edac_driver);
>> +}
>> +module_exit(cortex_arm64_edac_exit);
>
> This can be module_platform_driver(cortex_arm64_edac_driver) now.
>
noted.
-Brijesh
next prev parent reply other threads:[~2015-10-27 20:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 17:29 [PATCH v3] EDAC: Add ARM64 EDAC Brijesh Singh
2015-10-27 17:29 ` Brijesh Singh
2015-10-27 17:29 ` Brijesh Singh
2015-10-27 19:08 ` Stephen Boyd
2015-10-27 19:08 ` Stephen Boyd
2015-10-27 20:01 ` Brijesh Singh [this message]
2015-10-27 20:01 ` Brijesh Singh
2015-10-27 20:01 ` Brijesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562FD837.50505@amd.com \
--to=brijeshkumar.singh@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.