All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven.eckelmann@openmesh.com>
To: s.gottschall@dd-wrt.com
Cc: linux-wireless@vger.kernel.org, kvalo@codeaurora.org,
	ath10k@lists.infradead.org
Subject: Re: [PATCH v8] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter
Date: Wed, 04 Jul 2018 12:40:39 +0200	[thread overview]
Message-ID: <5630152.jDWN9V3RzB@bentobox> (raw)
In-Reply-To: <20180704092953.32572-1-s.gottschall@dd-wrt.com>


[-- Attachment #1.1: Type: text/plain, Size: 1544 bytes --]

On Mittwoch, 4. Juli 2018 11:29:53 CEST s.gottschall@dd-wrt.com wrote:
> +/* Values defined to set 160 MHz Bandwidth NSS Mapping into FW*/
> +#define BW_NSS_FWCONF_160(x)           (BW_NSS_FWCONF_MAP_ENABLE | \
> +                                       (((x - 1) << BW_NSS_FWCONF_MAP_160MHZ_S) \
> +                                       & BW_NSS_FWCONF_MAP_160MHZ_M))
> +#define BW_NSS_FWCONF_80_80(x)         (BW_NSS_FWCONF_MAP_ENABLE | \
> +                                       (((x - 1) << BW_NSS_FWCONF_MAP_80_80MHZ_S) \
> +                                       & BW_NSS_FWCONF_MAP_80_80MHZ_M))

Please check the shift and mask macros in core.h


#define BW_NSS_FWCONF_MAP_160MHZ_LSB           0
#define BW_NSS_FWCONF_MAP_160MHZ_MASK          0x00000007
#define BW_NSS_FWCONF_MAP_80_80MHZ_LSB         3
#define BW_NSS_FWCONF_MAP_80_80MHZ_MASK        0x00000038
#define BW_NSS_FWCONF_MAP_MASK                 0x0000003F

#define GET_BW_NSS_FWCONF_160(x)     (MS((x), BW_NSS_FWCONF_MAP_160MHZ) + 1)
#define GET_BW_NSS_FWCONF_80_80(x)   (MS((x), BW_NSS_FWCONF_MAP_80_80MHZ_M) + 1)

/* Values defined to set 160 MHz Bandwidth NSS Mapping into FW*/
#define BW_NSS_FWCONF_160(x)         (BW_NSS_FWCONF_MAP_ENABLE | \
                                      (SM((x) - 1, BW_NSS_FWCONF_MAP_160MHZ))
#define BW_NSS_FWCONF_80_80(x)       (BW_NSS_FWCONF_MAP_ENABLE | \
                                      (SM((x) - 1, BW_NSS_FWCONF_MAP_80_80MHZ))

(these snippets were not yet tested and most likely need further adjustments)


Kind regards,
	Sven

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 146 bytes --]

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven.eckelmann@openmesh.com>
To: s.gottschall@dd-wrt.com
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	kvalo@codeaurora.org
Subject: Re: [PATCH v8] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter
Date: Wed, 04 Jul 2018 12:40:39 +0200	[thread overview]
Message-ID: <5630152.jDWN9V3RzB@bentobox> (raw)
In-Reply-To: <20180704092953.32572-1-s.gottschall@dd-wrt.com>

[-- Attachment #1: Type: text/plain, Size: 1544 bytes --]

On Mittwoch, 4. Juli 2018 11:29:53 CEST s.gottschall@dd-wrt.com wrote:
> +/* Values defined to set 160 MHz Bandwidth NSS Mapping into FW*/
> +#define BW_NSS_FWCONF_160(x)           (BW_NSS_FWCONF_MAP_ENABLE | \
> +                                       (((x - 1) << BW_NSS_FWCONF_MAP_160MHZ_S) \
> +                                       & BW_NSS_FWCONF_MAP_160MHZ_M))
> +#define BW_NSS_FWCONF_80_80(x)         (BW_NSS_FWCONF_MAP_ENABLE | \
> +                                       (((x - 1) << BW_NSS_FWCONF_MAP_80_80MHZ_S) \
> +                                       & BW_NSS_FWCONF_MAP_80_80MHZ_M))

Please check the shift and mask macros in core.h


#define BW_NSS_FWCONF_MAP_160MHZ_LSB           0
#define BW_NSS_FWCONF_MAP_160MHZ_MASK          0x00000007
#define BW_NSS_FWCONF_MAP_80_80MHZ_LSB         3
#define BW_NSS_FWCONF_MAP_80_80MHZ_MASK        0x00000038
#define BW_NSS_FWCONF_MAP_MASK                 0x0000003F

#define GET_BW_NSS_FWCONF_160(x)     (MS((x), BW_NSS_FWCONF_MAP_160MHZ) + 1)
#define GET_BW_NSS_FWCONF_80_80(x)   (MS((x), BW_NSS_FWCONF_MAP_80_80MHZ_M) + 1)

/* Values defined to set 160 MHz Bandwidth NSS Mapping into FW*/
#define BW_NSS_FWCONF_160(x)         (BW_NSS_FWCONF_MAP_ENABLE | \
                                      (SM((x) - 1, BW_NSS_FWCONF_MAP_160MHZ))
#define BW_NSS_FWCONF_80_80(x)       (BW_NSS_FWCONF_MAP_ENABLE | \
                                      (SM((x) - 1, BW_NSS_FWCONF_MAP_80_80MHZ))

(these snippets were not yet tested and most likely need further adjustments)


Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-07-04 10:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04  9:29 [PATCH v8] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter s.gottschall
2018-07-04  9:29 ` s.gottschall
2018-07-04 10:40 ` Sven Eckelmann [this message]
2018-07-04 10:40   ` Sven Eckelmann
2018-07-04 10:48   ` Sebastian Gottschall
2018-07-04 10:48     ` Sebastian Gottschall
2018-07-04 11:05     ` Sebastian Gottschall
2018-07-04 11:05       ` Sebastian Gottschall
2018-07-04 11:12     ` Sven Eckelmann
2018-07-04 11:12       ` Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5630152.jDWN9V3RzB@bentobox \
    --to=sven.eckelmann@openmesh.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=s.gottschall@dd-wrt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.