* [PATCH] soc: qcom: smd-rpm: Correct size of outgoing message
@ 2015-10-29 22:09 ` Bjorn Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2015-10-29 22:09 UTC (permalink / raw)
To: Andy Gross, Stephen Boyd; +Cc: linux-arm-msm, linux-soc, linux-kernel
With the removal of VLAIS the size was incorrectly changed to only cover
the headers of the packet, resulting in "empty" requests being sent to
the RPM. Correct this so the entire message is transfered.
Fixes: 50e1b29b4438 ("soc: qcom: smd: Remove use of VLAIS")
Cc: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---
drivers/soc/qcom/smd-rpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c
index 1ee02d2587b2..2969321e1b09 100644
--- a/drivers/soc/qcom/smd-rpm.c
+++ b/drivers/soc/qcom/smd-rpm.c
@@ -132,7 +132,7 @@ int qcom_rpm_smd_write(struct qcom_smd_rpm *rpm,
pkt->req.data_len = cpu_to_le32(count);
memcpy(pkt->payload, buf, count);
- ret = qcom_smd_send(rpm->rpm_channel, pkt, sizeof(*pkt));
+ ret = qcom_smd_send(rpm->rpm_channel, pkt, size);
if (ret)
goto out;
--
2.4.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] soc: qcom: smd-rpm: Correct size of outgoing message
@ 2015-10-29 22:09 ` Bjorn Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2015-10-29 22:09 UTC (permalink / raw)
To: Andy Gross, Stephen Boyd; +Cc: linux-arm-msm, linux-soc, linux-kernel
With the removal of VLAIS the size was incorrectly changed to only cover
the headers of the packet, resulting in "empty" requests being sent to
the RPM. Correct this so the entire message is transfered.
Fixes: 50e1b29b4438 ("soc: qcom: smd: Remove use of VLAIS")
Cc: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---
drivers/soc/qcom/smd-rpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c
index 1ee02d2587b2..2969321e1b09 100644
--- a/drivers/soc/qcom/smd-rpm.c
+++ b/drivers/soc/qcom/smd-rpm.c
@@ -132,7 +132,7 @@ int qcom_rpm_smd_write(struct qcom_smd_rpm *rpm,
pkt->req.data_len = cpu_to_le32(count);
memcpy(pkt->payload, buf, count);
- ret = qcom_smd_send(rpm->rpm_channel, pkt, sizeof(*pkt));
+ ret = qcom_smd_send(rpm->rpm_channel, pkt, size);
if (ret)
goto out;
--
2.4.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] soc: qcom: smd-rpm: Correct size of outgoing message
2015-10-29 22:09 ` Bjorn Andersson
(?)
@ 2015-10-29 22:50 ` Stephen Boyd
2015-10-30 16:58 ` Andy Gross
-1 siblings, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2015-10-29 22:50 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross; +Cc: linux-arm-msm, linux-soc, linux-kernel
On 10/29/2015 03:09 PM, Bjorn Andersson wrote:
> With the removal of VLAIS the size was incorrectly changed to only cover
> the headers of the packet, resulting in "empty" requests being sent to
> the RPM. Correct this so the entire message is transfered.
>
> Fixes: 50e1b29b4438 ("soc: qcom: smd: Remove use of VLAIS")
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
I thought this was already merged though.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: qcom: smd-rpm: Correct size of outgoing message
2015-10-29 22:50 ` Stephen Boyd
@ 2015-10-30 16:58 ` Andy Gross
0 siblings, 0 replies; 4+ messages in thread
From: Andy Gross @ 2015-10-30 16:58 UTC (permalink / raw)
To: Stephen Boyd; +Cc: Bjorn Andersson, linux-arm-msm, linux-soc, linux-kernel
On Thu, Oct 29, 2015 at 03:50:09PM -0700, Stephen Boyd wrote:
> On 10/29/2015 03:09 PM, Bjorn Andersson wrote:
> > With the removal of VLAIS the size was incorrectly changed to only cover
> > the headers of the packet, resulting in "empty" requests being sent to
> > the RPM. Correct this so the entire message is transfered.
> >
> > Fixes: 50e1b29b4438 ("soc: qcom: smd: Remove use of VLAIS")
> > Cc: Stephen Boyd <sboyd@codeaurora.org>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
>
> I thought this was already merged though.
I accidentally dropped my fixup for this during one of the rebases.
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-30 16:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-29 22:09 [PATCH] soc: qcom: smd-rpm: Correct size of outgoing message Bjorn Andersson
2015-10-29 22:09 ` Bjorn Andersson
2015-10-29 22:50 ` Stephen Boyd
2015-10-30 16:58 ` Andy Gross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.