All of lore.kernel.org
 help / color / mirror / Atom feed
From: huawei.libin@huawei.com (libin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] recordmcount: arm64: replace the ignored mcount call into nop
Date: Fri, 30 Oct 2015 16:44:11 +0800	[thread overview]
Message-ID: <56332DDB.8060701@huawei.com> (raw)
In-Reply-To: <1446193864-24593-4-git-send-email-huawei.libin@huawei.com>



on 2015/10/30 16:31, Li Bin wrote:
> By now, the recordmcount only records the function that in
> following sections:
> .text/.ref.text/.sched.text/.spinlock.text/.irqentry.text/
> .kprobes.text/.text.unlikely
> 
> For the function that not in these sections, the call mcount
> will be in place and not be replaced when kernel boot up. And
> it will bring performance overhead, such as do_mem_abort (in
> .exception.text section). This patch make the call mcount to
> nop for this case in recordmcount.
> 
> Cc: <stable@vger.kernel.org> # 3.18+
> Signed-off-by: Li Bin <huawei.libin@huawei.com>

Acked-by: Will Deacon <will.deacon@arm.com>
https://lkml.org/lkml/2015/10/28/301

> ---
>  scripts/recordmcount.c | 24 +++++++++++++++++++++++-
>  1 file changed, 23 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
> index 8cc020b..698768b 100644
> --- a/scripts/recordmcount.c
> +++ b/scripts/recordmcount.c
> @@ -42,6 +42,7 @@
>  
>  #ifndef EM_AARCH64
>  #define EM_AARCH64	183
> +#define R_AARCH64_NONE		0
>  #define R_AARCH64_ABS64	257
>  #endif
>  
> @@ -160,6 +161,22 @@ static int make_nop_x86(void *map, size_t const offset)
>  	return 0;
>  }
>  
> +static unsigned char ideal_nop4_arm64[4] = {0x1f, 0x20, 0x03, 0xd5};
> +static int make_nop_arm64(void *map, size_t const offset)
> +{
> +	uint32_t *ptr;
> +
> +	ptr = map + offset;
> +	/* bl <_mcount> is 0x94000000 before relocation */
> +	if (*ptr != 0x94000000)
> +		return -1;
> +
> +	/* Convert to nop */
> +	ulseek(fd_map, offset, SEEK_SET);
> +	uwrite(fd_map, ideal_nop, 4);
> +	return 0;
> +}
> +
>  /*
>   * Get the whole file as a programming convenience in order to avoid
>   * malloc+lseek+read+free of many pieces.  If successful, then mmap
> @@ -354,7 +371,12 @@ do_file(char const *const fname)
>  			 altmcount = "__gnu_mcount_nc";
>  			 break;
>  	case EM_AARCH64:
> -			 reltype = R_AARCH64_ABS64; gpfx = '_'; break;
> +			reltype = R_AARCH64_ABS64;
> +			make_nop = make_nop_arm64;
> +			rel_type_nop = R_AARCH64_NONE;
> +			ideal_nop = ideal_nop4_arm64;
> +			gpfx = '_';
> +			break;
>  	case EM_IA_64:	 reltype = R_IA64_IMM64;   gpfx = '_'; break;
>  	case EM_METAG:	 reltype = R_METAG_ADDR32;
>  			 altmcount = "_mcount_wrapper";
> 

WARNING: multiple messages have this Message-ID (diff)
From: libin <huawei.libin@huawei.com>
To: <will.deacon@arm.com>, <lkp@intel.com>, <catalin.marinas@arm.com>,
	<rostedt@goodmis.org>, <takahiro.akashi@linaro.org>
Cc: <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <guohanjun@huawei.com>,
	<dingtianhong@huawei.com>, <zhouchengming1@huawei.com>,
	<xiexiuqi@huawei.com>
Subject: Re: [PATCH 3/3] recordmcount: arm64: replace the ignored mcount call into nop
Date: Fri, 30 Oct 2015 16:44:11 +0800	[thread overview]
Message-ID: <56332DDB.8060701@huawei.com> (raw)
In-Reply-To: <1446193864-24593-4-git-send-email-huawei.libin@huawei.com>



on 2015/10/30 16:31, Li Bin wrote:
> By now, the recordmcount only records the function that in
> following sections:
> .text/.ref.text/.sched.text/.spinlock.text/.irqentry.text/
> .kprobes.text/.text.unlikely
> 
> For the function that not in these sections, the call mcount
> will be in place and not be replaced when kernel boot up. And
> it will bring performance overhead, such as do_mem_abort (in
> .exception.text section). This patch make the call mcount to
> nop for this case in recordmcount.
> 
> Cc: <stable@vger.kernel.org> # 3.18+
> Signed-off-by: Li Bin <huawei.libin@huawei.com>

Acked-by: Will Deacon <will.deacon@arm.com>
https://lkml.org/lkml/2015/10/28/301

> ---
>  scripts/recordmcount.c | 24 +++++++++++++++++++++++-
>  1 file changed, 23 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
> index 8cc020b..698768b 100644
> --- a/scripts/recordmcount.c
> +++ b/scripts/recordmcount.c
> @@ -42,6 +42,7 @@
>  
>  #ifndef EM_AARCH64
>  #define EM_AARCH64	183
> +#define R_AARCH64_NONE		0
>  #define R_AARCH64_ABS64	257
>  #endif
>  
> @@ -160,6 +161,22 @@ static int make_nop_x86(void *map, size_t const offset)
>  	return 0;
>  }
>  
> +static unsigned char ideal_nop4_arm64[4] = {0x1f, 0x20, 0x03, 0xd5};
> +static int make_nop_arm64(void *map, size_t const offset)
> +{
> +	uint32_t *ptr;
> +
> +	ptr = map + offset;
> +	/* bl <_mcount> is 0x94000000 before relocation */
> +	if (*ptr != 0x94000000)
> +		return -1;
> +
> +	/* Convert to nop */
> +	ulseek(fd_map, offset, SEEK_SET);
> +	uwrite(fd_map, ideal_nop, 4);
> +	return 0;
> +}
> +
>  /*
>   * Get the whole file as a programming convenience in order to avoid
>   * malloc+lseek+read+free of many pieces.  If successful, then mmap
> @@ -354,7 +371,12 @@ do_file(char const *const fname)
>  			 altmcount = "__gnu_mcount_nc";
>  			 break;
>  	case EM_AARCH64:
> -			 reltype = R_AARCH64_ABS64; gpfx = '_'; break;
> +			reltype = R_AARCH64_ABS64;
> +			make_nop = make_nop_arm64;
> +			rel_type_nop = R_AARCH64_NONE;
> +			ideal_nop = ideal_nop4_arm64;
> +			gpfx = '_';
> +			break;
>  	case EM_IA_64:	 reltype = R_IA64_IMM64;   gpfx = '_'; break;
>  	case EM_METAG:	 reltype = R_METAG_ADDR32;
>  			 altmcount = "_mcount_wrapper";
> 


  reply	other threads:[~2015-10-30  8:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30  8:31 [PATCH 0/3] recordmcount: bugfix and amend Li Bin
2015-10-30  8:31 ` Li Bin
2015-10-30  8:31 ` [PATCH 1/3] recordmcount: fix endianness handling bug for nop_mcount Li Bin
2015-10-30  8:31   ` Li Bin
2015-10-30  8:45   ` libin
2015-10-30  8:45     ` libin
2015-10-30 14:35   ` Sergei Shtylyov
2015-10-30 14:35     ` Sergei Shtylyov
2015-10-31  2:07     ` libin
2015-10-31  2:07       ` libin
2015-11-02 19:33       ` Steven Rostedt
2015-11-02 19:33         ` Steven Rostedt
2015-11-03  0:58         ` [PATCH] " libin
2015-11-03  0:58           ` libin
2015-10-30  8:31 ` [PATCH 2/3] recordmcount: x86: assign a meaningful value to rel_type_nop Li Bin
2015-10-30  8:31   ` Li Bin
2015-10-30  8:31 ` [PATCH 3/3] recordmcount: arm64: replace the ignored mcount call into nop Li Bin
2015-10-30  8:31   ` Li Bin
2015-10-30  8:44   ` libin [this message]
2015-10-30  8:44     ` libin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56332DDB.8060701@huawei.com \
    --to=huawei.libin@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.