From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth: move inline functions to the header file
Date: Fri, 30 Oct 2015 23:09:15 +0000 [thread overview]
Message-ID: <5633F89B.6000702@cogentembedded.com> (raw)
In-Reply-To: <20150407.153337.1789757717574323514.davem@davemloft.net>
Hello.
On 04/07/2015 10:33 PM, David Miller wrote:
>>>> The explicitly inline functions belong to the header files, so move
>>>> cpu_to_edmac() and edmac_to_cpu() into the driver header.
>>
>>>> While at it, make these functions return 'u32' instead of '__u32'.
>>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>>> Then... ummm... remove the inline keyword?
>>
>>> If it's not used anywhere else, that's the thing to do.
>>
>> Results in more code, as I noted in the patch posting that you skipped
>> when replying. At least with gcc 4.7.
>
> That's a compiler bug.
Even worse, these functions support the BE mode which never was used and
never worked correctly. I'll just try to remove them altogether.
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth: move inline functions to the header file
Date: Sat, 31 Oct 2015 02:09:15 +0300 [thread overview]
Message-ID: <5633F89B.6000702@cogentembedded.com> (raw)
In-Reply-To: <20150407.153337.1789757717574323514.davem@davemloft.net>
Hello.
On 04/07/2015 10:33 PM, David Miller wrote:
>>>> The explicitly inline functions belong to the header files, so move
>>>> cpu_to_edmac() and edmac_to_cpu() into the driver header.
>>
>>>> While at it, make these functions return 'u32' instead of '__u32'.
>>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>>> Then... ummm... remove the inline keyword?
>>
>>> If it's not used anywhere else, that's the thing to do.
>>
>> Results in more code, as I noted in the patch posting that you skipped
>> when replying. At least with gcc 4.7.
>
> That's a compiler bug.
Even worse, these functions support the BE mode which never was used and
never worked correctly. I'll just try to remove them altogether.
MBR, Sergei
next prev parent reply other threads:[~2015-10-30 23:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-05 21:13 [PATCH] sh_eth: move inline functions to the header file Sergei Shtylyov
2015-04-05 21:13 ` Sergei Shtylyov
2015-04-07 13:21 ` Geert Uytterhoeven
2015-04-07 13:21 ` Geert Uytterhoeven
2015-04-07 17:21 ` Sergei Shtylyov
2015-04-07 17:21 ` Sergei Shtylyov
2015-04-07 19:22 ` David Miller
2015-04-07 19:22 ` David Miller
2015-04-07 19:26 ` Sergei Shtylyov
2015-04-07 19:26 ` Sergei Shtylyov
2015-04-07 19:33 ` David Miller
2015-04-07 19:33 ` David Miller
2015-10-30 23:09 ` Sergei Shtylyov [this message]
2015-10-30 23:09 ` Sergei Shtylyov
2015-12-12 22:24 ` Sergei Shtylyov
2015-12-12 22:24 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5633F89B.6000702@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.