All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend van Spriel <arend@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>, <backports@vger.kernel.org>
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH v2] backports: add ktime_get_seconds()
Date: Sat, 31 Oct 2015 23:03:03 +0100	[thread overview]
Message-ID: <56353A97.9010909@broadcom.com> (raw)
In-Reply-To: <56313B75.4000406@broadcom.com>

On 10/28/2015 10:17 PM, Arend van Spriel wrote:
> On 10/23/2015 01:52 PM, Johannes Berg wrote:
>> From: Johannes Berg <johannes.berg@intel.com>
>>
>> Since commit 84b00607aeb8 ("mac80211: use ktime_get_seconds")
>> mac80211 uses ktime_get_seconds(). This patch provide a backport
>> using ktime_get_ts() for it.
>>
>> [commit message and time64_t taken from Arend's patch]
>>
>> Signed-off-by: Arend van Spriel <arend@broadcom.com>
>
> Looks good. Thanks.

Actually got feedback internally that ubuntu kernel 3.19.0-30-generic 
does not need this patch so should we extend this with 
UTS_UBUNTU_RELEASE_ABI check?

Regards,
Arend

> Regards,
> Arend
>
>> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>> ---
>>   backport/backport-include/linux/ktime.h       |  1 +
>>   backport/backport-include/linux/timekeeping.h | 21
>> +++++++++++++++++++++
>>   backport/backport-include/linux/types.h       | 10 ++++++++++
>>   3 files changed, 32 insertions(+)
>>   create mode 100644 backport/backport-include/linux/timekeeping.h
>>   create mode 100644 backport/backport-include/linux/types.h
>>
>> diff --git a/backport/backport-include/linux/ktime.h
>> b/backport/backport-include/linux/ktime.h
>> index 6fbc6c6eb26c..33ed31caf01a 100644
>> --- a/backport/backport-include/linux/ktime.h
>> +++ b/backport/backport-include/linux/ktime.h
>> @@ -1,6 +1,7 @@
>>   #ifndef __BACKPORT_LINUX_KTIME_H
>>   #define __BACKPORT_LINUX_KTIME_H
>>   #include_next <linux/ktime.h>
>> +#include <linux/timekeeping.h>
>>   #include <linux/version.h>
>>
>>   #if  LINUX_VERSION_CODE < KERNEL_VERSION(3,17,0)
>> diff --git a/backport/backport-include/linux/timekeeping.h
>> b/backport/backport-include/linux/timekeeping.h
>> new file mode 100644
>> index 000000000000..4fb39b2c0119
>> --- /dev/null
>> +++ b/backport/backport-include/linux/timekeeping.h
>> @@ -0,0 +1,21 @@
>> +#ifndef __BACKPORT_TIMKEEPING_H
>> +#define __BACKPORT_TIMKEEPING_H
>> +#include <linux/version.h>
>> +#include <linux/types.h>
>> +
>> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(3,17,0)
>> +#include_next <linux/timekeeping.h>
>> +#endif
>> +
>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,19,0)
>> +static inline time64_t ktime_get_seconds(void)
>> +{
>> +    struct timespec t;
>> +
>> +    ktime_get_ts(&t);
>> +
>> +    return t.tv_sec;
>> +}
>> +#endif
>> +
>> +#endif /* __BACKPORT_TIMKEEPING_H */
>> diff --git a/backport/backport-include/linux/types.h
>> b/backport/backport-include/linux/types.h
>> new file mode 100644
>> index 000000000000..d68e39c54325
>> --- /dev/null
>> +++ b/backport/backport-include/linux/types.h
>> @@ -0,0 +1,10 @@
>> +#ifndef __BACKPORT_TYPES
>> +#define __BACKPORT_TYPES
>> +#include <linux/version.h>
>> +#include_next <linux/types.h>
>> +
>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,17,0)
>> +typedef __s64 time64_t;
>> +#endif
>> +
>> +#endif /* __BACKPORT_TYPES */
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe backports" in

--
To unsubscribe from this list: send the line "unsubscribe backports" in

  reply	other threads:[~2015-10-31 22:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 11:52 [PATCH v2] backports: add ktime_get_seconds() Johannes Berg
2015-10-28 21:17 ` Arend van Spriel
2015-10-31 22:03   ` Arend van Spriel [this message]
2015-11-01  7:47     ` Johannes Berg
2015-11-07 17:08 ` Hauke Mehrtens
2015-12-08  8:44   ` Arend van Spriel
2015-12-08  9:04     ` Johannes Berg
2015-12-08  9:14       ` Johannes Berg
2015-12-08  9:28         ` Arend van Spriel
2015-12-08  9:38           ` Johannes Berg
2015-12-09 22:52             ` Hauke Mehrtens
2015-12-09 22:56               ` Johannes Berg
2015-12-09 22:48     ` Hauke Mehrtens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56353A97.9010909@broadcom.com \
    --to=arend@broadcom.com \
    --cc=backports@vger.kernel.org \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.