Re: [PATCH v2] backports: add ktime_get_seconds()

[Hauke Mehrtens <hauke@hauke-m.de>]

On 12/08/2015 10:38 AM, Johannes Berg wrote:
> On Tue, 2015-12-08 at 10:28 +0100, Arend van Spriel wrote:
>>  
>> Basically the list would be the exported symbols from the backports 
>> module, ie. compat.ko, right?
>>
> 
> Perhaps, I think it's slightly more complicated.
> 
> For one, we mostly prefix them with backport_, so just using as-is
> won't work.
> 
> Secondly, we might sometimes intentionally do that, even though the
> original function *does* exist, like with debugfs_create_bool() that
> changed function signature.
> 
> I think it'd be safer to just do it one by one - but we might be able
> to get rid of a lot of the RHEL/ubuntu/whatever ifdefs that way?
> 
> We might also be able to use them to ifdef some inlines that belong to
> it? Overall it seems better to just do it by hand but as a better
> mechanism than checking kernel versions?
> 
> johannes

We could search backport/compat/*.c for EXPORT_SYMBOL() and create the
list based on that. Using compat.ko for that would mean we have to
compile first.
Based on this data we can check if the kernel would export this function
and create a "#define HAVE_FUNFION_NAME 1"

Hauke

--
To unsubscribe from this list: send the line "unsubscribe backports" in