From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86: make compat_iret() domain crash cases distinguishable
Date: Mon, 2 Nov 2015 11:10:06 +0000 [thread overview]
Message-ID: <5637448E.7010304@citrix.com> (raw)
In-Reply-To: <56374FAF02000078000B0AAB@prv-mh.provo.novell.com>
On 02/11/15 10:57, Jan Beulich wrote:
>>>> On 30.10.15 at 20:05, <andrew.cooper3@citrix.com> wrote:
>> On 30/10/15 17:46, Jan Beulich wrote:
>>> Rather than issuing a (mostly) useless separate message, rely on
>>> domain_crash() providing enough data, and leverage the line number
>>> information it prints.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> The messages are not completely useless, and they do save a round-trip
>> to the debug symbols (which can be a very long RTT when dealing with
>> customers).
> Oh, also: Why would looking at the debug symbols be needed? You
> get file name and line number printed.
Any file patched will end up having a slide on the line number. The use
of the debug symbols is necessary to confirm, especially in cases like
this where there are multiple possibilities close to each other.
~Andrew
next prev parent reply other threads:[~2015-11-02 11:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 17:46 [PATCH] x86: make compat_iret() domain crash cases distinguishable Jan Beulich
2015-10-30 19:05 ` Andrew Cooper
2015-10-30 19:11 ` Andrew Cooper
2015-11-02 10:56 ` Jan Beulich
2015-11-02 11:07 ` Andrew Cooper
2015-11-02 10:57 ` Jan Beulich
2015-11-02 11:10 ` Andrew Cooper [this message]
2015-11-02 11:15 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5637448E.7010304@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.