From: Timur Tabi <timur@codeaurora.org>
To: Andre Przywara <andre.przywara@arm.com>,
Jun Nie <jun.nie@linaro.org>,
Peter Hurley <peter@hurleysoftware.com>
Cc: Andrew.Jackson@arm.com, Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH DRAFT 1/2] drivers: serial: PL011: refactor register access
Date: Mon, 2 Nov 2015 07:27:19 -0600 [thread overview]
Message-ID: <563764B7.6040202@codeaurora.org> (raw)
In-Reply-To: <1446467042-24494-2-git-send-email-andre.przywara@arm.com>
Andre Przywara wrote:
> * to support UARTs with different register offsets (ZTE)
> * to support a different bus access width (16 bits vs. 32 bits)
How exactly does this patch provide this? The code is still calling a
fixed function. How will the code dynamically call a 32-bit version
instead of a 16-bit version on platforms that need it?
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
WARNING: multiple messages have this Message-ID (diff)
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH DRAFT 1/2] drivers: serial: PL011: refactor register access
Date: Mon, 2 Nov 2015 07:27:19 -0600 [thread overview]
Message-ID: <563764B7.6040202@codeaurora.org> (raw)
In-Reply-To: <1446467042-24494-2-git-send-email-andre.przywara@arm.com>
Andre Przywara wrote:
> * to support UARTs with different register offsets (ZTE)
> * to support a different bus access width (16 bits vs. 32 bits)
How exactly does this patch provide this? The code is still calling a
fixed function. How will the code dynamically call a 32-bit version
instead of a 16-bit version on platforms that need it?
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
next prev parent reply other threads:[~2015-11-02 13:27 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 12:24 [PATCH DRAFT 0/2] Sketch for ZTE ZX296702 UART integration Andre Przywara
2015-11-02 12:24 ` Andre Przywara
2015-11-02 12:24 ` [PATCH DRAFT 1/2] drivers: serial: PL011: refactor register access Andre Przywara
2015-11-02 12:24 ` Andre Przywara
2015-11-02 13:27 ` Timur Tabi [this message]
2015-11-02 13:27 ` Timur Tabi
2015-11-02 13:40 ` Andre Przywara
2015-11-02 13:40 ` Andre Przywara
2015-11-02 13:44 ` Timur Tabi
2015-11-02 13:44 ` Timur Tabi
2015-11-02 12:24 ` [PATCH DRAFT 2/2] drivers: serial: PL011: [DRAFT] implement register diverson for ZTE UART Andre Przywara
2015-11-02 12:24 ` Andre Przywara
2015-11-03 13:46 ` Russell King - ARM Linux
2015-11-03 13:46 ` Russell King - ARM Linux
2015-11-03 13:57 ` Andre Przywara
2015-11-03 13:57 ` Andre Przywara
2015-11-05 9:54 ` Jun Nie
2015-11-05 9:54 ` Jun Nie
2015-11-03 14:23 ` Russell King - ARM Linux
2015-11-03 14:23 ` Russell King - ARM Linux
2015-11-03 14:30 ` Andre Przywara
2015-11-03 14:30 ` Andre Przywara
2015-11-03 13:43 ` [PATCH DRAFT 0/2] Sketch for ZTE ZX296702 UART integration Russell King - ARM Linux
2015-11-03 13:43 ` Russell King - ARM Linux
2015-11-03 14:48 ` Russell King - ARM Linux
2015-11-03 14:48 ` Russell King - ARM Linux
2015-11-03 14:50 ` [PATCH 01/11] tty: amba-pl011: add register accessor functions Russell King
2015-11-03 14:50 ` Russell King
2015-11-03 14:53 ` Timur Tabi
2015-11-03 14:53 ` Timur Tabi
2015-11-03 15:18 ` Russell King - ARM Linux
2015-11-03 15:18 ` Russell King - ARM Linux
2015-11-03 14:51 ` [PATCH 02/11] tty: amba-pl011: convert accessor functions to take uart_amba_port Russell King
2015-11-03 14:51 ` Russell King
2015-11-03 14:51 ` [PATCH 03/11] tty: amba-pl011: add helper to detect split LCRH register Russell King
2015-11-03 14:51 ` Russell King
2015-11-03 14:51 ` [PATCH 04/11] tty: amba-pl011: prepare REG_* register indexes Russell King
2015-11-03 14:51 ` Russell King
2015-11-03 14:51 ` [PATCH 05/11] tty: amba-pl011: add register lookup table Russell King
2015-11-03 14:51 ` Russell King
2015-11-06 0:00 ` Timur Tabi
2015-11-06 0:00 ` Timur Tabi
2015-11-06 0:24 ` Russell King - ARM Linux
2015-11-06 0:24 ` Russell King - ARM Linux
2015-11-06 0:27 ` Timur Tabi
2015-11-06 0:27 ` Timur Tabi
2015-12-13 6:03 ` Greg Kroah-Hartman
2015-12-13 6:03 ` Greg Kroah-Hartman
2015-11-03 14:51 ` [PATCH 06/11] tty: amba-pl011: add register offset table to vendor data Russell King
2015-11-03 14:51 ` Russell King
2015-11-03 14:51 ` [PATCH 07/11] tty: amba-pl011: add ST register offset table Russell King
2015-11-03 14:51 ` Russell King
2015-11-03 14:51 ` [PATCH 08/11] tty: amba-pl011: clean up LCR register offsets Russell King
2015-11-03 14:51 ` Russell King
2015-11-03 14:51 ` [PATCH 09/11] tty: amba-pl011: remove ST micro registers from standard table Russell King
2015-11-03 14:51 ` Russell King
2015-11-03 14:51 ` [PATCH 10/11] tty: amba-pl011: add support for 32-bit register access Russell King
2015-11-03 14:51 ` Russell King
2015-11-03 14:57 ` Timur Tabi
2015-11-03 14:57 ` Timur Tabi
2015-11-03 16:19 ` Russell King - ARM Linux
2015-11-03 16:19 ` Russell King - ARM Linux
2015-11-05 4:46 ` Peter Hurley
2015-11-05 4:46 ` Peter Hurley
2015-11-03 14:51 ` [PATCH 11/11] tty: amba-pl011: add support for ZTE UART (EXPERIMENTAL) Russell King
2015-11-03 14:51 ` Russell King
2015-11-05 8:28 ` Linus Walleij
2015-11-05 8:28 ` Linus Walleij
2015-11-05 9:27 ` Russell King - ARM Linux
2015-11-05 9:27 ` Russell King - ARM Linux
2015-11-05 9:54 ` Linus Walleij
2015-11-05 9:54 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563764B7.6040202@codeaurora.org \
--to=timur@codeaurora.org \
--cc=Andrew.Jackson@arm.com \
--cc=andre.przywara@arm.com \
--cc=jun.nie@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.