From: Paolo Bonzini <pbonzini@redhat.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>,
hch@lst.de,
Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>,
dm-devel@redhat.com, linux-scsi@vger.kernel.org
Subject: Re: IBM request to allow unprivledged ioctls [Was: Revert "dm mpath: fix stalls when handling invalid ioctls"]
Date: Mon, 2 Nov 2015 16:45:09 +0100 [thread overview]
Message-ID: <56378505.6080601@redhat.com> (raw)
In-Reply-To: <20151102150527.GA23665@redhat.com>
On 02/11/2015 16:05, Mike Snitzer wrote:
> > In any case, if we don't start path activation we should return
> > ENOTCONN, not ENOTTY.
>
> Currently, if we don't start path activation we're returning EIO.
> ENOTCONN is used for when we do start path activation (and ENOTCONN is
> the means for DM core to retry)
>
> We _could_ change the ENOTCONN to be EAGAIN and EIO to ENOTCONN...
This makes sense... though of course testing the impact of this on
userspace is going to be hard. :( Chances are that userspace is not
expecting EAGAIN either.
Even if they did, how would someone know that they can now retry the
ioctl after getting EAGAIN? Should they just do it in a loop?
Paolo
next prev parent reply other threads:[~2015-11-02 15:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 12:24 [PATCH] Revert "dm mpath: fix stalls when handling invalid ioctls" Mauricio Faria de Oliveira
2015-10-29 12:33 ` Mauricio Faria de Oliveira
2015-10-29 13:18 ` IBM request to allow unprivledged ioctls [Was: Revert "dm mpath: fix stalls when handling invalid ioctls"] Mike Snitzer
2015-10-29 14:47 ` [dm-devel] " Mauricio Faria de Oliveira
2015-10-31 15:33 ` Paolo Bonzini
2015-10-31 18:13 ` Mike Snitzer
2015-10-31 18:36 ` Mike Snitzer
2015-10-31 19:07 ` Paolo Bonzini
2015-10-31 22:47 ` Mike Snitzer
2015-11-02 7:28 ` Hannes Reinecke
2015-11-02 9:57 ` Paolo Bonzini
2015-11-02 13:31 ` Mike Snitzer
2015-11-02 13:56 ` Hannes Reinecke
2015-11-02 14:12 ` Mike Snitzer
2015-11-02 14:36 ` Hannes Reinecke
2015-11-02 15:14 ` Mike Snitzer
2015-11-02 15:29 ` Hannes Reinecke
2015-11-02 14:52 ` Paolo Bonzini
2015-11-02 15:05 ` Mike Snitzer
2015-11-02 15:45 ` Paolo Bonzini [this message]
2015-11-02 15:49 ` Mike Snitzer
2015-11-02 15:32 ` Hannes Reinecke
2015-11-02 9:55 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56378505.6080601@redhat.com \
--to=pbonzini@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=mauricfo@linux.vnet.ibm.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.