All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Pavel Fedin <p.fedin@samsung.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: 'Mark Rutland' <mark.rutland@arm.com>,
	'Pawel Moll' <pawel.moll@arm.com>,
	'Ian Campbell' <ijc+devicetree@hellion.org.uk>,
	k.kozlowski.k@gmail.com, 'Rob Herring' <robh+dt@kernel.org>,
	'Kukjin Kim' <kgene@kernel.org>,
	'Kumar Gala' <galak@codeaurora.org>
Subject: Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration
Date: Tue, 03 Nov 2015 16:18:36 +0900	[thread overview]
Message-ID: <56385FCC.1090007@samsung.com> (raw)
In-Reply-To: <004d01d11604$fc7a2a80$f56e7f80$@samsung.com>

On 03.11.2015 15:58, Pavel Fedin wrote:
>  Hello!
> 
>>>>> --- cut exynos5410.dtsi ---
>>>>> 		sromc: sromc@12250000 {
>>>>> 			#address-cells = <2>;
>>>>> 			#size-cells = <1>;
>>>>> 			ranges = <0 0 0x04000000 0x20000
>>>>> 				  1 0 0x05000000 0x20000
>>>>> 				  2 0 0x06000000 0x20000
>>>>> 				  3 0 0x07000000 0x20000>;
>>>>
>>>> Do you have to use 2 cells for address? Cannot it be:
>>>>  			ranges = <0 0x04000000 0x20000
>>>>  				  1 0x05000000 0x20000
>>>>  				  2 0x06000000 0x20000
>>>>  				  3 0x07000000 0x20000>;
>>>
>>>  I tried this first, but it didn't work, and ranges translation
>>> gave me something really weird (like addr = 0x80 and
>>> size = 0x04000004).
>>
>> Did you change the address-cells to <1>?
> 
>  Of course i did.

I saw some other nodes use the ranges without the offset but maybe some
more steps are required for such configuration.

So anyway send the version with the child offset and I will try to
figure out why it is required.

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration
Date: Tue, 03 Nov 2015 16:18:36 +0900	[thread overview]
Message-ID: <56385FCC.1090007@samsung.com> (raw)
In-Reply-To: <004d01d11604$fc7a2a80$f56e7f80$@samsung.com>

On 03.11.2015 15:58, Pavel Fedin wrote:
>  Hello!
> 
>>>>> --- cut exynos5410.dtsi ---
>>>>> 		sromc: sromc at 12250000 {
>>>>> 			#address-cells = <2>;
>>>>> 			#size-cells = <1>;
>>>>> 			ranges = <0 0 0x04000000 0x20000
>>>>> 				  1 0 0x05000000 0x20000
>>>>> 				  2 0 0x06000000 0x20000
>>>>> 				  3 0 0x07000000 0x20000>;
>>>>
>>>> Do you have to use 2 cells for address? Cannot it be:
>>>>  			ranges = <0 0x04000000 0x20000
>>>>  				  1 0x05000000 0x20000
>>>>  				  2 0x06000000 0x20000
>>>>  				  3 0x07000000 0x20000>;
>>>
>>>  I tried this first, but it didn't work, and ranges translation
>>> gave me something really weird (like addr = 0x80 and
>>> size = 0x04000004).
>>
>> Did you change the address-cells to <1>?
> 
>  Of course i did.

I saw some other nodes use the ranges without the offset but maybe some
more steps are required for such configuration.

So anyway send the version with the child offset and I will try to
figure out why it is required.

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Pavel Fedin <p.fedin@samsung.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: k.kozlowski.k@gmail.com, "'Mark Rutland'" <mark.rutland@arm.com>,
	"'Pawel Moll'" <pawel.moll@arm.com>,
	"'Ian Campbell'" <ijc+devicetree@hellion.org.uk>,
	"'Rob Herring'" <robh+dt@kernel.org>,
	"'Kukjin Kim'" <kgene@kernel.org>,
	"'Kumar Gala'" <galak@codeaurora.org>
Subject: Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration
Date: Tue, 03 Nov 2015 16:18:36 +0900	[thread overview]
Message-ID: <56385FCC.1090007@samsung.com> (raw)
In-Reply-To: <004d01d11604$fc7a2a80$f56e7f80$@samsung.com>

On 03.11.2015 15:58, Pavel Fedin wrote:
>  Hello!
> 
>>>>> --- cut exynos5410.dtsi ---
>>>>> 		sromc: sromc@12250000 {
>>>>> 			#address-cells = <2>;
>>>>> 			#size-cells = <1>;
>>>>> 			ranges = <0 0 0x04000000 0x20000
>>>>> 				  1 0 0x05000000 0x20000
>>>>> 				  2 0 0x06000000 0x20000
>>>>> 				  3 0 0x07000000 0x20000>;
>>>>
>>>> Do you have to use 2 cells for address? Cannot it be:
>>>>  			ranges = <0 0x04000000 0x20000
>>>>  				  1 0x05000000 0x20000
>>>>  				  2 0x06000000 0x20000
>>>>  				  3 0x07000000 0x20000>;
>>>
>>>  I tried this first, but it didn't work, and ranges translation
>>> gave me something really weird (like addr = 0x80 and
>>> size = 0x04000004).
>>
>> Did you change the address-cells to <1>?
> 
>  Of course i did.

I saw some other nodes use the ranges without the offset but maybe some
more steps are required for such configuration.

So anyway send the version with the child offset and I will try to
figure out why it is required.

Best regards,
Krzysztof


  reply	other threads:[~2015-11-03  7:18 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 12:42 [PATCH v4 0/4] [PATCH v4 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Pavel Fedin
2015-10-29 12:42 ` Pavel Fedin
2015-10-29 12:42 ` [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration Pavel Fedin
2015-10-29 12:42   ` Pavel Fedin
     [not found]   ` <f1fbd1a7877090f4318705f0fccbf4d96c0ebc9c.1446122247.git.p.fedin-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-30  6:30     ` Krzysztof Kozlowski
2015-10-30  6:30       ` Krzysztof Kozlowski
2015-10-30  6:30       ` Krzysztof Kozlowski
2015-10-30  6:58       ` Pavel Fedin
2015-10-30  6:58         ` Pavel Fedin
2015-10-30  7:23         ` Krzysztof Kozlowski
2015-10-30  7:23           ` Krzysztof Kozlowski
2015-10-30 17:15           ` Rob Herring
2015-10-30 17:15             ` Rob Herring
2015-11-01  8:15             ` Krzysztof Kozlowski
2015-11-01  8:15               ` Krzysztof Kozlowski
2015-10-30 10:43       ` Pavel Fedin
2015-10-30 10:43         ` Pavel Fedin
2015-11-01  8:48         ` Krzysztof Kozlowski
2015-11-01  8:48           ` Krzysztof Kozlowski
2015-11-02  7:31           ` Pavel Fedin
2015-11-02  7:31             ` Pavel Fedin
2015-11-03  0:16             ` Krzysztof Kozlowski
2015-11-03  0:16               ` Krzysztof Kozlowski
2015-11-03  6:58               ` Pavel Fedin
2015-11-03  6:58                 ` Pavel Fedin
2015-11-03  6:58                 ` Pavel Fedin
2015-11-03  7:18                 ` Krzysztof Kozlowski [this message]
2015-11-03  7:18                   ` Krzysztof Kozlowski
2015-11-03  7:18                   ` Krzysztof Kozlowski
2015-10-29 12:42 ` [PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410 Pavel Fedin
2015-10-29 12:42   ` Pavel Fedin
     [not found]   ` <eafa355058ff500a72ff2e3408ab635954467a76.1446122247.git.p.fedin-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-29 17:28     ` Pankaj Dubey
2015-10-29 17:28       ` Pankaj Dubey
2015-10-29 17:28       ` Pankaj Dubey
2015-10-30  6:41       ` Pavel Fedin
2015-10-30  6:41         ` Pavel Fedin
2015-10-30  9:24         ` Pankaj Dubey
2015-10-30  9:24           ` Pankaj Dubey
2015-10-30 10:51           ` Pavel Fedin
2015-10-30 10:51             ` Pavel Fedin
2015-10-29 12:42 ` [PATCH v4 3/4] drivers: exynos-srom: Add support for bank configuration Pavel Fedin
2015-10-29 12:42   ` Pavel Fedin
2015-10-29 12:42 ` [PATCH v4 4/4] ARM: dts: Add Ethernet chip to SMDK5410 Pavel Fedin
2015-10-29 12:42   ` Pavel Fedin
2015-10-29 17:40   ` Pankaj Dubey
2015-10-29 17:40     ` Pankaj Dubey
2015-10-29 17:40     ` Pankaj Dubey
2015-10-29 17:46 ` [PATCH v4 0/4] [PATCH v4 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Pankaj Dubey
2015-10-29 17:46   ` Pankaj Dubey
2015-10-30  6:43   ` Pavel Fedin
2015-10-30  6:43     ` Pavel Fedin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56385FCC.1090007@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=k.kozlowski.k@gmail.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=p.fedin@samsung.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.