From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa@the-dreams.de>, linux-watchdog@vger.kernel.org
Cc: Wim Van Sebroeck <wim@iguana.be>, linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/2] watchdog: include: add units for timeout values in kerneldoc
Date: Tue, 03 Nov 2015 14:48:21 +0000 [thread overview]
Message-ID: <5638C935.60601@roeck-us.net> (raw)
In-Reply-To: <1446537616-3452-2-git-send-email-wsa@the-dreams.de>
On 11/03/2015 12:00 AM, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> include/linux/watchdog.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
> index fbd752de3a24d5..4e99a267878d21 100644
> --- a/include/linux/watchdog.h
> +++ b/include/linux/watchdog.h
> @@ -24,8 +24,8 @@ struct watchdog_device;
> * @stop: The routine for stopping the watchdog device.
> * @ping: The routine that sends a keepalive ping to the watchdog device.
> * @status: The routine that shows the status of the watchdog device.
> - * @set_timeout:The routine for setting the watchdog devices timeout value.
> - * @get_timeleft:The routine that gets the time left before a reset.
> + * @set_timeout:The routine for setting the watchdog devices timeout value (in seconds).
> + * @get_timeleft:The routine that gets the time left before a reset (in seconds).
> * @ref: The ref operation for dyn. allocated watchdog_device structs
> * @unref: The unref operation for dyn. allocated watchdog_device structs
> * @ioctl: The routines that handles extra ioctl calls.
> @@ -59,9 +59,9 @@ struct watchdog_ops {
> * @info: Pointer to a watchdog_info structure.
> * @ops: Pointer to the list of watchdog operations.
> * @bootstatus: Status of the watchdog device at boot.
> - * @timeout: The watchdog devices timeout value.
> - * @min_timeout:The watchdog devices minimum timeout value.
> - * @max_timeout:The watchdog devices maximum timeout value.
> + * @timeout: The watchdog devices timeout value (in seconds).
> + * @min_timeout:The watchdog devices minimum timeout value (in seconds).
> + * @max_timeout:The watchdog devices maximum timeout value (in seconds).
> * @driver-data:Pointer to the drivers private data.
> * @lock: Lock for watchdog core internal use only.
> * @status: Field that contains the devices internal status bits.
>
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa@the-dreams.de>, linux-watchdog@vger.kernel.org
Cc: Wim Van Sebroeck <wim@iguana.be>, linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/2] watchdog: include: add units for timeout values in kerneldoc
Date: Tue, 3 Nov 2015 06:48:21 -0800 [thread overview]
Message-ID: <5638C935.60601@roeck-us.net> (raw)
In-Reply-To: <1446537616-3452-2-git-send-email-wsa@the-dreams.de>
On 11/03/2015 12:00 AM, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> include/linux/watchdog.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
> index fbd752de3a24d5..4e99a267878d21 100644
> --- a/include/linux/watchdog.h
> +++ b/include/linux/watchdog.h
> @@ -24,8 +24,8 @@ struct watchdog_device;
> * @stop: The routine for stopping the watchdog device.
> * @ping: The routine that sends a keepalive ping to the watchdog device.
> * @status: The routine that shows the status of the watchdog device.
> - * @set_timeout:The routine for setting the watchdog devices timeout value.
> - * @get_timeleft:The routine that gets the time left before a reset.
> + * @set_timeout:The routine for setting the watchdog devices timeout value (in seconds).
> + * @get_timeleft:The routine that gets the time left before a reset (in seconds).
> * @ref: The ref operation for dyn. allocated watchdog_device structs
> * @unref: The unref operation for dyn. allocated watchdog_device structs
> * @ioctl: The routines that handles extra ioctl calls.
> @@ -59,9 +59,9 @@ struct watchdog_ops {
> * @info: Pointer to a watchdog_info structure.
> * @ops: Pointer to the list of watchdog operations.
> * @bootstatus: Status of the watchdog device at boot.
> - * @timeout: The watchdog devices timeout value.
> - * @min_timeout:The watchdog devices minimum timeout value.
> - * @max_timeout:The watchdog devices maximum timeout value.
> + * @timeout: The watchdog devices timeout value (in seconds).
> + * @min_timeout:The watchdog devices minimum timeout value (in seconds).
> + * @max_timeout:The watchdog devices maximum timeout value (in seconds).
> * @driver-data:Pointer to the drivers private data.
> * @lock: Lock for watchdog core internal use only.
> * @status: Field that contains the devices internal status bits.
>
next prev parent reply other threads:[~2015-11-03 14:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 8:00 [PATCH 1/2] watchdog: include: fix some typos Wolfram Sang
2015-11-03 8:00 ` Wolfram Sang
2015-11-03 8:00 ` [PATCH 2/2] watchdog: include: add units for timeout values in kerneldoc Wolfram Sang
2015-11-03 8:00 ` Wolfram Sang
2015-11-03 14:48 ` Guenter Roeck [this message]
2015-11-03 14:48 ` Guenter Roeck
2015-11-03 14:47 ` [PATCH 1/2] watchdog: include: fix some typos Guenter Roeck
2015-11-03 14:47 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5638C935.60601@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-sh@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.