[PATCH] Bitbake hob's image detail page should be able to display big logs with display resolution like 1600x900. Freescale yocto project is producing big logs for example.

[PATCH] Bitbake hob's image detail page should be able to display big logs with display resolution like 1600x900. Freescale yocto project is producing big logs for example.

[Joël Esponde]

Moved log boxes into ScrolledWindows to keep them with a small size while being able to display big logs.
Changed buttons alignment from y centered to top for them to be visible directly on first show.

Signed-off-by: Joël Esponde <joel.esponde@gmail.com>
---
 lib/bb/ui/crumbs/imagedetailspage.py | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/lib/bb/ui/crumbs/imagedetailspage.py b/lib/bb/ui/crumbs/imagedetailspage.py
index 352e948..0d8ae81 100755
--- a/lib/bb/ui/crumbs/imagedetailspage.py
+++ b/lib/bb/ui/crumbs/imagedetailspage.py
@@ -75,11 +75,11 @@ class ImageDetailsPage (HobPage):
             # pack the button on the right
             if button:
                 self.bbox = gtk.VBox()
-                self.bbox.pack_start(button, expand=True, fill=False)
+                self.bbox.pack_start(button, expand=False, fill=False)
                 if button2:
-                    self.bbox.pack_start(button2, expand=True, fill=False)
+                    self.bbox.pack_start(button2, expand=False, fill=False)
                 self.bbox.set_size_request(150,-1)
-                self.row.attach(self.bbox, 1, 2, 0, 1, xoptions=gtk.FILL, yoptions=gtk.EXPAND)
+                self.row.attach(self.bbox, 1, 2, 0, 1, xoptions=0, yoptions=gtk.EXPAND|gtk.FILL)
                 
         def update_line_widgets(self, variable, value):
             if len(self.line_widgets) == 0:
@@ -374,7 +374,9 @@ class ImageDetailsPage (HobPage):
             edit_config_button.set_tooltip_text("Edit machine and image recipe")
             edit_config_button.connect("clicked", self.edit_config_button_clicked_cb)
             self.setting_detail = self.DetailBox(varlist=varlist, vallist=vallist, button=edit_config_button)
-            self.box_group_area.pack_start(self.setting_detail, expand=True, fill=True)
+            self.setting_detail_swin = gtk.ScrolledWindow()
+            self.setting_detail_swin.add_with_viewport(self.setting_detail)
+            self.box_group_area.pack_start(self.setting_detail_swin, expand=True, fill=True)
 
         # Packages included, and Total image size
         varlist = ["Packages included: ", "Total image size: "]
@@ -390,7 +392,9 @@ class ImageDetailsPage (HobPage):
         else: # get to this page from "My images"
             edit_packages_button = None
         self.package_detail = self.DetailBox(varlist=varlist, vallist=vallist, button=edit_packages_button)
-        self.box_group_area.pack_start(self.package_detail, expand=True, fill=True)
+        self.package_detail_swin = gtk.ScrolledWindow()
+        self.package_detail_swin.add_with_viewport(self.package_detail)
+        self.box_group_area.pack_start(self.package_detail_swin, expand=True, fill=True)
 
         # pack the buttons at the bottom, at this time they are already created.
         if self.build_succeeded:
-- 
1.9.1

Re: [PATCH] Bitbake hob's image detail page should be able to display big logs with display resolution like 1600x900. Freescale yocto project is producing big logs for example.

[Leonardo Sandoval]

On 11/03/2015 04:08 PM, Joël Esponde wrote:
> Moved log boxes into ScrolledWindows to keep them with a small size while being able to display big logs.
> Changed buttons alignment from y centered to top for them to be visible directly on first show.

you may need to truncate your one-line patch description (summary) in 
order to be accepted. You can include this info on the detailed 
description area.

>
> Signed-off-by: Joël Esponde <joel.esponde@gmail.com>
> ---

Re: [PATCH] Bitbake hob's image detail page should be able to display big logs with display resolution like 1600x900. Freescale yocto project is producing big logs for example.

[Joël Esponde]

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

Le 3 nov. 2015 23:47, "Leonardo Sandoval" <
leonardo.sandoval.gonzalez@linux.intel.com> a écrit :
>
>
>
> On 11/03/2015 04:08 PM, Joël Esponde wrote:
>>
>> Moved log boxes into ScrolledWindows to keep them with a small size
while being able to display big logs.
>> Changed buttons alignment from y centered to top for them to be visible
directly on first show.
>
>
> you may need to truncate your one-line patch description (summary) in
order to be accepted. You can include this info on the detailed description
area.
>
>

OK thanks.
I will try to provide a v2 patch email tomorrow.

>>
>> Signed-off-by: Joël Esponde <joel.esponde@gmail.com>
>> ---

[-- Attachment #2: Type: text/html, Size: 987 bytes --]