* [PATCH V5] mm: memory hot-add: memory can not be added to movable zone defaultly @ 2015-09-15 7:49 ` Changsheng Liu 0 siblings, 0 replies; 6+ messages in thread From: Changsheng Liu @ 2015-09-15 7:49 UTC (permalink / raw) To: akpm, isimatu.yasuaki, vbabka, yasu.isimatu Cc: linux-mm, linux-kernel, wunan, yanxiaofeng, liuchangsheng, fandd, Changsheng Liu From: Changsheng Liu <liuchangcheng@inspur.com> \bAfter the user config CONFIG_MOVABLE_NODE and movable_node kernel option, When the memory is hot added, should_add_memory_movable() return 0 because all zones including movable zone are empty, so the memory that was hot added will be added to the normal zone and the normal zone will be created firstly. But we want the whole node to be added to movable zone defaultly. So we change should_add_memory_movable(): if the user config CONFIG_MOVABLE_NODE and movable_node kernel option it will always return 1 and all zones is empty at the same time, so that the movable zone will be created firstly and then the whole node will be added to movable zone defaultly. If we want the node to be added to normal zone, we can do it as follows: "echo online_kernel > /sys/devices/system/memory/memoryXXX/state" Signed-off-by: Xiaofeng Yan <yanxiaofeng@inspur.com> Signed-off-by: Changsheng Liu <liuchangcheng@inspur.com> Tested-by: Dongdong Fan <fandd@inspur.com> --- mm/memory_hotplug.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 26fbba7..d39dbb0 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1190,6 +1190,9 @@ static int check_hotplug_memory_range(u64 start, u64 size) /* * If movable zone has already been setup, newly added memory should be check. * If its address is higher than movable zone, it should be added as movable. + * And if system boots up with movable_node and config CONFIG_MOVABLE_NOD and + * added memory does not overlap the zone before MOVABLE_ZONE, + * the memory is added as movable * Without this check, movable zone may overlap with other zone. */ static int should_add_memory_movable(int nid, u64 start, u64 size) @@ -1197,6 +1200,11 @@ static int should_add_memory_movable(int nid, u64 start, u64 size) unsigned long start_pfn = start >> PAGE_SHIFT; pg_data_t *pgdat = NODE_DATA(nid); struct zone *movable_zone = pgdat->node_zones + ZONE_MOVABLE; + struct zone *pre_zone = pgdat->node_zones + (ZONE_MOVABLE - 1); + + if (movable_node_is_enabled() + && zone_end_pfn(pre_zone) <= start_pfn) + return 1; if (zone_is_empty(movable_zone)) return 0; -- 1.7.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH V5] mm: memory hot-add: memory can not be added to movable zone defaultly @ 2015-09-15 7:49 ` Changsheng Liu 0 siblings, 0 replies; 6+ messages in thread From: Changsheng Liu @ 2015-09-15 7:49 UTC (permalink / raw) To: akpm, isimatu.yasuaki, vbabka, yasu.isimatu Cc: linux-mm, linux-kernel, wunan, yanxiaofeng, liuchangsheng, fandd, Changsheng Liu From: Changsheng Liu <liuchangcheng@inspur.com> \bAfter the user config CONFIG_MOVABLE_NODE and movable_node kernel option, When the memory is hot added, should_add_memory_movable() return 0 because all zones including movable zone are empty, so the memory that was hot added will be added to the normal zone and the normal zone will be created firstly. But we want the whole node to be added to movable zone defaultly. So we change should_add_memory_movable(): if the user config CONFIG_MOVABLE_NODE and movable_node kernel option it will always return 1 and all zones is empty at the same time, so that the movable zone will be created firstly and then the whole node will be added to movable zone defaultly. If we want the node to be added to normal zone, we can do it as follows: "echo online_kernel > /sys/devices/system/memory/memoryXXX/state" Signed-off-by: Xiaofeng Yan <yanxiaofeng@inspur.com> Signed-off-by: Changsheng Liu <liuchangcheng@inspur.com> Tested-by: Dongdong Fan <fandd@inspur.com> --- mm/memory_hotplug.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 26fbba7..d39dbb0 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1190,6 +1190,9 @@ static int check_hotplug_memory_range(u64 start, u64 size) /* * If movable zone has already been setup, newly added memory should be check. * If its address is higher than movable zone, it should be added as movable. + * And if system boots up with movable_node and config CONFIG_MOVABLE_NOD and + * added memory does not overlap the zone before MOVABLE_ZONE, + * the memory is added as movable * Without this check, movable zone may overlap with other zone. */ static int should_add_memory_movable(int nid, u64 start, u64 size) @@ -1197,6 +1200,11 @@ static int should_add_memory_movable(int nid, u64 start, u64 size) unsigned long start_pfn = start >> PAGE_SHIFT; pg_data_t *pgdat = NODE_DATA(nid); struct zone *movable_zone = pgdat->node_zones + ZONE_MOVABLE; + struct zone *pre_zone = pgdat->node_zones + (ZONE_MOVABLE - 1); + + if (movable_node_is_enabled() + && zone_end_pfn(pre_zone) <= start_pfn) + return 1; if (zone_is_empty(movable_zone)) return 0; -- 1.7.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V5] mm: memory hot-add: memory can not be added to movable zone defaultly 2015-09-15 7:49 ` Changsheng Liu @ 2015-11-03 16:13 ` Yasuaki Ishimatsu -1 siblings, 0 replies; 6+ messages in thread From: Yasuaki Ishimatsu @ 2015-11-03 16:13 UTC (permalink / raw) To: Changsheng Liu Cc: akpm, isimatu.yasuaki, vbabka, linux-mm, linux-kernel, wunan, yanxiaofeng, fandd, Changsheng Liu Hi Changsheng, According to the following thread, Tang has no objection to change kernel behavior since udev cannot online memory as movable. https://lkml.org/lkml/2015/10/21/159 So how about reposting the v5 patch? I have a comment about the patch. Please see below. On Tue, 15 Sep 2015 03:49:58 -0400 Changsheng Liu <liuchangsheng@inspur.com> wrote: > From: Changsheng Liu <liuchangcheng@inspur.com> > > \bAfter the user config CONFIG_MOVABLE_NODE and movable_node kernel option, > When the memory is hot added, should_add_memory_movable() return 0 > because all zones including movable zone are empty, > so the memory that was hot added will be added to the normal zone > and the normal zone will be created firstly. > But we want the whole node to be added to movable zone defaultly. > > So we change should_add_memory_movable(): if the user config > CONFIG_MOVABLE_NODE and movable_node kernel option > it will always return 1 and all zones is empty at the same time, > so that the movable zone will be created firstly > and then the whole node will be added to movable zone defaultly. > If we want the node to be added to normal zone, > we can do it as follows: > "echo online_kernel > /sys/devices/system/memory/memoryXXX/state" > > Signed-off-by: Xiaofeng Yan <yanxiaofeng@inspur.com> > Signed-off-by: Changsheng Liu <liuchangcheng@inspur.com> > Tested-by: Dongdong Fan <fandd@inspur.com> > --- > mm/memory_hotplug.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 26fbba7..d39dbb0 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1190,6 +1190,9 @@ static int check_hotplug_memory_range(u64 start, u64 size) > /* > * If movable zone has already been setup, newly added memory should be check. > * If its address is higher than movable zone, it should be added as movable. > + * And if system boots up with movable_node and config CONFIG_MOVABLE_NOD and > + * added memory does not overlap the zone before MOVABLE_ZONE, > + * the memory is added as movable > * Without this check, movable zone may overlap with other zone. > */ > static int should_add_memory_movable(int nid, u64 start, u64 size) > @@ -1197,6 +1200,11 @@ static int should_add_memory_movable(int nid, u64 start, u64 size) > unsigned long start_pfn = start >> PAGE_SHIFT; > pg_data_t *pgdat = NODE_DATA(nid); > struct zone *movable_zone = pgdat->node_zones + ZONE_MOVABLE; > + struct zone *pre_zone = pgdat->node_zones + (ZONE_MOVABLE - 1); > + > + if (movable_node_is_enabled() > + && zone_end_pfn(pre_zone) <= start_pfn) > + return 1; if (movable_node_is_enabled() && (zone_end_pfn(pre_zone) <= start_pfn)) Thanks, Yasuaki Ishimatsu > > if (zone_is_empty(movable_zone)) > return 0; > -- > 1.7.1 > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V5] mm: memory hot-add: memory can not be added to movable zone defaultly @ 2015-11-03 16:13 ` Yasuaki Ishimatsu 0 siblings, 0 replies; 6+ messages in thread From: Yasuaki Ishimatsu @ 2015-11-03 16:13 UTC (permalink / raw) To: Changsheng Liu Cc: akpm, isimatu.yasuaki, vbabka, linux-mm, linux-kernel, wunan, yanxiaofeng, fandd, Changsheng Liu Hi Changsheng, According to the following thread, Tang has no objection to change kernel behavior since udev cannot online memory as movable. https://lkml.org/lkml/2015/10/21/159 So how about reposting the v5 patch? I have a comment about the patch. Please see below. On Tue, 15 Sep 2015 03:49:58 -0400 Changsheng Liu <liuchangsheng@inspur.com> wrote: > From: Changsheng Liu <liuchangcheng@inspur.com> > > \bAfter the user config CONFIG_MOVABLE_NODE and movable_node kernel option, > When the memory is hot added, should_add_memory_movable() return 0 > because all zones including movable zone are empty, > so the memory that was hot added will be added to the normal zone > and the normal zone will be created firstly. > But we want the whole node to be added to movable zone defaultly. > > So we change should_add_memory_movable(): if the user config > CONFIG_MOVABLE_NODE and movable_node kernel option > it will always return 1 and all zones is empty at the same time, > so that the movable zone will be created firstly > and then the whole node will be added to movable zone defaultly. > If we want the node to be added to normal zone, > we can do it as follows: > "echo online_kernel > /sys/devices/system/memory/memoryXXX/state" > > Signed-off-by: Xiaofeng Yan <yanxiaofeng@inspur.com> > Signed-off-by: Changsheng Liu <liuchangcheng@inspur.com> > Tested-by: Dongdong Fan <fandd@inspur.com> > --- > mm/memory_hotplug.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 26fbba7..d39dbb0 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1190,6 +1190,9 @@ static int check_hotplug_memory_range(u64 start, u64 size) > /* > * If movable zone has already been setup, newly added memory should be check. > * If its address is higher than movable zone, it should be added as movable. > + * And if system boots up with movable_node and config CONFIG_MOVABLE_NOD and > + * added memory does not overlap the zone before MOVABLE_ZONE, > + * the memory is added as movable > * Without this check, movable zone may overlap with other zone. > */ > static int should_add_memory_movable(int nid, u64 start, u64 size) > @@ -1197,6 +1200,11 @@ static int should_add_memory_movable(int nid, u64 start, u64 size) > unsigned long start_pfn = start >> PAGE_SHIFT; > pg_data_t *pgdat = NODE_DATA(nid); > struct zone *movable_zone = pgdat->node_zones + ZONE_MOVABLE; > + struct zone *pre_zone = pgdat->node_zones + (ZONE_MOVABLE - 1); > + > + if (movable_node_is_enabled() > + && zone_end_pfn(pre_zone) <= start_pfn) > + return 1; if (movable_node_is_enabled() && (zone_end_pfn(pre_zone) <= start_pfn)) Thanks, Yasuaki Ishimatsu > > if (zone_is_empty(movable_zone)) > return 0; > -- > 1.7.1 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V5] mm: memory hot-add: memory can not be added to movable zone defaultly 2015-11-03 16:13 ` Yasuaki Ishimatsu @ 2015-11-04 2:44 ` Changsheng Liu -1 siblings, 0 replies; 6+ messages in thread From: Changsheng Liu @ 2015-11-04 2:44 UTC (permalink / raw) To: Yasuaki Ishimatsu Cc: akpm, isimatu.yasuaki, vbabka, linux-mm, linux-kernel, wunan, yanxiaofeng, fandd, Changsheng Liu On 11/4 2015 0:13, Yasuaki Ishimatsu wrote: > Hi Changsheng, > > According to the following thread, Tang has no objection to change kernel > behavior since udev cannot online memory as movable. > > https://lkml.org/lkml/2015/10/21/159 > > So how about reposting the v5 patch? > I have a comment about the patch. Please see below. Thanksi 1/4 ?I will update the patch and repost it > On Tue, 15 Sep 2015 03:49:58 -0400 > Changsheng Liu <liuchangsheng@inspur.com> wrote: > >> From: Changsheng Liu <liuchangcheng@inspur.com> >> >> \bAfter the user config CONFIG_MOVABLE_NODE and movable_node kernel option, >> When the memory is hot added, should_add_memory_movable() return 0 >> because all zones including movable zone are empty, >> so the memory that was hot added will be added to the normal zone >> and the normal zone will be created firstly. >> But we want the whole node to be added to movable zone defaultly. >> >> So we change should_add_memory_movable(): if the user config >> CONFIG_MOVABLE_NODE and movable_node kernel option >> it will always return 1 and all zones is empty at the same time, >> so that the movable zone will be created firstly >> and then the whole node will be added to movable zone defaultly. >> If we want the node to be added to normal zone, >> we can do it as follows: >> "echo online_kernel > /sys/devices/system/memory/memoryXXX/state" >> >> Signed-off-by: Xiaofeng Yan <yanxiaofeng@inspur.com> >> Signed-off-by: Changsheng Liu <liuchangcheng@inspur.com> >> Tested-by: Dongdong Fan <fandd@inspur.com> >> --- >> mm/memory_hotplug.c | 8 ++++++++ >> 1 files changed, 8 insertions(+), 0 deletions(-) >> >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index 26fbba7..d39dbb0 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -1190,6 +1190,9 @@ static int check_hotplug_memory_range(u64 start, u64 size) >> /* >> * If movable zone has already been setup, newly added memory should be check. >> * If its address is higher than movable zone, it should be added as movable. >> + * And if system boots up with movable_node and config CONFIG_MOVABLE_NOD and >> + * added memory does not overlap the zone before MOVABLE_ZONE, >> + * the memory is added as movable >> * Without this check, movable zone may overlap with other zone. >> */ >> static int should_add_memory_movable(int nid, u64 start, u64 size) >> @@ -1197,6 +1200,11 @@ static int should_add_memory_movable(int nid, u64 start, u64 size) >> unsigned long start_pfn = start >> PAGE_SHIFT; >> pg_data_t *pgdat = NODE_DATA(nid); >> struct zone *movable_zone = pgdat->node_zones + ZONE_MOVABLE; >> + struct zone *pre_zone = pgdat->node_zones + (ZONE_MOVABLE - 1); >> + >> + if (movable_node_is_enabled() >> + && zone_end_pfn(pre_zone) <= start_pfn) >> + return 1; > if (movable_node_is_enabled() && (zone_end_pfn(pre_zone) <= start_pfn)) > > Thanks, > Yasuaki Ishimatsu > >> >> if (zone_is_empty(movable_zone)) >> return 0; >> -- >> 1.7.1 >> > . > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V5] mm: memory hot-add: memory can not be added to movable zone defaultly @ 2015-11-04 2:44 ` Changsheng Liu 0 siblings, 0 replies; 6+ messages in thread From: Changsheng Liu @ 2015-11-04 2:44 UTC (permalink / raw) To: Yasuaki Ishimatsu Cc: akpm, isimatu.yasuaki, vbabka, linux-mm, linux-kernel, wunan, yanxiaofeng, fandd, Changsheng Liu On 11/4 2015 0:13, Yasuaki Ishimatsu wrote: > Hi Changsheng, > > According to the following thread, Tang has no objection to change kernel > behavior since udev cannot online memory as movable. > > https://lkml.org/lkml/2015/10/21/159 > > So how about reposting the v5 patch? > I have a comment about the patch. Please see below. Thanks，I will update the patch and repost it > On Tue, 15 Sep 2015 03:49:58 -0400 > Changsheng Liu <liuchangsheng@inspur.com> wrote: > >> From: Changsheng Liu <liuchangcheng@inspur.com> >> >> \bAfter the user config CONFIG_MOVABLE_NODE and movable_node kernel option, >> When the memory is hot added, should_add_memory_movable() return 0 >> because all zones including movable zone are empty, >> so the memory that was hot added will be added to the normal zone >> and the normal zone will be created firstly. >> But we want the whole node to be added to movable zone defaultly. >> >> So we change should_add_memory_movable(): if the user config >> CONFIG_MOVABLE_NODE and movable_node kernel option >> it will always return 1 and all zones is empty at the same time, >> so that the movable zone will be created firstly >> and then the whole node will be added to movable zone defaultly. >> If we want the node to be added to normal zone, >> we can do it as follows: >> "echo online_kernel > /sys/devices/system/memory/memoryXXX/state" >> >> Signed-off-by: Xiaofeng Yan <yanxiaofeng@inspur.com> >> Signed-off-by: Changsheng Liu <liuchangcheng@inspur.com> >> Tested-by: Dongdong Fan <fandd@inspur.com> >> --- >> mm/memory_hotplug.c | 8 ++++++++ >> 1 files changed, 8 insertions(+), 0 deletions(-) >> >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index 26fbba7..d39dbb0 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -1190,6 +1190,9 @@ static int check_hotplug_memory_range(u64 start, u64 size) >> /* >> * If movable zone has already been setup, newly added memory should be check. >> * If its address is higher than movable zone, it should be added as movable. >> + * And if system boots up with movable_node and config CONFIG_MOVABLE_NOD and >> + * added memory does not overlap the zone before MOVABLE_ZONE, >> + * the memory is added as movable >> * Without this check, movable zone may overlap with other zone. >> */ >> static int should_add_memory_movable(int nid, u64 start, u64 size) >> @@ -1197,6 +1200,11 @@ static int should_add_memory_movable(int nid, u64 start, u64 size) >> unsigned long start_pfn = start >> PAGE_SHIFT; >> pg_data_t *pgdat = NODE_DATA(nid); >> struct zone *movable_zone = pgdat->node_zones + ZONE_MOVABLE; >> + struct zone *pre_zone = pgdat->node_zones + (ZONE_MOVABLE - 1); >> + >> + if (movable_node_is_enabled() >> + && zone_end_pfn(pre_zone) <= start_pfn) >> + return 1; > if (movable_node_is_enabled() && (zone_end_pfn(pre_zone) <= start_pfn)) > > Thanks, > Yasuaki Ishimatsu > >> >> if (zone_is_empty(movable_zone)) >> return 0; >> -- >> 1.7.1 >> > . > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-04 2:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <9e3e1a14aae1a1d86cbe0ac245fa7356@s.corp-email.com>
2015-09-15 7:49 ` [PATCH V5] mm: memory hot-add: memory can not be added to movable zone defaultly Changsheng Liu
2015-09-15 7:49 ` Changsheng Liu
2015-11-03 16:13 ` Yasuaki Ishimatsu
2015-11-03 16:13 ` Yasuaki Ishimatsu
2015-11-04 2:44 ` Changsheng Liu
2015-11-04 2:44 ` Changsheng Liu
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.